Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3667951pxb; Mon, 24 Jan 2022 14:54:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJzANNFR/v4GNEO0WpKxeJ3QD/8nPvSXcph0Gn1xy31wa9F8PWnk0CKBiU4h4XYUM9Cl/W0d X-Received: by 2002:a17:902:aa92:b0:149:6e0b:18d0 with SMTP id d18-20020a170902aa9200b001496e0b18d0mr16018684plr.34.1643064898892; Mon, 24 Jan 2022 14:54:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643064898; cv=none; d=google.com; s=arc-20160816; b=vwHWIeG4gvHjB3I+7APbhrlh/dSu9+MUMoRsir4G3SMRRPLlrINSYNfFiqwbHKvDsR 8+2/qAWPZcJiq0meBjz/BjRLSnz6vmHAko3DJMwZBVjtfpgvCHuBb4oIihrcu4OeWVPA rMv0eKeBKrt4RDahMoiL8iRyTbutZMH/KjJMOWLMeIyHbs0H0T+YeCXRJKpnUvNLzX0E PJGct8lNElyVe/Rl5bIwKsjha0QM/TNoWRcDPqhWe07UdUvrHrX9j2QrMMgZA8axw+43 a/VgH2uR3iv0czANvYHBlF5L4jMC36MDRvOLs9wIl7D+4O4iXLHc1ibAMSWa0MMGs3lR hGhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=az6VAl6nki0wIC5D7T0mwJgVwS29d71Vb5Ttw+XmyiM=; b=ZoIUjsz9xZu3+7QKuvzQhARP3Xl7jcq0EYZCekezUqb0B1lN1HC3MFx3HaGX2Cc4FQ AmeWrXjz54dY8eqccFUq07m/OrUXXfew9qeO6w9Pvc145jdqRoj983pifmk1bKBTLYRq ndIPMz83JvGzOXLwAZc05kMoHy6nG5AtAVTLrxlU4G9/QOnDVbir8YfYWKGJGscgWwo/ R4Cd6ng08s0m1jrdLxTWSoNV1obP0+yVa6rkRsRHLNVVHcHXtqB5hrZnXXQXiyrVgwFS m/fkUeBx3QmADCou+J2XatFxztx1C9YuZYgTbMlPZbCa/a1/2IHveUbLoZ8n/gZxfG95 aAUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mK3kCltU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s9si13033821plq.229.2022.01.24.14.54.46; Mon, 24 Jan 2022 14:54:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=mK3kCltU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1839654AbiAXWvg (ORCPT + 99 others); Mon, 24 Jan 2022 17:51:36 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:53258 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378844AbiAXVoD (ORCPT ); Mon, 24 Jan 2022 16:44:03 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3D439B811FC; Mon, 24 Jan 2022 21:44:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49527C340E4; Mon, 24 Jan 2022 21:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643060641; bh=toS2nEL/HovX5hqVgGICDP1uLl/XeY10V55n1+2q4Mw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mK3kCltUOeNehVC9TStqaJT6nH3aqZdCkJSog0K56fv8KhyrieVxnkzoTxzg8hErR oLnsj0xmlxTerWi0LzTG9kP04p4oHx3O3KKhHVS6ftaC/y8tnBy77XGc/aNvvnwsoo GuF/TtS9+LJE1XFGzUSqqKyW/eamoHzx4G1dvMyQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eli Cohen , "Michael S. Tsirkin" , Parav Pandit , Jason Wang , Si-Wei Liu Subject: [PATCH 5.16 0982/1039] vdpa/mlx5: Fix wrong configuration of virtio_version_1_0 Date: Mon, 24 Jan 2022 19:46:11 +0100 Message-Id: <20220124184158.288162031@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184125.121143506@linuxfoundation.org> References: <20220124184125.121143506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eli Cohen commit 97143b70aa847f2b0a1f959dde126b76ff7b5376 upstream. Remove overriding of virtio_version_1_0 which forced the virtqueue object to version 1. Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices") Signed-off-by: Eli Cohen Link: https://lore.kernel.org/r/20211230142024.142979-1-elic@nvidia.com Signed-off-by: Michael S. Tsirkin Reviewed-by: Parav Pandit Acked-by: Jason Wang Reviewed-by: Si-Wei Liu Signed-off-by: Greg Kroah-Hartman --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 -- 1 file changed, 2 deletions(-) --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c @@ -876,8 +876,6 @@ static int create_virtqueue(struct mlx5_ MLX5_SET(virtio_q, vq_ctx, umem_3_id, mvq->umem3.id); MLX5_SET(virtio_q, vq_ctx, umem_3_size, mvq->umem3.size); MLX5_SET(virtio_q, vq_ctx, pd, ndev->mvdev.res.pdn); - if (MLX5_CAP_DEV_VDPA_EMULATION(ndev->mvdev.mdev, eth_frame_offload_type)) - MLX5_SET(virtio_q, vq_ctx, virtio_version_1_0, 1); err = mlx5_cmd_exec(ndev->mvdev.mdev, in, inlen, out, sizeof(out)); if (err)