Date: Tue, 6 Feb 2007 19:46:26 +0000
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Woodhouse <dwmw2@infradead.org>, Robert Hancock <hancockr@shaw.ca>,
       linux-kernel <linux-kernel@vger.kernel.org>, drzeus-wbsd@drzeus.cx,
       wbsd-devel@list.drzeus.cx
Subject: Re: [PATCH] kernel: shut up the IRQ mismatch messages (Re: wbsd:
 IRQ handler type mismatch)
Message-ID: <20070206194626.5a8f47ab@localhost.localdomain>
In-Reply-To: <20070206112949.1fc99299.akpm@linux-foundation.org>
References: <45C7F32B.1060402@shaw.ca>
	<20070206113023.3c845bb2@localhost.localdomain>
	<20070206112949.1fc99299.akpm@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1186
Lines: 34

> > Signed-off-by: Alan Cox <alan@redhat.com>
> > 
> > --- linux.vanilla-2.6.20-rc6-mm3/kernel/irq/manage.c	2007-01-31 14:20:43.000000000 +0000
> > +++ linux-2.6.20-rc6-mm3/kernel/irq/manage.c	2007-02-06 11:01:00.796928504 +0000
> > @@ -372,12 +372,14 @@
> >  	return 0;
> >  
> >  mismatch:
> > +#ifdef CONFIG_DEBUG_SHIRQ
> >  	if (!(new->flags & IRQF_PROBE_SHARED)) {
> >  		printk(KERN_ERR "IRQ handler type mismatch for IRQ %d\n", irq);
> >  		if (old_name)
> >  			printk(KERN_ERR "current handler: %s\n", old_name);
> >  		dump_stack();
> >  	}
> > +#endif	
> >  	spin_unlock_irqrestore(&desc->lock, flags);
> >  	return -EBUSY;
> >  }
> 
> hm, well, it's dependent upon dwmw2's
> generate-a-spurious-irq-at-request_irq-time patch.  Do we want to merge
> that?

CONFIG_DEBUG_SHIRQ seemed to be the right configuration option
irrespective of whether we merge Dave's spurious irq tester (which I
think is actually a good test tool)

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/