Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3685506pxb; Mon, 24 Jan 2022 15:19:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJxtJCxLbulgm0abjdcfuRNh64S6FP5DnQiab6d5FggazhBOeiOMrY77oxI0PA6gmB1MK/Uk X-Received: by 2002:a17:902:7fc8:b0:14a:e403:2f18 with SMTP id t8-20020a1709027fc800b0014ae4032f18mr16363391plb.45.1643066358499; Mon, 24 Jan 2022 15:19:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643066358; cv=none; d=google.com; s=arc-20160816; b=shvkpLjEX0djhndbwtNGz0K/oVcPASKW5K2n2820GY0k1CKW1J2mnhnAWH8eX9giY+ yGW2BXu01Xrwk8DjxN4yXEdOPVVAEH1zeA+6IyulNQuUcPFQqrt2QQ6tVh7uJZ/qMaRT 1NYuzgcUjmQiE9dPHgSf03Tg07CGtwhGkdpuxVVzvQ0lFtYCvPyn1AckqnyfY/+ge6L2 FKqznoW4ZPTjfWuPqyNb/UOnWGCn5dF6N4j4OlzRxMmO4jsXUoX39Xp9YVEuU5IZLTTP rfLtrz5SiWTk9mlgIxSKkxlIT08zzsDBP68vyJIrmfF0BYJcVUFOO/bokHKwnI7MYPmI nenw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TwwrwryZ10AB1RPQ1SV8CXqZA6l2bH4SjekCFyYciGI=; b=ZUfCvEzlKA9yMAFCDfVwiFJlvZjhAFFGGcPLQdq5TdgyK9x74Hy/HlRUxx6XYiPru+ //zI8nfa/pa7j2GdNJV6lOCHN9Wn4erSOm+UcXodm5KPAJY6txHdqV6v4gPdWSCteYJr 9nj7P83uhB+ofMGC/JvsqlcGTIKoSyVqnv65eWGqDL3A4U5Cm7ufCJco7qIYsfKC+l4a RvA/8st9733MFEEq273g4ddv+Yp29B1NXVyT0hZCvX9sE+pDmoH9aI5pTQ3+18Kl91ZP 9MKQ9FfBEY3rW4IEuhj1+tJYCJrEFhD6WewriSrR9GCIWo63Yd1tiFpro5lusaLfpepz QmOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XQZ27Uyz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i191si11594085pge.679.2022.01.24.15.19.07; Mon, 24 Jan 2022 15:19:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XQZ27Uyz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1846959AbiAXXRc (ORCPT + 99 others); Mon, 24 Jan 2022 18:17:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1582577AbiAXWPa (ORCPT ); Mon, 24 Jan 2022 17:15:30 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00A73C0E263F; Mon, 24 Jan 2022 12:44:49 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BCAECB810BD; Mon, 24 Jan 2022 20:44:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0E40C340E5; Mon, 24 Jan 2022 20:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643057087; bh=d1hkeXXrifR0cTOtk0pASdzSQrHKudV+b+y9Amq7KG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XQZ27UyzFb7uhRFvc1uGHhNAQZzsmGFlgMNo7t2iGLzpubq1ynRCycg2t3emGDzgk +x5sO1pTjEPhm2pLheeMDG9mZ5E3mlTRJOFEzZn6P3HFVlEXBPRGSbvU1aZbiTMhwv owqYUORdckWMf1wBSBkUcaTcJEsrxCjGgw1QuOn0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alex Deucher Subject: [PATCH 5.15 698/846] drm/amdgpu: dont do resets on APUs which dont support it Date: Mon, 24 Jan 2022 19:43:35 +0100 Message-Id: <20220124184125.131911663@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184100.867127425@linuxfoundation.org> References: <20220124184100.867127425@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alex Deucher commit e8309d50e97851ff135c4e33325d37b032666b94 upstream. It can cause a hang. This is normally not enabled for GPU hangs on these asics, but was recently enabled for handling aborted suspends. This causes hangs on some platforms on suspend. Fixes: daf8de0874ab5b ("drm/amdgpu: always reset the asic in suspend (v2)") Cc: stable@vger.kernel.org Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1858 Signed-off-by: Alex Deucher Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/amdgpu/cik.c | 4 ++++ drivers/gpu/drm/amd/amdgpu/vi.c | 4 ++++ 2 files changed, 8 insertions(+) --- a/drivers/gpu/drm/amd/amdgpu/cik.c +++ b/drivers/gpu/drm/amd/amdgpu/cik.c @@ -1428,6 +1428,10 @@ static int cik_asic_reset(struct amdgpu_ { int r; + /* APUs don't have full asic reset */ + if (adev->flags & AMD_IS_APU) + return 0; + if (cik_asic_reset_method(adev) == AMD_RESET_METHOD_BACO) { dev_info(adev->dev, "BACO reset\n"); r = amdgpu_dpm_baco_reset(adev); --- a/drivers/gpu/drm/amd/amdgpu/vi.c +++ b/drivers/gpu/drm/amd/amdgpu/vi.c @@ -956,6 +956,10 @@ static int vi_asic_reset(struct amdgpu_d { int r; + /* APUs don't have full asic reset */ + if (adev->flags & AMD_IS_APU) + return 0; + if (vi_asic_reset_method(adev) == AMD_RESET_METHOD_BACO) { dev_info(adev->dev, "BACO reset\n"); r = amdgpu_dpm_baco_reset(adev);