Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Ismail, Mohammad Athari" <mohammad.athari.ismail@intel.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Jose Abreu <joabreu@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
        "Ong, Boon Leong" <boon.leong.ong@intel.com>,
        "Voon, Weifeng" <weifeng.voon@intel.com>,
        "Wong, Vee Khee" <vee.khee.wong@intel.com>,
        Huacai Chen <chenhuacai@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net 2/2] net: stmmac: skip only stmmac_ptp_register when
 resume from suspend
Thread-Topic: [PATCH net 2/2] net: stmmac: skip only stmmac_ptp_register when
 resume from suspend
Thread-Index: AQHYEQlKejz1LyD95Uq5S5Mw/hCt1KxyJtCAgACV8/A=
Date:   Mon, 24 Jan 2022 22:19:22 +0000
Message-ID: <CO1PR11MB47716D7115E85AC4649CD3A5D55E9@CO1PR11MB4771.namprd11.prod.outlook.com>
References: <20220124095951.23845-1-mohammad.athari.ismail@intel.com>
 <20220124095951.23845-3-mohammad.athari.ismail@intel.com>
 <Ye6maxMtt68JlZ9l@lunn.ch>
In-Reply-To: <Ye6maxMtt68JlZ9l@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5/bVobfpoPl29sCON0oLrfFq8JkCpWM6q+fcuHQWgWizTgdMUQlrLKrP9ODE?=
 =?us-ascii?Q?xqUncH3UL5olLFJWwPx3cKfp6g6GfEaX4KY8SGNrP5oOiPGcrdybvbo/zIee?=
 =?us-ascii?Q?UZNWzVWUef4/HoJ0WoZApFe+Cw7m5CmqU3qkmE67akaay2I6rUt5BF29/CEi?=
 =?us-ascii?Q?0w3E2l2+3GcKGbppLrRE67cG+dPbovmuUtdpyKblqQNbs8ESWN2ZhfAQDwN+?=
 =?us-ascii?Q?tnR89Z4rbxOpiys0yHTIYmSmQOcYGktVxuiZy7y45hI2NzFlPEIeZQnZsSyd?=
 =?us-ascii?Q?/6VvYgXwBy4AdOPrdK5B933dmRz7gMSFsRetLf1JsWt9PXMRjDq1UyBaBPVG?=
 =?us-ascii?Q?CRI/z4DXDM7p7YLrRm0XjvyUc+NrC0FRlzjMquY4lh73tN5p7eFbhjAhSGP5?=
 =?us-ascii?Q?xSBCBN9jq828HjTOWbNB2KGA6oZemi9dWK7HDWLEggmRDSug0+ogNOfDCJz8?=
 =?us-ascii?Q?Kg0TWz2NzjvjxCdwfznFZCR1ez41CgtTtQZpqRqxvW49A8S43o9FtmUrrwPo?=
 =?us-ascii?Q?DwneogHS6oqOvR5NqIn1u4IfhAgnD/C4b/k//iCX8o9OH9IobfG52TeDZeUD?=
 =?us-ascii?Q?16XSXrGtTDZ7Fz2P010MbOD1Qw+l8eonxJqh3PF4u8KQKPhLUyndiDP1+MJ0?=
 =?us-ascii?Q?O5R8O61yzKG4WAqUDxAM4XjSP5k0QTBveFiMcLG6ijMCYc8yPvdeLpku4fgO?=
 =?us-ascii?Q?bOUAI6wejOTSgM1rO7jAybzwSaJAv3MzgtI/vlSq/h7wxvdiLSMI8ksGOM+q?=
 =?us-ascii?Q?xEqzOSFvTUnBT9hvx/qGvipDB9N0o1u5dGzNM653wuNIU/akgQo2HNgYShHW?=
 =?us-ascii?Q?x/RHaqIMyZwZlinNj7b3rM90H/MmOP4UfsqBXIM4lLPLKm1vlBX8nX1Z4nqD?=
 =?us-ascii?Q?c9K1WCicIuqR+dJpp0Vxzz0MvI/TJ7N9e4yQbH3j2tzvhG+0zbACfM6tooNu?=
 =?us-ascii?Q?dL8+kZXdLTH3Q1iLnYgjsic0r57k18zKTmRnxCBFgGL17rGxJqKyDz5GQiHP?=
 =?us-ascii?Q?SYr8Zj6YzB6+pz9FTrCQE0O9QlexGLtcI4JqC8YNP8Gjwd9zCRi2Mj9DjMUm?=
 =?us-ascii?Q?C+RP1LJKqBbRhKPOfldxhlcCDO0vDfEz8GArBJzfWQ5jxpAwea8g0BrT7zMK?=
 =?us-ascii?Q?ou6STh8IsL6qS+A6sPIH5jto7i9HUBKY9L6UBZm40lk75nSnL1awR8nQXX/H?=
 =?us-ascii?Q?qztDQaQpWQsVTpNWoG5DuFxDk7ea/Cs36sdhHCYhoDMynDG7ZMxGRQaM07Wv?=
 =?us-ascii?Q?0+cAGZMZhisfELGDDcFdtk960zCNNOeZ3li2QWm2gL/jukbXnBSERYcZV68A?=
 =?us-ascii?Q?DX/2g8CInkazWTAaY2VsJBAB757bBZCIKndBksT7fqYVf+9wJ2eKX/tnN7hI?=
 =?us-ascii?Q?t6lfNUCrFxKbgNRMvqWCkujiZlToXqTujSezQelP6AWRvfbekYOVcePk/OnJ?=
 =?us-ascii?Q?kkMyUhIcoBH6iTrMYdw75+73BhSadoyobZhxEUEnkW+iBIychc/1ZBiH5CrW?=
 =?us-ascii?Q?D/pueu/QZQC822amX4tXBsyBx/f8kwHLhOxwGfCXo7t26Y7JioDh9VeyPygO?=
 =?us-ascii?Q?Lz2Kpn++rOb23kBuNj1LIGpMa1L/zg1qnaRYCyQDtfc5e+5EZxhDqpBqP4qT?=
 =?us-ascii?Q?M428r/s6HC+raSyX49EC7GZiDA6SjCCdjOU8FXLvbxxfWGTwxLuuUkyMJ6FJ?=
 =?us-ascii?Q?g3LK5qNeost7NO51sabDCMOksrbDSd047FRb4zJINswxj7zYLGPG6I3ya53K?=
 =?us-ascii?Q?76OAwGThSA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4771.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 37533dcd-13a4-4cc4-07fd-08d9df8792ec
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2022 22:19:22.6907
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: KFT4GxVG7WpRinjXOXeojP00ITTRBkB5nKJYVwMeIqAcZUJfnLAM/7UfgOLiZdWOqbUVhbHVIcOiHoiXFd+U3J+20kxz+9GCiA1eztySz441CCMz2XJtMZWUKBmUgEPU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5703
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Monday, January 24, 2022 9:15 PM
> To: Ismail, Mohammad Athari <mohammad.athari.ismail@intel.com>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>; Alexandre Torgue
> <alexandre.torgue@st.com>; Jose Abreu <joabreu@synopsys.com>; David
> S . Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>;
> Maxime Coquelin <mcoquelin.stm32@gmail.com>; Ong, Boon Leong
> <boon.leong.ong@intel.com>; Voon, Weifeng <weifeng.voon@intel.com>;
> Wong, Vee Khee <vee.khee.wong@intel.com>; Huacai Chen
> <chenhuacai@kernel.org>; netdev@vger.kernel.org; linux-stm32@st-md-
> mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH net 2/2] net: stmmac: skip only stmmac_ptp_register
> when resume from suspend
>=20
> > @@ -3308,13 +3309,11 @@ static int stmmac_hw_setup(struct net_device
> *dev, bool init_ptp)
> >
> >  	stmmac_mmc_setup(priv);
> >
> > -	if (init_ptp) {
> > -		ret =3D stmmac_init_ptp(priv);
> > -		if (ret =3D=3D -EOPNOTSUPP)
> > -			netdev_warn(priv->dev, "PTP not supported by
> HW\n");
> > -		else if (ret)
> > -			netdev_warn(priv->dev, "PTP init failed\n");
> > -	}
> > +	ret =3D stmmac_init_ptp(priv, ptp_register);
> > +	if (ret =3D=3D -EOPNOTSUPP)
> > +		netdev_warn(priv->dev, "PTP not supported by HW\n");
> > +	else if (ret)
> > +		netdev_warn(priv->dev, "PTP init failed\n");
>=20
> The init_ptp parameter now seems unused? If so, please remove it.

I believe you miss below diff. It is renamed to ptp_register.

-static int stmmac_hw_setup(struct net_device *dev, bool init_ptp)
+static int stmmac_hw_setup(struct net_device *dev, bool ptp_register)
 {
 	struct stmmac_priv *priv =3D netdev_priv(dev);


There are build warnings as below. I'll fix it in v2.

../drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:888: warning: Function=
 parameter or member 'ptp_register' not described in 'stmmac_init_ptp'
../drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:3256: warning: Excess =
function parameter 'init_ptp' description in 'stmmac_hw_setup

Thanks

-Athari-

>=20
>     Andrew