Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3691054pxb; Mon, 24 Jan 2022 15:29:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJwoFO6O/sW5IEgpP89iKQAoEoxdThhHZ+6+uOelbzssFJ5ofAqYnTizm8b28ljkSPzyP5lN X-Received: by 2002:a17:902:6502:b0:149:1162:f0b5 with SMTP id b2-20020a170902650200b001491162f0b5mr16194683plk.126.1643066955434; Mon, 24 Jan 2022 15:29:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643066955; cv=none; d=google.com; s=arc-20160816; b=n1PiKcVrX5sKs+2kBgKlY8uYGa4YCuZJhETb6JvCzkrcIu2KMZGnV9C+SVPoOPJS2e nzyTcIV9fODed9PkN+JpMhHN3/awFmJ5aukwqk5/HJ8k8JrSJJ1ghyHITWDCTmHCX1vY K4EK7buERYq8nAcl4AtHWZR+qAWGMe789Abz+D6CPNb+/YuMuXizLamgPZYF4N96UdoJ YOJsh2yttbQ/PS9HZEUaqRcSdDxEc4oYgBDwKzJmjgoAdFdKsecJioK4tSGb5dQeDUOB 83NOol2ahgNSMXEsMmTg+wD3qG/mqOmDreF7WKhp0D7HzylX5qYbmOzGZPDqMj9D9vmM qWdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=OnrQZ0e9eNF2v5MiJfv/IgvQxVWEcACjpIyGGNOFaEE=; b=omQ0HDAeTOAj02Tbi1rQDPNQ0W1dbdF0eC5RW0cOL0UKUhUYKKOqvheZHSl5MbQfV/ 2BFs64ayXRB3WqmsNWWn+adHL9tEXj+e4DjCuYfPZ4RH3yoGgCxVtZ0bjuV3M3YDBk3v 1irKRtbdUzl07jKwtgR7dgLXabxSIBz0XtI66kwSatXEHJg+iY8OUeGAL4lxkdzUyyaE D3viF/7y02HI0Fj1Gc5bt+UVMC0Csgk+NH6/NQl0Y27rMu+ctPHvgDbMrjXL09sMa2xz 1v2x4eBWF1GuFki59/MPLndfbW/uqBtzltt8x1EiEKAcUHrP6jDkPUvHscAtC3A729sk NkGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hvSKaK3i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s190si14677328pgs.76.2022.01.24.15.29.01; Mon, 24 Jan 2022 15:29:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hvSKaK3i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1848998AbiAXXYb (ORCPT + 99 others); Mon, 24 Jan 2022 18:24:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1588164AbiAXWbj (ORCPT ); Mon, 24 Jan 2022 17:31:39 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 859B3C047CE3; Mon, 24 Jan 2022 12:57:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 259A5611C8; Mon, 24 Jan 2022 20:57:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 033E7C340E5; Mon, 24 Jan 2022 20:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643057828; bh=5mn8xY2Rw2yKpuokmAWh9/JaNI4qxPL/snAS97h6juY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hvSKaK3iLPmDzpWIwoSiRXrEjsqHJ6LtUXH3Rcg8lauJa7x24IACbmMmk5IIyOUHB q8hP4+HYdGt822MsA3V84ZD+AuJy1hpHW4Vb3f2yHgaUrw6Z0sZ1GI8zLN7V/WgL01 k8h0hioavYDL6YO6zz0jGdOzTXLyMIjSySqrRJq8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Wang Hai , Marcel Holtmann , Sasha Levin Subject: [PATCH 5.16 0093/1039] Bluetooth: cmtp: fix possible panic when cmtp_init_sockets() fails Date: Mon, 24 Jan 2022 19:31:22 +0100 Message-Id: <20220124184128.282005419@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184125.121143506@linuxfoundation.org> References: <20220124184125.121143506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wang Hai [ Upstream commit 2a7ca7459d905febf519163bd9e3eed894de6bb7 ] I got a kernel BUG report when doing fault injection test: ------------[ cut here ]------------ kernel BUG at lib/list_debug.c:45! ... RIP: 0010:__list_del_entry_valid.cold+0x12/0x4d ... Call Trace: proto_unregister+0x83/0x220 cmtp_cleanup_sockets+0x37/0x40 [cmtp] cmtp_exit+0xe/0x1f [cmtp] do_syscall_64+0x35/0xb0 entry_SYSCALL_64_after_hwframe+0x44/0xae If cmtp_init_sockets() in cmtp_init() fails, cmtp_init() still returns success. This will cause a kernel bug when accessing uncreated ctmp related data when the module exits. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: Hulk Robot Signed-off-by: Wang Hai Signed-off-by: Marcel Holtmann Signed-off-by: Sasha Levin --- net/bluetooth/cmtp/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/bluetooth/cmtp/core.c b/net/bluetooth/cmtp/core.c index 0a2d78e811cf5..83eb84e8e688f 100644 --- a/net/bluetooth/cmtp/core.c +++ b/net/bluetooth/cmtp/core.c @@ -501,9 +501,7 @@ static int __init cmtp_init(void) { BT_INFO("CMTP (CAPI Emulation) ver %s", VERSION); - cmtp_init_sockets(); - - return 0; + return cmtp_init_sockets(); } static void __exit cmtp_exit(void) -- 2.34.1