Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3696250pxb; Mon, 24 Jan 2022 15:37:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJwJykexlbmnVuhiypoHonuT7ENbM83L1sM12XiKV4i6Wj1ewvJWLDHf+bRkZ/jKavUOaIAs X-Received: by 2002:a65:508c:: with SMTP id r12mr13223729pgp.298.1643067456739; Mon, 24 Jan 2022 15:37:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643067456; cv=none; d=google.com; s=arc-20160816; b=PLKYoNDT1j6drbbFM/HWPr666A23pWVwv404vs1R+ygXzxjuczd2VDUeTaFW2Er2IK ftfE3adg+2PmbOQYXma5dzTy8FRo5fYj/XNVWfHLHwgF0nAdmMI4W6N1sRFpJqwQE6vx EDThtGHSEn2s6PLotJcxxya7n+fBkqROOKOx1hUXVZEBw8Fcbpjpnba8uHEI8j5bbKNE uVnl4g9CbqwhNXCsAyI0t1+D0uEwOL5ux01983nqfsL2vdC2KoEzyqskaY/lUgzf/X/1 SjXvMYKW9/npbDmcdLeMIvpabtkT7NXaB8q+o0Vv1cmQ9b98MYgGbKuYc9zVwfR2LcVD 9A9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hP33WxiESKCl6UiFvuF5SarWIIeZtSawMVFIR5ztFYg=; b=RgEfMPdTRzICxFp2x6A3wDcRZ7VLr8814g86WwzV60Rms07cLIEbMam6/w0u3yaLLU WY3EUV8n0ZsD3XtR1BKnVGyVFuDP81XgKHqI9NI+1926J+Wmqi4ruX79vP3OYyi7W2Bp oF2yX/1KfgazvFgfgXv5zLKVbJCojcdPGiaCyxOX+1cFarHYLCFrm5JnthR1ZNEqXXpX GmWLNVTd7wm3nxgj7334IgFYz0xbVVaVmZW70dzdeSXrJ0Qw7i8i2FwOkfVygZyJiU/q jH+1gzJTFpe9FDxmkdwHfw7ZsrhimDkgHCX41KNAMNkAtgTTUU/wxdiBl+2FeTOZIPEW hdrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wDuehuSc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 32si617778pjz.151.2022.01.24.15.37.25; Mon, 24 Jan 2022 15:37:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wDuehuSc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1850524AbiAXXaI (ORCPT + 99 others); Mon, 24 Jan 2022 18:30:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1581137AbiAXWLS (ORCPT ); Mon, 24 Jan 2022 17:11:18 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAE84C0DF2EC; Mon, 24 Jan 2022 12:43:29 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 822A7B8121C; Mon, 24 Jan 2022 20:43:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91B7DC340E5; Mon, 24 Jan 2022 20:43:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643057007; bh=llqmotql0dU1BNpAsfO0Bt9goMpDGsF/FGV07efugkg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wDuehuScoYVnrWOIfoZwD3gq9mEZeOSHfypQOpk1YIIQZhPapuTil7WAgo8JhDbsx n2pLFggk6fMxbecfc7GMeG8XVrlYpdkjgwCLaBXqHPu/tfQW2UB1nJl+WvA+Id1OxW zykcFNJ1+lrGYrAj7PraCMZHJGMB0T3YM5ASnD9I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Meng Li , =?UTF-8?q?Horia=20Geant=C4=83?= , Herbert Xu Subject: [PATCH 5.15 671/846] crypto: caam - replace this_cpu_ptr with raw_cpu_ptr Date: Mon, 24 Jan 2022 19:43:08 +0100 Message-Id: <20220124184124.224047919@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184100.867127425@linuxfoundation.org> References: <20220124184100.867127425@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Meng Li commit efd21e10fc3bf4c6da122470a5ae89ec4ed8d180 upstream. When enable the kernel debug config, there is below calltrace detected: BUG: using smp_processor_id() in preemptible [00000000] code: cryptomgr_test/339 caller is debug_smp_processor_id+0x20/0x30 CPU: 9 PID: 339 Comm: cryptomgr_test Not tainted 5.10.63-yocto-standard #1 Hardware name: NXP Layerscape LX2160ARDB (DT) Call trace: dump_backtrace+0x0/0x1a0 show_stack+0x24/0x30 dump_stack+0xf0/0x13c check_preemption_disabled+0x100/0x110 debug_smp_processor_id+0x20/0x30 dpaa2_caam_enqueue+0x10c/0x25c ...... cryptomgr_test+0x38/0x60 kthread+0x158/0x164 ret_from_fork+0x10/0x38 According to the comment in commit ac5d15b4519f("crypto: caam/qi2 - use affine DPIOs "), because preemption is no longer disabled while trying to enqueue an FQID, it might be possible to run the enqueue on a different CPU(due to migration, when in process context), however this wouldn't be a functionality issue. But there will be above calltrace when enable kernel debug config. So, replace this_cpu_ptr with raw_cpu_ptr to avoid above call trace. Fixes: ac5d15b4519f ("crypto: caam/qi2 - use affine DPIOs") Cc: stable@vger.kernel.org Signed-off-by: Meng Li Reviewed-by: Horia Geantă Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/caam/caamalg_qi2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/crypto/caam/caamalg_qi2.c +++ b/drivers/crypto/caam/caamalg_qi2.c @@ -5470,7 +5470,7 @@ int dpaa2_caam_enqueue(struct device *de dpaa2_fd_set_len(&fd, dpaa2_fl_get_len(&req->fd_flt[1])); dpaa2_fd_set_flc(&fd, req->flc_dma); - ppriv = this_cpu_ptr(priv->ppriv); + ppriv = raw_cpu_ptr(priv->ppriv); for (i = 0; i < (priv->dpseci_attr.num_tx_queues << 1); i++) { err = dpaa2_io_service_enqueue_fq(ppriv->dpio, ppriv->req_fqid, &fd);