Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CABXGCsNb22JCJ4AyR1sYqFtF4QUnvM3B2zQcc1svcm2mquWxoA@mail.gmail.com>
 <YeUvvIaVJnJrrpYe@kuha.fi.intel.com> <CABXGCsO5PYBuZ11YR16NLLa0H07Jom1JQhWHFuETfotfBfzkMw@mail.gmail.com>
 <YeVQsRp7aDMcQKs7@kuha.fi.intel.com> <CABXGCsMWXFFQY3L8ixK9K-gYX41_gTjqHRBXNp6gDpUgdnvFfg@mail.gmail.com>
 <YeVfYOhxGTgg8VpZ@kuha.fi.intel.com> <CABXGCsOwsP7NJ67oyK3HPs2EarSJKLB9EVW7oEh+8bAFihSa8g@mail.gmail.com>
 <Yea8p1b/sZYKNGaB@kuha.fi.intel.com> <YebBq/WDeYCIvwYw@kuha.fi.intel.com> <CANcMJZDrs418aUoVS4CijQFqgAW3pCbfm_NUCmx+T7HNoiMVnQ@mail.gmail.com>
In-Reply-To: <CANcMJZDrs418aUoVS4CijQFqgAW3pCbfm_NUCmx+T7HNoiMVnQ@mail.gmail.com>
From:   Len Brown <lenb@kernel.org>
Date:   Mon, 24 Jan 2022 18:00:24 -0500
Message-ID: <CAJvTdKnMKdQ6KJe63phZ87kJz2SjeQoNTHqajSfv4RJo6+Y6jw@mail.gmail.com>
Subject: Re: [Bug][5.17-rc0] Between commits daadb3bd0e8d and 455e73a07f6e,
 the kernel stops loading on my devices.
To:     John Stultz <john.stultz@linaro.org>
Cc:     Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>,
        Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
        rafael.j.wysocki@intel.com, linux-usb@vger.kernel.org,
        YongQin Liu <yongqin.liu@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Tested-by: Len Brown <len.brown@intelcom>

The typec_link_ports crash goes away w/ the 2nd patch.

https://bugzilla.kernel.org/show_bug.cgi?id=215529

On Fri, Jan 21, 2022 at 4:33 PM John Stultz <john.stultz@linaro.org> wrote:
>
> On Thu, Jan 20, 2022 at 3:27 AM Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
> > On Tue, Jan 18, 2022 at 03:12:10PM +0200, Heikki Krogerus wrote:
> > > I can reproduce this one by simply not creating the component list in
> > > the code. That function - component_master_add_with_match() - can't
> > > handle situation where the list is empty. I'll prepare the fix.
> >
> > I'm again attaching the proposed fix, just to see if it also gets
> > corrupted. Can you test does it fix this issue?
> > You need to apply it on top of the previous one.
>
> We've been hitting the null pointer crash from
> component_master_add_with_match() regression as well on the hikey960
> board.
>
> The patch you attached resolves the issue. It would be great to see it
> merged upstream soon!
>
> Tested-by: John Stultz <john.stultz@linaro.org>
>
> thanks
> -john


-- 
Len Brown, Intel Open Source Technology Center