Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3707431pxb; Mon, 24 Jan 2022 15:57:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJxjeAf95o1QkYYfi9+zAemkT/s/Tj6lu0fQYY+tjmuf6zjfFONeJ4UT8SzUL3wpEt7KrY+v X-Received: by 2002:a63:82c7:: with SMTP id w190mr2283388pgd.573.1643068675248; Mon, 24 Jan 2022 15:57:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643068675; cv=none; d=google.com; s=arc-20160816; b=BZofWxwQbeFUYhppIFm/MJZrjx2rcJeC10RPBh9yS4r68GUBO7UrRYljEQz+Jju9d0 86nWTBkCcHFS+pR7Ez7sAhzqnUY1OoGWo8X15oeCSmAuA0Di6SDPChanlT896+oGPpiW uoxGV1ZR4Fea+WJelz32F7HW8bA0nsHpSxB1WCCHg5H897hO8c8k5mXk607MpoqO3id1 OrFXj4FsdpRic0WF1WSpEwXeYE4FbebSKV6jotjFlZsowHKw0GehWaN9IGDH+Wq6dTVJ PI9Sa0OpJRhc6hjKYi7czMguCDQgB9Tj9LiIoZcwvSBtxLEFxyIe5TlK2d+rZQnUjCCs Q0uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=M0SM1W6n24g7ktW2BA7bShlaGNnWGqMA7OKCc/qYAOA=; b=tEZduXnMyfssH9rDmdfE3bYyg8Apb4VnpHTT2cQDH2BOnB8HNg7m/e+6PlPeeP39F0 M//mToR16UQSdNmPptbq3KsE6xUPSyMvMG97ymQCQI5t/sTwb84E4LjFUV4aDDS/W6+Y 0zqOhMKDrQaAv6zfJ7ANuo41ocVwIu0VdeglQkmMRc/L1tE3hwIU1Nw1hQwQBx1IZ8cg TMVntxk43aK/tei8sUh0DTtYTj+AR18yJpajrOU1F1VgyCYIUUHr+3qDBtyt1dPUGhnw jwa/5+LChC3CJL+ypdsYfLmkPNwFVgrwqDMgMw2SGY2/bpWHfWsaJ9jA63OFIsBcx8l4 joPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=E92vEJtc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rm9si678645pjb.26.2022.01.24.15.57.43; Mon, 24 Jan 2022 15:57:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=E92vEJtc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2366052AbiAXXwN (ORCPT + 99 others); Mon, 24 Jan 2022 18:52:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1845409AbiAXXMO (ORCPT ); Mon, 24 Jan 2022 18:12:14 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C86FC028C17; Mon, 24 Jan 2022 13:19:29 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 73D46B80FA1; Mon, 24 Jan 2022 21:19:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3327C340E5; Mon, 24 Jan 2022 21:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643059166; bh=CjNurEu/6+GsUqTQ4NQoldgfbFXncMWtPF0rfbat62k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E92vEJtcPCkzkqsLYZn4fiUMytUYzCiXPoQHY0avIeZa2rVc63L45Ble4419bwICz /osIhah8Bt+lhXJHp2qteLnp8jHnvhLaWSGMURrl1VxvOiSLGwKz6RPocA6xjtHEtg lpxTPGUqp3Sn9HR5cnxNoGqceSxyCHa0Z3Jsxl8Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Shengjiu Wang , Mark Brown , Sasha Levin Subject: [PATCH 5.16 0526/1039] ASoC: imx-card: Fix mclk calculation issue for akcodec Date: Mon, 24 Jan 2022 19:38:35 +0100 Message-Id: <20220124184142.962408139@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184125.121143506@linuxfoundation.org> References: <20220124184125.121143506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shengjiu Wang [ Upstream commit f331ae5fa59fbfb748317b290648fc3f1a50d932 ] Transfer the refined slots and slot_width to akcodec_get_mclk_rate() for mclk calculation, otherwise the mclk frequency does not match with the slots and slot_width for S16_LE format, because the default slot_width is 32. Fixes: aa736700f42f ("ASoC: imx-card: Add imx-card machine driver") Signed-off-by: Shengjiu Wang Link: https://lore.kernel.org/r/1641292835-19085-3-git-send-email-shengjiu.wang@nxp.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/fsl/imx-card.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/fsl/imx-card.c b/sound/soc/fsl/imx-card.c index 96ac1e465fade..84a8dcdee9316 100644 --- a/sound/soc/fsl/imx-card.c +++ b/sound/soc/fsl/imx-card.c @@ -247,13 +247,14 @@ static bool codec_is_akcodec(unsigned int type) } static unsigned long akcodec_get_mclk_rate(struct snd_pcm_substream *substream, - struct snd_pcm_hw_params *params) + struct snd_pcm_hw_params *params, + int slots, int slot_width) { struct snd_soc_pcm_runtime *rtd = substream->private_data; struct imx_card_data *data = snd_soc_card_get_drvdata(rtd->card); const struct imx_card_plat_data *plat_data = data->plat_data; struct dai_link_data *link_data = &data->link_data[rtd->num]; - unsigned int width = link_data->slots * link_data->slot_width; + unsigned int width = slots * slot_width; unsigned int rate = params_rate(params); int i; @@ -349,7 +350,7 @@ static int imx_aif_hw_params(struct snd_pcm_substream *substream, /* Set MCLK freq */ if (codec_is_akcodec(plat_data->type)) - mclk_freq = akcodec_get_mclk_rate(substream, params); + mclk_freq = akcodec_get_mclk_rate(substream, params, slots, slot_width); else mclk_freq = params_rate(params) * slots * slot_width; /* Use the maximum freq from DSD512 (512*44100 = 22579200) */ -- 2.34.1