Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3708663pxb; Mon, 24 Jan 2022 16:00:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJxZdxUwPPPiay7MvCnRJy7z6qHlSgij/D5tRUlrNi1Fc4VqFVgXx17j/pba86SXb3HPZDST X-Received: by 2002:a17:902:c102:b0:14b:7fc:2660 with SMTP id 2-20020a170902c10200b0014b07fc2660mr16108041pli.92.1643068694369; Mon, 24 Jan 2022 15:58:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643068694; cv=none; d=google.com; s=arc-20160816; b=tTsj/nVefU9w7wcldj6NZAFtPPuiHucJdZnBbU3cajr/b0dcUWvipKxlki8yf+t5cH nDD2if4h3Vu7YlbMgqzQLKh2iuCbMNDYt2TgCR21A1VEVGCMh9Ej/ywE71B6P+QR+CCA F1ex6a9cKNr1gNeiWXzfbDsVMNN8uRSfu74KhsvyAAKGe2MMs5T1KA9cZce9kYYSpeiZ Mvfa3zGTiWXiTBTY0StRdTqMb/6sfiETvP3ijvQOSv41s8zlySkDpjSK2H5p3C5ODLTz l7VW9bY59Rj+GRFY1yox1o5gyALMmYns4B/yBvGL0DMf9eNaaWkSNCZh3W22LG/2s4tz IjGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ILB14VZZOPlRBJXfzMYGOMwHbyVzqPnCyhNlt/oco2E=; b=W2317GeHn0xXps4EY4JkqNsw5ecQOE2QLdxpQuBQDkVm0ePlMrpa1rpl2NDo7JkHeI uZ1hCIfeKtPpjkCWvYqvnUMQKzrBOpcrJVRjaU8oe/IinZ8cGPEXkCjVR1+ZdnRcuqdW Ea2tWBnDys1ZY0yB4kZjZ4NIMmpbJXrENBxvLJvmxHU7MtoSV5QJztZcyW5W2Hqj63JB w6GNv1fKJhMcjtt01Cvzbb+lWffjeBVr5E/QSkwT8ufUorn5ZJDJEYo+oxxAft1uF6/2 pLGkglrQ4hUxb3LIYkqrfbTm+poyIPS67dn5DdayGb9rY+JrfEXRQCv5/Jg6mh+zn4dB 9wbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="XGNZLZ/G"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d8si4846072pgc.520.2022.01.24.15.58.02; Mon, 24 Jan 2022 15:58:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="XGNZLZ/G"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2366720AbiAXXxY (ORCPT + 99 others); Mon, 24 Jan 2022 18:53:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1846024AbiAXXOO (ORCPT ); Mon, 24 Jan 2022 18:14:14 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09EF6C067A77; Mon, 24 Jan 2022 13:22:12 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9D00460C60; Mon, 24 Jan 2022 21:22:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B94FC340E4; Mon, 24 Jan 2022 21:22:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643059331; bh=bk9nZDAqnO/Hmuv3stLRFANXP3OxWAyedFH4l31DiW4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XGNZLZ/G81f4cs5w0gLYW8bNZNFR0VcAmOVVE3g7djEYLE5reCwba3WE6a/nOUZJe Y0dI9bcpLJbWSZFBIzYco3L/cMipG/64nKA5gTzPywRtv4fXMOl78I6vzIP8/lIRSo orcWL7Xdrc6dSmVo4rpZmzhxQXYLdf+Qh0sqbyKQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marek Vasut , Frieder Schrempf , Lucas Stach , NXP Linux Team , Peng Fan , Shawn Guo , Sasha Levin Subject: [PATCH 5.16 0579/1039] soc: imx: gpcv2: Synchronously suspend MIX domains Date: Mon, 24 Jan 2022 19:39:28 +0100 Message-Id: <20220124184144.807597716@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184125.121143506@linuxfoundation.org> References: <20220124184125.121143506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marek Vasut [ Upstream commit f756f435f7dd823f2d4bd593ce1bf3168def1308 ] In case the following power domain sequence happens, iMX8M Mini always hangs: gpumix:on -> gpu:on -> gpu:off -> gpu:on This is likely due to another quirk of the GPC block. This situation can be prevented by always synchronously powering off both the domain and MIX domain. Make it so. This turns the aforementioned sequence into: gpumix:on -> gpu:on -> gpu:off -> gpumix:off -> gpumix:on -> gpu:on Signed-off-by: Marek Vasut Cc: Frieder Schrempf Cc: Lucas Stach Cc: NXP Linux Team Cc: Peng Fan Cc: Shawn Guo Acked-by: Lucas Stach Signed-off-by: Shawn Guo Signed-off-by: Sasha Levin --- drivers/soc/imx/gpcv2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 7b6dfa33dcb9f..8176380b02e6e 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -377,7 +377,7 @@ static int imx_pgc_power_down(struct generic_pm_domain *genpd) } } - pm_runtime_put(domain->dev); + pm_runtime_put_sync_suspend(domain->dev); return 0; -- 2.34.1