Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3730312pxb; Mon, 24 Jan 2022 16:33:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJwHjI9wpmpBxPGxj87Q0ZiFx0+xozAy+p0/QiGznDVWjYpySoWoVBMLS5aL7ZR1BZ00r7gp X-Received: by 2002:a63:204a:: with SMTP id r10mr13481414pgm.502.1643070811816; Mon, 24 Jan 2022 16:33:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643070811; cv=none; d=google.com; s=arc-20160816; b=iSkBKJ4AY9HHwnGnO8yizBKQPKYwLfbIP7g7RtwlvVkPD/GzcIL4XLxQ57XljsrXhV EenVmHFcVDboIR2Py4DzhvThHNfx/z6OOz/7bb5hsAankDD1pu3JbtPnLrLT5qudQDyB GH1OAnxtxb7MUyXcpr6Zj7+2DC22ER62/jp+T/N6rTsE7GqG9unry6/4iRFwfEP9myv9 8d3iokldzZ5NXaVXJ6IUTdu/MQAxOPL3XdZYQXwk4YzMNQ/VQMVY9NTkiMFc53HNhXFq uCSWMhLC7oUA3KFay5w4Jxx+oN7xF7lJSSZT17WGrB8HHxiRZ4mqhDptBtpy8UhkVbyy Cxjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=apFolW8cqBpvUf7Az/1zCQ+fyYitklUP4Oxv/yBewSk=; b=kpeF/9dZ+8HDnRMQRBW57mZA/Fwum1Edp8evfZvcsJ+goqA23e4CRuhneXXFQwmTnM 1a4lRcDkYc6rxdN95+D9/5qzA9z/d8bofmXQ0QcbVE2ujel73dIFY87vnV3RbppsCg6B /L4M1L0BG6idI19X1Bc0tceBkTYWfNkK747/Vn2M0ylZvlz8/a2tCNmonNSrAH3zxy01 oemHW1XeVrs/RU94i9WL4mcq8QMLz/P5wikHi9oUYZuQlU7ianR34sEzPmky3tuu3QRO fQhDjsx0EjjBa3De243zJR28INJ9WVsYuRoI1jf4RZYl1DhQjCxLrEIiSx2oFNCzaYa3 u5cg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ymbCiTfK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r16si711846pjp.80.2022.01.24.16.33.19; Mon, 24 Jan 2022 16:33:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ymbCiTfK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358813AbiAYAbC (ORCPT + 99 others); Mon, 24 Jan 2022 19:31:02 -0500 Received: from ams.source.kernel.org ([145.40.68.75]:45952 "EHLO ams.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1454224AbiAXVcD (ORCPT ); Mon, 24 Jan 2022 16:32:03 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 36E44B81257; Mon, 24 Jan 2022 21:32:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89F5AC340E4; Mon, 24 Jan 2022 21:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643059920; bh=6V+sC1g13i8VXCbalZh08XyriymrAMskwoCmd6usGJM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ymbCiTfKWaRcd/w0Sn2kxqr6VOQPok+qGeGLgqtCHDapVnVqyn5ihk6nzzh3lpfMN Rlujh0nMErbj7dYmQTBGMNskAfgNtv4CGP650sDOVimHMoxn6sFjKrS+eXfrCSssmh RLN7aIm4vSGDbv/HHZXw7yc/2y+dJNOlir7TYj7c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , AngeloGioacchino Del Regno , Vinod Koul , Sasha Levin Subject: [PATCH 5.16 0779/1039] phy: mediatek: Fix missing check in mtk_mipi_tx_probe Date: Mon, 24 Jan 2022 19:42:48 +0100 Message-Id: <20220124184151.474829701@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184125.121143506@linuxfoundation.org> References: <20220124184125.121143506@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit 399c91c3f30531593e5ff6ca7b53f47092128669 ] The of_device_get_match_data() function may return NULL. Add check to prevent potential null dereference. Signed-off-by: Miaoqian Lin Reviewed-by: AngeloGioacchino Del Regno Link: https://lore.kernel.org/r/20211224082103.7658-1-linmq006@gmail.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/phy/mediatek/phy-mtk-mipi-dsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c index 28ad9403c4414..67b005d5b9e35 100644 --- a/drivers/phy/mediatek/phy-mtk-mipi-dsi.c +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c @@ -146,6 +146,8 @@ static int mtk_mipi_tx_probe(struct platform_device *pdev) return -ENOMEM; mipi_tx->driver_data = of_device_get_match_data(dev); + if (!mipi_tx->driver_data) + return -ENODEV; mipi_tx->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(mipi_tx->regs)) -- 2.34.1