Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Nick Terrell <terrelln@fb.com>
To:     "trix@redhat.com" <trix@redhat.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lib: zstd: clean up double word in comment.
Thread-Topic: [PATCH] lib: zstd: clean up double word in comment.
Thread-Index: AQHYDgCFZGbuS3SgUE2sqPL7ZC4PyaxyoxUA
Date:   Mon, 24 Jan 2022 20:18:27 +0000
Message-ID: <BFE23560-5B80-4876-9FAA-726E0E9AADC1@fb.com>
References: <20220120132006.749016-1-trix@redhat.com>
In-Reply-To: <20220120132006.749016-1-trix@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CmHGaC5413CiPgwrK0wDG6spVdWtUGZVlUneyg0VXE6LD1xvPOQfusApnCSA?=
 =?us-ascii?Q?pv/+Hlnntab6Ier2/6UrIR7BEkGYTG+MZMaREf3ofa0/APvABVAF8N+i4L9l?=
 =?us-ascii?Q?bMBNWGt17qHQGwch+eqKkRMeW78gWdAUaX0ekRpC9ZrBb59z5DrmJbRzAQLd?=
 =?us-ascii?Q?W16pyHGpY26JKoLmwwPpPJgfREwQIFY6ZvyoVAjXtZ6MU4JvzEsvPnIT7YJY?=
 =?us-ascii?Q?PbsETLqQskS66fPF5qgecmL8YFVoDGsiaBX2gJFdl70y+YwchHHq8GhkFc0G?=
 =?us-ascii?Q?NRqKtKEaiYgXTxee7kDw1NUyT9iwcx7JtoQO3/9JOLBNkEN2jeOUm8DBUwbh?=
 =?us-ascii?Q?56YNPbLpgdjWQQEP/snltEHY5TRIMpWT0z/Hb7cMJTds0EImxPgagt82j1V0?=
 =?us-ascii?Q?FGbCH8j2kXTrMa9GGK5CKqaFC3YVjayKosljtJqIK/V3qBhjP/Mahp9enzCe?=
 =?us-ascii?Q?VatacIMwyCt1HwrsCOeqfwp0fwC0wgKq3o4+ox8Tp4L5r72cBecIbtF9j5ah?=
 =?us-ascii?Q?V5iYdhfgxxzETRZ+QDxu4PypMA5VKLUmiYFZHMjHHK1GKPC87GhF8LfH477S?=
 =?us-ascii?Q?4JWdA6TRTkNXA+kdzZysG6q+ZWyXP8WsZS7bhToWWqRR+Oh3iAE+rbidvp+3?=
 =?us-ascii?Q?W0j/lfv/M5K8A3hADSeiWgnfkf2ctdmacYqtKlqyQaOG1UoEam1UGVjgERfQ?=
 =?us-ascii?Q?fjbG4alm26F/UoGNhTlMJhhz8g+KrWNrd9AbWTAWG56K7ccgr9gDF2r+0NM8?=
 =?us-ascii?Q?rvIShXxinjZ6uP92cblI/DlT9AAwePP/jTN4bOpb0cImZzX8R5g1ml+F/Huc?=
 =?us-ascii?Q?irBkiztVSdmO6w8tfLsZcT5+uOX8eIKkeOVqqjCkjz9N2zik74pAE27JDFfz?=
 =?us-ascii?Q?uoXzMSOk5DpHF9+27gkbgtGk+veCyDqxl8ahjsBH1TOo5SYiiRkfr9RZ+Ajs?=
 =?us-ascii?Q?Ru88jIc20jP7aChlfbazs73eF2WrXjOoAB+A19mfVzAUVt3s13gC03KujfEj?=
 =?us-ascii?Q?LAa2j49Kc2U0Mb45W6QMrXto2uT7BRNxO2KLvkYSKKbjZjq/ELZ1TEDbqhMo?=
 =?us-ascii?Q?kA6aVsWiKd3vz33PP6IhWXQYdUR0CN7szgW0VekvODHa6Yf654nRnFgoKZSK?=
 =?us-ascii?Q?cvGAb51f7J5oa5gdL2X9FzbRyoWGRewIbmosc5tDMwpvXLexOY+vY4t9XG0x?=
 =?us-ascii?Q?Skvzwt9ECtOAEpdcV3RSiqk0o+Yf1PRZ7T4LoIymQBUxHv8wYv7cp/LNGHAx?=
 =?us-ascii?Q?rU1Z0cu+LFRL6iNPyvt7cUwdkasdtkd7n/teF2nq/p3ZHCWLnzjrXYImUpB0?=
 =?us-ascii?Q?yQ/hjz+VIB0IE3GdJ6saBznwpyvn3wQIbCjtlUvmOAUTSVPfaBwfFHuerpz8?=
 =?us-ascii?Q?IXFdgLp/gBHLJ0V8o6NEXrmO9cSGSWo0T8Rek3Eyzc0T+YppkqgDFVrL9WQW?=
 =?us-ascii?Q?9a9hy1oj51wLHFieY9BbtNfXOR/0+8hE15rKuA5dZQtAGoNxD8aFuIaI+pUO?=
 =?us-ascii?Q?g1XV2CPyM1GbitjMzDmfSHuKA0CtiPGu2ENuOAo0uxICMrPoI3Npfb/MgC+N?=
 =?us-ascii?Q?sOdeqwJWekx/mqZSzzs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <ADBF98114E1AA24A9E8FBE387A620597@namprd15.prod.outlook.com>
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR15MB3667.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f739f530-6ea3-4757-e03f-08d9df76ae64
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2022 20:18:27.3992
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3t45dPxGVKktBblyrT2DxVUnk2qppz+pEsC3JAhUNI4JcsPedEpziFl1TZ9nH5mV
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR1501MB1996
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: okKHJCrShdYjZuNvRnQxgIvuW8qSYh0w
X-Proofpoint-GUID: okKHJCrShdYjZuNvRnQxgIvuW8qSYh0w
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-01-24_09,2022-01-24_02,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 clxscore=1011
 mlxscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 adultscore=0
 priorityscore=1501 mlxlogscore=999 suspectscore=0 impostorscore=0
 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2201240134
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jan 20, 2022, at 5:20 AM, trix@redhat.com wrote:
> 
> From: Tom Rix <trix@redhat.com>
> 
> Remove the second 'a' and 'into'.

Thanks for the patch!

I'll merge this into my tree and get this into the 5.18 merge window.

If you are able to, can you please submit this patch as a PR upstream [0]?
Else, I will backport it before my next update. Either way I'll merge this patch.

Best,
Nick Terrell

[0] https://github.com/facebook/zstd/blob/dev/lib/zstd.h#L1396-L1407

> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> include/linux/zstd_lib.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/zstd_lib.h b/include/linux/zstd_lib.h
> index b8c7dbf98390f..6b91758b61af9 100644
> --- a/include/linux/zstd_lib.h
> +++ b/include/linux/zstd_lib.h
> @@ -1330,7 +1330,7 @@ ZSTDLIB_API size_t ZSTD_generateSequences(ZSTD_CCtx* zc, ZSTD_Sequence* outSeqs,
> 
> /*! ZSTD_mergeBlockDelimiters() :
>  * Given an array of ZSTD_Sequence, remove all sequences that represent block delimiters/last literals
> - * by merging them into into the literals of the next sequence.
> + * by merging them into the literals of the next sequence.
>  *
>  * As such, the final generated result has no explicit representation of block boundaries,
>  * and the final last literals segment is not represented in the sequences.
> @@ -1377,7 +1377,7 @@ ZSTDLIB_API size_t ZSTD_compressSequences(ZSTD_CCtx* const cctx, void* dst, size
> /*! ZSTD_writeSkippableFrame() :
>  * Generates a zstd skippable frame containing data given by src, and writes it to dst buffer.
>  *
> - * Skippable frames begin with a a 4-byte magic number. There are 16 possible choices of magic number,
> + * Skippable frames begin with a 4-byte magic number. There are 16 possible choices of magic number,
>  * ranging from ZSTD_MAGIC_SKIPPABLE_START to ZSTD_MAGIC_SKIPPABLE_START+15.
>  * As such, the parameter magicVariant controls the exact skippable frame magic number variant used, so
>  * the magic number used will be ZSTD_MAGIC_SKIPPABLE_START + magicVariant.
> -- 
> 2.26.3
>