Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3983099pxb; Tue, 25 Jan 2022 00:38:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJwbt2wOGUoq5CtV0HCn7lQtaENtGQ+GnQrxO794PxZLcK83GW+5+BnIfDkc5RFiGOrH+onl X-Received: by 2002:a17:906:ca0f:: with SMTP id jt15mr15346261ejb.424.1643099910859; Tue, 25 Jan 2022 00:38:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643099910; cv=none; d=google.com; s=arc-20160816; b=jSOzfS/TfihoQOzQ2nJw2oosF8SYBMdlmfeIPe36ePYW+o1TfjHXjgpACJie3RKLzI Jg56jf0+HxTkf/ZvdVLCndkVUiESXTz4fKBUaHCUSoHGTt7eCK0HC4mmvLJBG35Z+zKa Obr0dGOWK53XXBde64aMmZ/CNfGW66bwfMTT7njMuEh4Hpr7w3viIe3i40g153gnFr6T LawX0PipHtrTU+dt6R2tahf9FbwStCKrX5IeOax/AKYKHQhaga7+DjQnONBkLyUD0yt+ ZRW8bbpfROr1/zm++z5RnCiLEiQ2/6CSQDk+8qhdG7Qp8gt2yEX/ljjcYEyhWJ9Bm+YD X7XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/aWfYk8l+HunKR9T2cOcMG6QKRe5TVALBdWfrq3gLJY=; b=Kq8PJ9eqDHTzfwxfiyYcOdVrUoMMaYw39b3HtOdr11Sw0fNj1v+sKMXRrnsS8D0chA O+vwN1q0WeifpOjHwnFU6SRoQNA1tx9CFbW9hW0KgtAhwOXoLq5ItRLKRC498XNJqIww QmcfZR/rC+YmUpGaj0mWlZuAjRU2AsjrmLuXSdeSaHNaCNv8MLFSgWY2doH0qXdUJFgg Ji/3jYVnsTjrx+lUn6Z3WiVhZog7i/hyW7jWyqq9xSSbR4m1S3r4Q3c1Pbz88dL5bjlZ mIgCpArGbcfvIteOVfVf2x1ANR9vz1bQdnzsoB6s1cIc3/w32pKZRCdmNgweCkpcNQvj ZnNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WpmUelHv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m2si9688831edf.567.2022.01.25.00.38.06; Tue, 25 Jan 2022 00:38:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WpmUelHv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1316218AbiAYCz2 (ORCPT + 99 others); Mon, 24 Jan 2022 21:55:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S3412679AbiAYAh2 (ORCPT ); Mon, 24 Jan 2022 19:37:28 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7747EC06E02E; Mon, 24 Jan 2022 12:11:42 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 15E326131F; Mon, 24 Jan 2022 20:11:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE9BBC340E5; Mon, 24 Jan 2022 20:11:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643055101; bh=jZOafWWMuI7qC5ok5OnC/wzopcarTqkPtJd27tHyN14=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WpmUelHvCk1Mij77DhAFgp9kCQGiXkN3jewdlsW0bSXqJUcobb5+4MG6Rh/avDSoI +QZ4sPQKAROI+HW6paNkLhucRNjOB8gDJ5Kl3JInC3U7rwhpzMxkgYnRDw6rfPOzZF GkJAQnMngn6woHxF+qoiRltenSv1Lw/AV3NrdtRA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wenqing Liu , Chao Yu , Jaegeuk Kim Subject: [PATCH 5.15 009/846] f2fs: fix to do sanity check on inode type during garbage collection Date: Mon, 24 Jan 2022 19:32:06 +0100 Message-Id: <20220124184101.224220597@linuxfoundation.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124184100.867127425@linuxfoundation.org> References: <20220124184100.867127425@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chao Yu commit 9056d6489f5a41cfbb67f719d2c0ce61ead72d9f upstream. As report by Wenqing Liu in bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215231 - Overview kernel NULL pointer dereference triggered in folio_mark_dirty() when mount and operate on a crafted f2fs image - Reproduce tested on kernel 5.16-rc3, 5.15.X under root 1. mkdir mnt 2. mount -t f2fs tmp1.img mnt 3. touch tmp 4. cp tmp mnt F2FS-fs (loop0): sanity_check_inode: inode (ino=49) extent info [5942, 4294180864, 4] is incorrect, run fsck to fix F2FS-fs (loop0): f2fs_check_nid_range: out-of-range nid=31340049, run fsck to fix. BUG: kernel NULL pointer dereference, address: 0000000000000000 folio_mark_dirty+0x33/0x50 move_data_page+0x2dd/0x460 [f2fs] do_garbage_collect+0xc18/0x16a0 [f2fs] f2fs_gc+0x1d3/0xd90 [f2fs] f2fs_balance_fs+0x13a/0x570 [f2fs] f2fs_create+0x285/0x840 [f2fs] path_openat+0xe6d/0x1040 do_filp_open+0xc5/0x140 do_sys_openat2+0x23a/0x310 do_sys_open+0x57/0x80 The root cause is for special file: e.g. character, block, fifo or socket file, f2fs doesn't assign address space operations pointer array for mapping->a_ops field, so, in a fuzzed image, SSA table indicates a data block belong to special file, when f2fs tries to migrate that block, it causes NULL pointer access once move_data_page() calls a_ops->set_dirty_page(). Cc: stable@vger.kernel.org Reported-by: Wenqing Liu Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Greg Kroah-Hartman --- fs/f2fs/gc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -1454,7 +1454,8 @@ next_step: if (phase == 3) { inode = f2fs_iget(sb, dni.ino); - if (IS_ERR(inode) || is_bad_inode(inode)) + if (IS_ERR(inode) || is_bad_inode(inode) || + special_file(inode->i_mode)) continue; if (!down_write_trylock(