Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3985121pxb; Tue, 25 Jan 2022 00:41:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJxQ7nHfYsCKAIwVcA/lQvPPW+ll6wCvxcm/IIEDzS6XNNEiSdSpOnjfKHQSt3cf4ZVXQp0I X-Received: by 2002:a17:907:6e8c:: with SMTP id sh12mr7360937ejc.488.1643100119369; Tue, 25 Jan 2022 00:41:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643100119; cv=none; d=google.com; s=arc-20160816; b=O1FKXmWz5oTdFW+ABxRo6g0Napmy9vQ303c89MOZu4EVWIkvbPeFCxAB4lj5neFd0h 2ZnApGV+NIZsgeQbKtfMmrqTN5U0oHmpfHTswwT8uFfxtMFs2daormgU2lyF6w30uJrz sCTN7yf1yE3JobQ5DbbVGRorJf4TxenXXSstJCNyfuhuiBs4q2y+ILTB5PBver1Rcp2G LLK1BcG3uGOgokwDeO+TUCqRyF+q8NSILCh+plohPEjPQeyEaaGodJDaJjEUtl8NS7gD w14oppxNyoFemEarsdCdOJoox9Ra6AeWFaM9FdBSpZQXITa5LsJfmbMuWZBkOWIGeKDA KxkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=HGL+ZuBOHbR5QhIj3i8dJ+BOoFj7BWUdJb5AT3Nbmgk=; b=yRHzb36bBDnxeActryJWS0FW1jWpRnbr1JknBsNmBSlYig9LdR93IUjn7kivK0/j+Y 8RuvECR0HgFDLVtCheMr/p52c+adggMbumvQ6dPC227liBFyXkImBnPxGUqHBSCpasYq qkPx0Nr2wdcTsxFhFZXu8Mq16ap6xIzsu5IsTgngekuWTIKAQeM9sks02FmCr9CWgngQ CSdGFy7c23YRtyR95nWAGyoLLrlDs7It/627gERrsqNihYkSecB8EdJM9rxLwpGjhirr IP9jHsbXW24oiDKeel6c/ZIhmern/tvoLjXFIwVr2H8UKihah4DmXpwc8NeM5q7ATU95 ZlDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=G98934XM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u6si5070553edd.326.2022.01.25.00.41.35; Tue, 25 Jan 2022 00:41:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=G98934XM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1318779AbiAYDHG (ORCPT + 99 others); Mon, 24 Jan 2022 22:07:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1455538AbiAYCCD (ORCPT ); Mon, 24 Jan 2022 21:02:03 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64C05C0619D0; Mon, 24 Jan 2022 16:56:08 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0008960AF3; Tue, 25 Jan 2022 00:56:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5BFBAC340E4; Tue, 25 Jan 2022 00:56:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643072167; bh=HGL+ZuBOHbR5QhIj3i8dJ+BOoFj7BWUdJb5AT3Nbmgk=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=G98934XM7FvuZKrSQlupbv5mzhDZPcGmLNSpyGKYSZxmQtJnSKTtbY6YPfaj8tFAS 1r0R9d2QOtNocB1Z0Z7O5dRWt+X5inWR1jTVZXBqHatYd9RM4SlydSVXtTaATBCzmB G0+K5JxsLUw+eF0NFvBKn+tJ7OLvYgD8BPfGBWfNkJ9y+jcV9VYm8gnYEeG/5ofgId Uvkr6447UGI8cuDFB5WvupF+adnZweJxTX/atXz17zOY8Yi2O+9alFIiJmc6oN8YCq kxV6oB5nXOzw+y8B2sejSJKKq9kQCVQ137pI4h1QzcO42Fa7ZT+rdHc+F7zzALfMIY JJdCofjxz4JxQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220124052038.6242-1-miles.chen@mediatek.com> References: <20220117090030.13064-1-miles.chen@mediatek.com> <20220124052038.6242-1-miles.chen@mediatek.com> Subject: Re: [PATCH] clk: mediatek: add unregister logic to mtk_clk_simple_probe error path From: Stephen Boyd Cc: chun-jie.chen@mediatek.com, ikjn@chromium.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, mturquette@baylibre.com, weiyi.lu@mediatek.com To: Miles Chen Date: Mon, 24 Jan 2022 16:56:05 -0800 User-Agent: alot/0.10 Message-Id: <20220125005607.5BFBAC340E4@smtp.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Miles Chen (2022-01-23 21:20:38) > Hi Stephen, >=20 > > Stephen pointed out that there is no unregister logic in > > mtk_clk_simple_probe() error path [1]. > > Fix it by adding unregister logic to mtk_clk_simple_probe(). >=20 > Chen-Yu's work [1] already addresses this problem. So please ignore > this patch. Alright. Thanks.