Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3985551pxb; Tue, 25 Jan 2022 00:42:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJwmUCVN8xYwq84IOBUSLJpKEUDwDSIAsJ+skFz3AnV+hUpuFBQY3NNP3bAGQE0R39oxRDKN X-Received: by 2002:a17:902:b105:b0:14a:b4c8:2ac7 with SMTP id q5-20020a170902b10500b0014ab4c82ac7mr17529609plr.148.1643100164646; Tue, 25 Jan 2022 00:42:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643100164; cv=none; d=google.com; s=arc-20160816; b=V0+3teLfCVwfsoIy9lYLZQ334wyn2LhJfOPsM7Fpgo6PkjR0LgHQk0YD0esnsCZ/h1 La2QzqHLgP4YHnXHEB9fyRnmiUi1H0GUbODOf6D1h+P6FpdS6H2d66o9iy+SJEEqxb2Y 2EX3hYhjRFw+rww7Hu3UkIBdLm+xofTsH7XN8ETULOPcsKQc9sG5O4karIMF4Mvu0A8l sdzmYuODv6IRfW23RO2W/GRwZZcRqMsa4eOOBlTyGbj94A5RpZ2Eh8KaDPEPP3tvqJZr rEqtDeSgiJO4APLuCpUtJLbXzMDDQyqCeG0HHOpFnz+3FAj+jgjopqYrNPfTDYKMFT3c /I2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vqIncw13EOORmlT/EjoC9h1eW7p1pLa1zW6wJTH4hys=; b=HarZkTLrpWGVZNvY4jhy66nD2522uDeDlOTHEJdsHJ9GLg7s9EhRaDRwzbop4/pV0/ OC/tSI+Jx4pi9lq5WHHXhoHsBzr70d02yCCM/fNJZd3PqFiU9+DUdbzqsTSqI7tFQ5/m EIqz0QNhhwjF+ftOcmGQMP0HHHrH8c7y1zBgZWrp2DAJHUjOtSxkS/8UcOxbdbu3VoHO o1APKjkggljet1tNEUVATj5hNCcmArPUstbhpFdH6Kt4puBoHNyFPm5RsZ9zIh//uIwA 7RXGqag7ZBGRnq8RfvGk8Y0tjECOXoiTZwsQwFmRbGftzL0BQCfjeNY8MKakHgjptw7O s0Rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=LehDvF77; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q2si17832508pfj.256.2022.01.25.00.42.32; Tue, 25 Jan 2022 00:42:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=LehDvF77; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1318705AbiAYDG5 (ORCPT + 99 others); Mon, 24 Jan 2022 22:06:57 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:52124 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346056AbiAYB6d (ORCPT ); Mon, 24 Jan 2022 20:58:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=vqIncw13EOORmlT/EjoC9h1eW7p1pLa1zW6wJTH4hys=; b=LehDvF77PFOcpCL1ZlaeFDIvoy 6kdNcCdYavZY8+3gy+TB/K/Slen/OnLNJCdIHkF7MpikmyoRpea9BKbbuLu7UvV/xH51qrjZT5bPI 7A3Myt6wLQLzABqOIHDH4s9Ex/dkrmxmsX6tYe7qKv8CxnoWENvJ1DZrsmCCWydCODNk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1nCAhM-002ZLq-HM; Tue, 25 Jan 2022 02:32:40 +0100 Date: Tue, 25 Jan 2022 02:32:40 +0100 From: Andrew Lunn To: "Ismail, Mohammad Athari" Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , "Ong, Boon Leong" , "Voon, Weifeng" , "Wong, Vee Khee" , Huacai Chen , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net 2/2] net: stmmac: skip only stmmac_ptp_register when resume from suspend Message-ID: References: <20220124095951.23845-1-mohammad.athari.ismail@intel.com> <20220124095951.23845-3-mohammad.athari.ismail@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > @@ -3308,13 +3309,11 @@ static int stmmac_hw_setup(struct net_device > > *dev, bool init_ptp) ... > > The init_ptp parameter now seems unused? If so, please remove it. > > I believe you miss below diff. It is renamed to ptp_register. Ah, yes, sorry. I was looking at the context information diff gives you, which still has the old name. Andrew