Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@nvidia.com>,
        Lu Baolu <baolu.lu@linux.intel.com>
CC:     "Raj, Ashok" <ashok.raj@intel.com>,
        David Airlie <airlied@linux.ie>,
        Robin Murphy <robin.murphy@arm.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Christoph Hellwig <hch@infradead.org>,
        "Alex Williamson" <alex.williamson@redhat.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Ben Skeggs <bskeggs@redhat.com>,
        Daniel Vetter <daniel@ffwll.ch>, Will Deacon <will@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Pan, Jacob jun" <jacob.jun.pan@intel.com>
Subject: RE: [PATCH 6/7] iommu: Use right way to retrieve iommu_ops
Thread-Topic: [PATCH 6/7] iommu: Use right way to retrieve iommu_ops
Thread-Index: AQHYEPHSpa6rqOl4/k+RfGCHsL5bBqxycAsAgAB8WRA=
Date:   Tue, 25 Jan 2022 01:11:01 +0000
Message-ID: <BN9PR11MB5276232DDAFC8041D5E795DE8C5F9@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220124071103.2097118-1-baolu.lu@linux.intel.com>
 <20220124071103.2097118-7-baolu.lu@linux.intel.com>
 <20220124173650.GF966497@nvidia.com>
In-Reply-To: <20220124173650.GF966497@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eZvf0qAB0m3+WkmEdlTnYH/3K6emlpn4GbX1y9NjA6sPpUkAWR0p/m+IcV6C?=
 =?us-ascii?Q?yeJJ7vr+ZE1+qtGeydNqmLFRXkiTEGkGfh/NWpY0oNCRRGPKBVctos51KbSE?=
 =?us-ascii?Q?oT8JNwl6HgnyruHc8/SyK0gdz2yofJ0s/5/LiKvkn9+IJwasCtCu+RkoGTEj?=
 =?us-ascii?Q?xBlTo0ySr0svHFKdGFa88chifF/vS4lyvVuG2X8j53aHNZ1MUgo4/S4UO+/a?=
 =?us-ascii?Q?Z9YgoOIqHLfuk/JtJow/OdoaW0AIcXZ7vVPOOLarUlZZ/IH3btZNdyZG8Iab?=
 =?us-ascii?Q?3Klwb5LrWUV58iMZfAOTL9IKxkzWMy1MvzSqdZEC/x8e7yf2RkzgMvLzoKx+?=
 =?us-ascii?Q?PabvA+n0Hkm305THe5Xn1nv1eLYTOr8O/HaNpCkC6NP6mEckbKvXiJBbRM61?=
 =?us-ascii?Q?Jh7eNI2HGNSNdOjCvlJQnUkfeBxChnV7eehENg1Z3ztu+RbvfODnr2y8xL4X?=
 =?us-ascii?Q?/OCfIUCUBxyBmAIgiUPlLW2LZDKwlr8EXXb7sGmZhT9fyhlWP04upFFwE6ux?=
 =?us-ascii?Q?XtpoJ9ceaFNGolvmSgoBlzu3027uiWoOf5qG2Bc6aUhb1cEyuamMeosYTcvq?=
 =?us-ascii?Q?T/60AwvukovSA58R2fgQExat0LmbrwiXpD/ibz6pIvFTeX42kXcWaoEwgy3l?=
 =?us-ascii?Q?4QdVvzAEdq14aZAe42c1mcztT0XuBXYIxIZC6X9ixcotE6m2hbMptY+mRYXQ?=
 =?us-ascii?Q?I8UZn0yy38kZ80qT6wut8qLphqso1DAIG65UmbxNqBW1gK+MzpZoHjWbXC/x?=
 =?us-ascii?Q?rnNeky07YoSxTqUwb5lvK0mXO1rqrAF35EcB6btM6doy54smnuDol5sTcLAT?=
 =?us-ascii?Q?1JBrvueDzNDCjgKaaCahoOJ42ZfQHj+SQ2CwTfofkOKUwsjv4vCh6hgZrPaB?=
 =?us-ascii?Q?B8/8awhXIoWAFWv891vpgw+1X0NovuPxbxHfC89HYcxUbjvstkYWjYQ6WT8i?=
 =?us-ascii?Q?M3gi6K0jUmQf4hXIVVYJ3vyp/2fWYoPYTDbp5HDozv7m1I1ZndudVZhJN8kp?=
 =?us-ascii?Q?8YhMliElWXj3xBwf646AEN01gX9O/S20VkgHcAG0RruH1Mexxvh1a1LIPaV+?=
 =?us-ascii?Q?ZC/JK4uS7Tnc0r62Ksp5nHXEuMf9WkSedEdBVT6Vx1wLsKhxjjCDSgZJxs3U?=
 =?us-ascii?Q?qaaLinvx6aKdyZb8nFcROG/GdzITJm37CbGZS0Qv/rrGuldVFwGFWCvbxr7v?=
 =?us-ascii?Q?uRJLfvaJGf5p+bOXoJNhNNtxpCGV48T2xG3/Zf6HYtzaRc995CzEVfOZ4Uth?=
 =?us-ascii?Q?qH59nUVywp6Lh+lKCgOaGzB1PyyEk60CQWhxQTNiU6P8JUZ2WetT+smvbOlu?=
 =?us-ascii?Q?D+zTs8VUT/+2oamPI2r5MmpuNPIu0kfAcm5dhLf7cc8j//jXx20nXOpmJKOU?=
 =?us-ascii?Q?BngAFjHWE4+SU/uQGDBVbHxS1LI21ytcg4eTa3s1UXS5zJPGOjzV4I67Ssy4?=
 =?us-ascii?Q?6uexye0murKfGvNPZZlHLc9I9/bgL+Y+dNaNqav09NURMP9DW7gPgV/p1LcY?=
 =?us-ascii?Q?GSeJrO0A3b4xYIALQupGYkt9y+jUZ7XE+OCJi4BuJRTj3iAI1iC3qYCYXV4M?=
 =?us-ascii?Q?WzRCfuYmuibxO0PGgK6vk/nYNdShdpyTzmvpy7AmOPKsuiGgkdO7SP/NbasF?=
 =?us-ascii?Q?6qvskmV7Q+ZY+3+kzIntdK0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b93f7806-13a2-4ffc-af94-08d9df9f8d7f
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2022 01:11:01.4879
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Y05rF5TGtqjpafwGclvkszUYCLjJzh7lOpQlmPMCKqXJF82bpiHzPNj8yM4+WdtsL8zc/q92Z8N6XzDL0Jt+qw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1724
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe via iommu
> Sent: Tuesday, January 25, 2022 1:37 AM
> > @@ -1295,7 +1298,7 @@ int iommu_page_response(struct device *dev,
> >  			msg->pasid =3D 0;
> >  		}
> >
> > -		ret =3D domain->ops->page_response(dev, evt, msg);
> > +		ret =3D ops->page_response(dev, evt, msg);
> >  		list_del(&evt->list);
> >  		kfree(evt);
> >  		break;
>=20
> Feels weird that page_response is not connected to a domain, the fault
> originated from a domain after all. I would say this op should be
> moved to the domain and the caller should provide the a pointer to the
> domain that originated the fault.
>=20

In concept yes.=20

But currently the entire sva path is not associated with domain. This was
one mistake as we discussed in the cover letter. Before extending iommu
domain to cover CPU page tables we may have to leave it in iommu_ops=20
given this series is just for cleanup...

Thanks
Kevin