Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3991943pxb; Tue, 25 Jan 2022 00:52:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJy5DAZFtM2MZTpGjgygvwBoY/sYz8HNJKE6g9VYtX/nS1fa510RXNSWg6miR7HNK5vZEwHC X-Received: by 2002:a17:903:2449:b0:14b:6619:31f5 with SMTP id l9-20020a170903244900b0014b661931f5mr4587061pls.147.1643100768921; Tue, 25 Jan 2022 00:52:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643100768; cv=none; d=google.com; s=arc-20160816; b=CeAetQex6qoHtJBIOUdiPsIq5jyVvSqpcx9uC8x2l6EzTwotLUPK9H1prnrymg67rd EmqJUDsAC726Mmi/avMUwBfAgYJbuldn/0MIlMcTyfMfNr4SKJtblNMn3RR13UzKDbqM 7qTyEvZtO9KalCSSCyIPn5UT68WkCWtVm91BGfTGgLCSKpA38f3HByoTlJwFfcrFP+v1 Dv0BzP72Vf267RcRgI1VQKHsFuWXkFv0XC+QsnAkXgxkWoVzjZ5YJxfw2/iDoudrT+p7 /tYlxYJLh4SDcsTwk74hTq3stPDP8dNyJnT3wQuzeQdJ+N/kytNSOMvCOp3lbgk/iUbJ JmYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=97GwBkpfkEyDXPs9Xg2PMr7/QxnDaM9vXKCUdcNdzlQ=; b=UVuXXB9CXo8w2is45Wqy9lFqQaj92ZZeu4T+werdW13r7t9T4EmfP/8tQERrI2Do1h 62qd9pg8+nVdwLsNYGlXva9U30c2umjI6i5seRNVtRydwAncuv2ESKygHxtckN48pyty xWpEO20V7VblibeJWmEdjdSOxsuNmuzPDZIbw7ls0K+Nr/rnDyP8OhfEFicV5UjNgJpF SH/BDxm5xpOiB54T76SrTpNsu7awV8UcNSEyhiKgtpPWBtzDHl774drwnY+6Pv3T/R8m p4bGI/PSRa6Go4/m5gV+4qFJ8vXxlChTno9qwGP+RCIV+MbWxjnZ4QUyMVOeMYmxRjJL 2Sdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@philpotter-co-uk.20210112.gappssmtp.com header.s=20210112 header.b="cSB/z8nP"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n193si12911060pfd.121.2022.01.25.00.52.36; Tue, 25 Jan 2022 00:52:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@philpotter-co-uk.20210112.gappssmtp.com header.s=20210112 header.b="cSB/z8nP"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S254886AbiAYErC (ORCPT + 99 others); Mon, 24 Jan 2022 23:47:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S246822AbiAYDsv (ORCPT ); Mon, 24 Jan 2022 22:48:51 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11B71C03463D for ; Mon, 24 Jan 2022 14:59:56 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id i2so16419605wrb.12 for ; Mon, 24 Jan 2022 14:59:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=97GwBkpfkEyDXPs9Xg2PMr7/QxnDaM9vXKCUdcNdzlQ=; b=cSB/z8nP/EPc8vBGTiIFEGRg/yxgfdchoLPkyLa1lG+cSSReAzP7a/9R8Elmp7Kulm JG+LmFDnVugXtHjs+QyFPhBXjDyArt1hznXnBx/9rgQAKEcIaFJ0U6JyqutSlWo5Sxzo a0VK4/ntJX7TNCEjmd8eCgI/9ovhaFx6WCvcTTHO+coo527Q+wR8adfQL+hBEsW+GY6T BZ5pcuFO2gVBcF/DwRIyj8bmBan/7pVt6/vp/qep5yaiSmSygRYxezQ69BsGaaUJKjaM oP4IIcDFbLgvX91ujzIAzC/Cx9pqactPorRoUtlaeFUnB57NSRwqp7FsFW/MO0DwKd7c iCdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=97GwBkpfkEyDXPs9Xg2PMr7/QxnDaM9vXKCUdcNdzlQ=; b=p3cAoKOpfdpA8fNHWEbv/H9/qtnng5K2YnPASWYfQxLxQdoS0H+1F7wrioMwpvR8wb Q5AcZRxQbXbhnk7Vbe7/aeR6KgzJi99UwLfe1EX5YaMAQ0fpgzNgj9WjImUfeEC7iMss tP+nFGXgXeSLbxDoUtkbnkLQzh78nbgeKB4zhNGn3hR/lH5uf3dFrsYV3GAcJDcUQ4Rv JXlhApzjks6yT+w4k0qeDJVz6iBS5VzC7J+eV0O15ayFGPk1fSssFlxlLPYSJMUYiqW/ ozCJujMXMFw7RQv3K53XLmY66cOG0BOdFmt+VsMiZr3EBR7YsokCy5eGi2EK3irzkH0i LKZA== X-Gm-Message-State: AOAM533SuEpZP+M0cdy4D5mS8dAS+mbSvfhI+tgUHBdBeNo3qVOF9gMo 7/kRxOcIVwDTXpttD2w0PlSZ/Q== X-Received: by 2002:a5d:6d4f:: with SMTP id k15mr15999516wri.345.1643065194697; Mon, 24 Jan 2022 14:59:54 -0800 (PST) Received: from localhost.localdomain (3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.6.1.f.d.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:df16::3]) by smtp.gmail.com with ESMTPSA id b2sm7705113wrd.64.2022.01.24.14.59.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 14:59:53 -0800 (PST) From: Phillip Potter To: gregkh@linuxfoundation.org Cc: dan.carpenter@oracle.com, Larry.Finger@lwfinger.net, straube.linux@gmail.com, martin@kaiser.cx, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, paskripkin@gmail.com Subject: [PATCH 10/10] staging: r8188eu: remove GlobalDebugLevel flag Date: Mon, 24 Jan 2022 22:59:50 +0000 Message-Id: <20220124225950.784-3-phil@philpotter.co.uk> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220124225950.784-1-phil@philpotter.co.uk> References: <20220124225032.860-1-phil@philpotter.co.uk> <20220124225950.784-1-phil@philpotter.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove hal/odm_debug.c, to get rid of the GlobalDebugLevel flag, and remove the two other lines that reference GlobalDebugLevel, as the last remaining user (DBG_88E) is now gone. Also modify Makefile to no longer build hal/odm_debug.c. Signed-off-by: Phillip Potter --- drivers/staging/r8188eu/Makefile | 1 - drivers/staging/r8188eu/hal/odm_debug.c | 6 ------ drivers/staging/r8188eu/include/rtw_debug.h | 2 -- drivers/staging/r8188eu/os_dep/os_intfs.c | 1 - 4 files changed, 10 deletions(-) delete mode 100644 drivers/staging/r8188eu/hal/odm_debug.c diff --git a/drivers/staging/r8188eu/Makefile b/drivers/staging/r8188eu/Makefile index a7a486cc16dd..ecd6fe5bd94c 100644 --- a/drivers/staging/r8188eu/Makefile +++ b/drivers/staging/r8188eu/Makefile @@ -10,7 +10,6 @@ r8188eu-y = \ hal/hal_intf.o \ hal/hal_com.o \ hal/odm.o \ - hal/odm_debug.o \ hal/odm_HWConfig.o \ hal/odm_RegConfig8188E.o \ hal/odm_RTL8188E.o \ diff --git a/drivers/staging/r8188eu/hal/odm_debug.c b/drivers/staging/r8188eu/hal/odm_debug.c deleted file mode 100644 index 7a134229fe39..000000000000 --- a/drivers/staging/r8188eu/hal/odm_debug.c +++ /dev/null @@ -1,6 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0 -/* Copyright(c) 2007 - 2011 Realtek Corporation. */ - -#include "../include/rtw_debug.h" - -u32 GlobalDebugLevel; diff --git a/drivers/staging/r8188eu/include/rtw_debug.h b/drivers/staging/r8188eu/include/rtw_debug.h index 959fb6bd25ca..01a7d987d6cc 100644 --- a/drivers/staging/r8188eu/include/rtw_debug.h +++ b/drivers/staging/r8188eu/include/rtw_debug.h @@ -52,6 +52,4 @@ #define DRIVER_PREFIX "R8188EU: " -extern u32 GlobalDebugLevel; - #endif /* __RTW_DEBUG_H__ */ diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c index 17249b4fb7ad..8589de487289 100644 --- a/drivers/staging/r8188eu/os_dep/os_intfs.c +++ b/drivers/staging/r8188eu/os_dep/os_intfs.c @@ -155,7 +155,6 @@ static uint loadparam(struct adapter *padapter) { struct registry_priv *registry_par = &padapter->registrypriv; - GlobalDebugLevel = rtw_debug; registry_par->chip_version = (u8)rtw_chip_version; registry_par->rfintfs = (u8)rtw_rfintfs; registry_par->lbkmode = (u8)rtw_lbkmode; -- 2.34.1