Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <6d32f7d201b8970d53f51b6c5717d472aed2987c.1642386715.git.baolin.wang@linux.alibaba.com>
 <bdc7a556-b826-8d82-91b-8664f8a655e@google.com>
In-Reply-To: <bdc7a556-b826-8d82-91b-8664f8a655e@google.com>
From:   Souptick Joarder <jrdr.linux@gmail.com>
Date:   Tue, 25 Jan 2022 08:39:10 +0530
Message-ID: <CAFqt6zbN9M5wFUzLAkH3k3Wrk1Byyyh-JTDqhb5AKca0jS5vBg@mail.gmail.com>
Subject: Re: [PATCH v2] mm/damon: Remove redundant page validation
To:     David Rientjes <rientjes@google.com>
Cc:     Baolin Wang <baolin.wang@linux.alibaba.com>, sj@kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux-MM <linux-mm@kvack.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jan 24, 2022 at 11:50 PM David Rientjes <rientjes@google.com> wrote:
>
> On Mon, 17 Jan 2022, Baolin Wang wrote:
>
> > It will never get a NULL page by pte_page() as discussed in thread [1],
> > thus remove the redundant page validation to fix below Smatch static
> > checker warning.
> >
> >     mm/damon/vaddr.c:405 damon_hugetlb_mkold()
> >     warn: 'page' can't be NULL.
> >
> > [1] https://lore.kernel.org/linux-mm/20220106091200.GA14564@kili/
> >
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> > Reviewed-by: SeongJae Park <sj@kernel.org>
>
> Acked-by: David Rientjes <rientjes@google.com>

Acked-by: Souptick Joarder <jrdr.linux@gmail.com>

>