Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3993710pxb; Tue, 25 Jan 2022 00:56:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJxAIwIMwhmEun85jmLN5zhvqgvJo4Sa1dDq4hKCvCu4ticLi9ziaAdzzQX5WJlt9ZP/WMVt X-Received: by 2002:a17:907:6089:: with SMTP id ht9mr5112331ejc.584.1643100968269; Tue, 25 Jan 2022 00:56:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643100968; cv=none; d=google.com; s=arc-20160816; b=BfjnvZTuM1ve0csbQ4xdJ11oJiva/IxFVki8Yt0Kr4MAmMyNyUTnmj/N/gRA/4CAVg 1qDhVaD1LQHHqq4RDXN85mhiS8RYxeXvE6EhTQvRIQcPZdRH0UufaTQ9OurUePLgeLs6 TsFLV1UkxzCWn9KTZ8KbnYCfYtE6AhuiwJpSEXM3brwE4HtOJBQyvrItAbfJvFwxpnfw glUnfhrk8r+/Q0LsYiGEXRwwnjgIr0S9MHRj2OH2WtdZXE0xp//cfqU4cIMoY6YasK7i nX8yxmvYhT84j/8GYFuUdQCeNd/Z3pCV0IKdNjz5wFph1RPPZPOpiM6Fqj4JE+AQsw4V yJ6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hn4alr1qgwLUbeh7Pc2bg7Lxe9jmoANUClkdYn0J8bg=; b=WRhyxuhiVLV2CKyNt0QgJXkP8MkHjOmJBLMVDYtyN9uvUHRKxAyPK+fjsBdaDfXqIW OaG/EC+oC6WurgJukjiyaeVVocIBQVLIN1d8anJ5coZXU5R8E+R8zMTcgXpO1DH0Bp9S eMnPOdDKAnXQyGgB5KipRXgCb+JW7/rSIQWuYYyU+WIWriBqhFeY4CAqJ/MIU/tgmrBF DaYkzocg5KjLeafBgrylB5DSZhQ3f/vmu5MFqnR4nxyVsR7/7M+B31r8v9y3Kvb+vZrT adn4JlVyw9K0Hrs1tMqa6dNKq/6s8plJtOU/WexzquOA6rP3I4/HyflsVA9gSx4x6OK8 G5JA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2021-07-09 header.b=dXp4NYEw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n11si10279034edx.609.2022.01.25.00.55.43; Tue, 25 Jan 2022 00:56:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2021-07-09 header.b=dXp4NYEw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235713AbiAYFoi (ORCPT + 99 others); Tue, 25 Jan 2022 00:44:38 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:51278 "EHLO mx0a-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235514AbiAYFlM (ORCPT ); Tue, 25 Jan 2022 00:41:12 -0500 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 20P1i5Yf016125; Tue, 25 Jan 2022 05:41:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2021-07-09; bh=hn4alr1qgwLUbeh7Pc2bg7Lxe9jmoANUClkdYn0J8bg=; b=dXp4NYEw5xq8WJj6h5lJ3deGWtu8eHZCSwa6X2rHPbPQupuKcyEJVKXFw61rHlvQ1lhG fiXrr54iRSmLkLseStjWswNOZkfF1/SmedfI+SWw2z0arojvNSKMV/5isdcRUHVoccIS R+7DO60TmgjVpqgQ8mNgY268h/EMGxSScf6NZh1Tf47F6j4l8VF3vaxGzxjW1HhUr7cV Ad8FAbPCdqAnkBU883PWsQxR190yO/reLL+15AvpW0uJvXjotb+mjxNwjORWoXcqaIci ww+IOm1Uy3bza/r2mh/HBPmfRJHPBAnbZmqrOI2sLnUChswd6Z5xGnTED09mLuVt6+lq Qw== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3dsxvfhw42-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jan 2022 05:41:02 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 20P5eu1i181678; Tue, 25 Jan 2022 05:41:01 GMT Received: from pps.reinject (localhost [127.0.0.1]) by userp3030.oracle.com with ESMTP id 3dr71x1sq3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jan 2022 05:41:01 +0000 Received: from userp3030.oracle.com (userp3030.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 20P5evOZ181790; Tue, 25 Jan 2022 05:41:00 GMT Received: from ca-mkp.mkp.ca.oracle.com (ca-mkp.ca.oracle.com [10.156.108.201]) by userp3030.oracle.com with ESMTP id 3dr71x1sgc-5; Tue, 25 Jan 2022 05:41:00 +0000 From: "Martin K. Petersen" To: jinpu.wang@cloud.ionos.com, Ajish.Koshy@microchip.com, damien.lemoal@opensource.wdc.com, jejb@linux.ibm.com, John Garry Cc: "Martin K . Petersen" , Ruksar.devadi@microchip.com, ipylypiv@google.com, linux-kernel@vger.kernel.org, vishakhavc@google.com, linux-scsi@vger.kernel.org, Viswas.G@microchip.com, Vasanthalakshmi.Tharmarajan@microchip.com Subject: Re: [PATCH v2] scsi: pm8001: Fix bogus FW crash for maxcpus=1 Date: Tue, 25 Jan 2022 00:40:41 -0500 Message-Id: <164308671270.32373.5920693563555904240.b4-ty@oracle.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <1642508105-95432-1-git-send-email-john.garry@huawei.com> References: <1642508105-95432-1-git-send-email-john.garry@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: X-sdo9Btk-_sfYVUqJKYHRyOfGgdwebL X-Proofpoint-ORIG-GUID: X-sdo9Btk-_sfYVUqJKYHRyOfGgdwebL Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 18 Jan 2022 20:15:05 +0800, John Garry wrote: > According to the comment in check_fw_ready() we should not check the > IOP1_READY field in register SCRATCH_PAD_1 for 8008 or 8009 controllers. > > However we check this very field in process_oq() for processing the highest > index interrupt vector. The highest interrupt vector is checked as the FW > is programmed to signal fatal errors through this irq. > > [...] Applied to 5.17/scsi-fixes, thanks! [1/1] scsi: pm8001: Fix bogus FW crash for maxcpus=1 https://git.kernel.org/mkp/scsi/c/62afb379a0fe -- Martin K. Petersen Oracle Linux Engineering