Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp3995913pxb; Tue, 25 Jan 2022 00:58:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJx+m/ODjUoA0+u9mrOuemxD7KCLHpg7jtAVrdsS1wKd5nFdmIQrAJZSHP1W6BIibZvlQeaJ X-Received: by 2002:a17:90b:3a8b:: with SMTP id om11mr2485165pjb.184.1643101127118; Tue, 25 Jan 2022 00:58:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643101127; cv=none; d=google.com; s=arc-20160816; b=DkrcbRdKIVpdfNXW/zdzKqPBO0JiXeOTQrdkUIlrHn6fHFvWa1NLUmuN1b+nLgUbdE iSyTj4twlgDC8E0IToLY/RC/vRAH15ZjwDuASb9wl9GjlRL/BvyF8muOjGkJChlzTUs5 F24oYgPLqX8w+wzA5cySagkfsaDacmGNRoLfzVk4lFhf0oQJ2KEJUMEOOvdcmh7gWXCi AzpGF0OdmiYhJ41U7mWEeyewKRdYw59S2kKCwMNRl3QJIpp2s6HsWirnVejLj1dTFRzK zHFK55kl0ByLxEpm+dn0lXAkHF6qFEn9nctp57+JBQwvvChDUfBKFGZFyRBnFko3X8NI 7CPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=R3IcTpp6nYCa1fh4Tewpi6PxkCDIUR2z9aA4F5qiOY0=; b=bHovo6bu1RQ9zRRbbJsGEgwSlcyhyVcn3ItD+X9xRsqiX9Seh0w3ZkI4s2kZ+WHfpT ejhcdZX4ZIoIJkjlDt2YJ+tkKRQz/KOL0k4Sf1SqKC1Z5dPgvk14vB25pMoHg2Q3LkGD W+++JQpz59oYoGHHaPze4i0Q3gin56FC8JSw5R5DyET7BzU06QCUJsYZyBsTjKZOGSWF DxjVQa8QEA2vg146CMQ52Upm3TQulafo//oIvxDIhx+B25EAxFyPqTjw3LY4hR4yistp fjGOpYIoJzUrx4TNs+70FhgIQrr3o45ToJ7p0L4BvFYca0FxWOXH+pOgO+cPHc9288gm VKyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2021-07-09 header.b="xMeq6/eM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d10si8325833plc.432.2022.01.25.00.58.33; Tue, 25 Jan 2022 00:58:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2021-07-09 header.b="xMeq6/eM"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240329AbiAYFwv (ORCPT + 99 others); Tue, 25 Jan 2022 00:52:51 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:59868 "EHLO mx0a-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235546AbiAYFlZ (ORCPT ); Tue, 25 Jan 2022 00:41:25 -0500 Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 20P1lZGM016164; Tue, 25 Jan 2022 05:41:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2021-07-09; bh=R3IcTpp6nYCa1fh4Tewpi6PxkCDIUR2z9aA4F5qiOY0=; b=xMeq6/eMuOpUcfADITUtAHkuVanaChbmmiGonBmLCtLB8X8LCWxO2FT7jZ8wFBMYjl0m XUXC/VwHiwODR9MrvIYpa11NTBvOjPBzTBTGBvoB2h0iwxEgp1L2E4wOGCIEJmBa6M5h 2hw6uLxRHG48bX3TuGoTOQixZRcY6HHMjk/pyLt3dCJRaqLAQYCslKFINyaDPmqJu48W 7JmJS4B4ydhnXnBMJcjadP2iLnXY5+WCbKgWp3ETT0rEoITUPhI6px9mXBbUnHoP9OLj MCozWKGTwyDjvrbo2LIwFgpR0A/DZrIxKG8pR6jHa0GmRytKx0jPCJNqSlS6Ot6bW9AA mQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3dsxvfhw4c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jan 2022 05:41:07 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 20P5ex3r182063; Tue, 25 Jan 2022 05:41:05 GMT Received: from pps.reinject (localhost [127.0.0.1]) by userp3030.oracle.com with ESMTP id 3dr71x1st0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 25 Jan 2022 05:41:05 +0000 Received: from userp3030.oracle.com (userp3030.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 20P5evOh181790; Tue, 25 Jan 2022 05:41:05 GMT Received: from ca-mkp.mkp.ca.oracle.com (ca-mkp.ca.oracle.com [10.156.108.201]) by userp3030.oracle.com with ESMTP id 3dr71x1sgc-9; Tue, 25 Jan 2022 05:41:05 +0000 From: "Martin K. Petersen" To: xkernel.wang@foxmail.com, bvanassche@acm.org, jejb@linux.ibm.com Cc: "Martin K . Petersen" , linux-kernel@vger.kernel.org, avri.altman@wdc.com, linux-scsi@vger.kernel.org, alim.akhtar@samsung.com Subject: Re: [PATCH v2] scsi: ufs: ufshcd-pltfrm: check the return value of devm_kstrdup() Date: Tue, 25 Jan 2022 00:40:45 -0500 Message-Id: <164308671270.32373.13488934927194632781.b4-ty@oracle.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: UjLU95K2vd0wms_fHjdFGKGQxlBdDO1p X-Proofpoint-ORIG-GUID: UjLU95K2vd0wms_fHjdFGKGQxlBdDO1p Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 16 Jan 2022 11:06:49 +0800, xkernel.wang@foxmail.com wrote: > From: Xiaoke Wang > > devm_kstrdup() returns pointer to allocated string on success, > NULL on failure. So it is better to check the return value of it. > > Applied to 5.17/scsi-fixes, thanks! [1/1] scsi: ufs: ufshcd-pltfrm: check the return value of devm_kstrdup() https://git.kernel.org/mkp/scsi/c/a65b32748f45 -- Martin K. Petersen Oracle Linux Engineering