Date: Wed, 7 Feb 2007 00:51:02 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Daniel Walker <dwalker@mvista.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Andrew Morton <akpm@osdl.org>,
       linux-kernel@vger.kernel.org
Subject: Re: 2.6.20-rc6-mm3
Message-ID: <20070206235102.GC21969@elte.hu>
References: <20070206214131.GA1176@elte.hu> <1170798879.3455.58.camel@dwalker1> <20070206220855.GB5109@elte.hu> <1170801742.3455.87.camel@dwalker1> <20070206225650.GA14853@elte.hu> <1170803070.3455.93.camel@dwalker1> <20070206231421.GA18654@elte.hu> <1170804177.3455.109.camel@dwalker1> <20070206232828.GA21969@elte.hu> <1170804903.3455.121.camel@dwalker1>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1170804903.3455.121.camel@dwalker1>
User-Agent: Mutt/1.4.2.2i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2140
Lines: 51


* Daniel Walker <dwalker@mvista.com> wrote:

> > | If we change the current "timer" entry to be listed as 
> > | "lapic-timer" and not "IO-APIC-edge" (or one of the other names) 
> > | and replace it with the count from LOC
> > 
> > this is a pretty clear sentence, i dont think i misunderstood 
> > anything about it. If i did, please point it out specifically.
> 
> Geez , man I've corrected this statement already .. [...]

i'm sorry, but where did you "correct this statement already"? You 
havent replied to your mail to correct it explicitly, and there's no 
later statement of yours that says anything near to "let me correct this 
via X" or "i was wrong here, i meant Y".

the only subsequent reference of yours seems to be:

| I'm not saying we should "fake" anything .. I'm saying list what's 
| really happening .. In a human readable way .

what you write here does not read as a 'correction', this disputes my 
characterisation, suggesting that your original point is still intact. 
How should i have known that you meant this to be a 'correction' of your 
original point, and that this (whatever it means precisely) replaces it?

if you concede a point or correct a statement then /please/ make it 
clear. There's nothing bad about being wrong or being stupid 
occasionally, it happens to all of us.

> Last and final correction. I'm saying drop the timer entry, which 
> means drop the call to request_irq() for irq0 . Add lines for 
> lapic-timer which take the place of LOC..

it's not a request_irq() but a setup_irq().

dropping the IRQ#0 line would be fatally wrong: /proc/interrupt lists 
all active interrupt lines. There can (and often is) a count in IRQ#0. 
Why should it be hidden?

furthermore, as i pointed it out earlier: what you suggest is bad for 
compatibility: removing/changing the non-count portions of the LOC or 
the IRQ#0 entry /will/ break scripts.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/