Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 Jan 2022 09:15:51 +0100
From:   Mauro Carvalho Chehab <mchehab@kernel.org>
To:     Akira Yokosawa <akiyks@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Jonathan Corbet <corbet@lwn.net>,
        Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.16 0728/1039] scripts: sphinx-pre-install: Fix ctex
 support on Debian
Message-ID: <20220125091551.6a6faaf6@coco.lan>
In-Reply-To: <ba541d48-826c-3d39-b3e1-05642fa6edd6@gmail.com>
References: <20220124184125.121143506@linuxfoundation.org>
        <20220124184149.801920838@linuxfoundation.org>
        <ba541d48-826c-3d39-b3e1-05642fa6edd6@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Em Tue, 25 Jan 2022 07:48:39 +0900
Akira Yokosawa <akiyks@gmail.com> escreveu:

> Hi Greg,
> 
> On Mon, 24 Jan 2022 19:41:57 +0100,
> Greg Kroah-Hartman wrote:
> > From: Mauro Carvalho Chehab <mchehab@kernel.org>
> > 
> > [ Upstream commit 87d6576ddf8ac25f36597bc93ca17f6628289c16 ]
> > 
> > The name of the package with ctexhook.sty is different on
> > Debian/Ubuntu.
> > 
> > Reported-by: Akira Yokosawa <akiyks@gmail.com>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
> > Tested-by: Akira Yokosawa <akiyks@gmail.com>
> > Link: https://lore.kernel.org/r/63882425609a2820fac78f5e94620abeb7ed5f6f.1641429634.git.mchehab@kernel.org
> > Signed-off-by: Jonathan Corbet <corbet@lwn.net>
> > Signed-off-by: Sasha Levin <sashal@kernel.org>  
> 
> This "Fix" is against upstream commit 7baab965896e ("scripts:
> sphinx-pre-install: add required ctex dependency") which is
> also new to v5.17-rc1.
> 
> So I don't think this is worth backporting to stable branches.

Well, either both patches should be backported or none, IMHO.
I guess I would just backport also commit 7baab965896e.

> 
>         Thanks, Akira
> 
> > ---
> >  scripts/sphinx-pre-install | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/scripts/sphinx-pre-install b/scripts/sphinx-pre-install
> > index 288e86a9d1e58..61a79ce705ccf 100755
> > --- a/scripts/sphinx-pre-install
> > +++ b/scripts/sphinx-pre-install
> > @@ -369,6 +369,9 @@ sub give_debian_hints()
> >  	);
> >  
> >  	if ($pdf) {
> > +		check_missing_file(["/usr/share/texlive/texmf-dist/tex/latex/ctex/ctexhook.sty"],
> > +				   "texlive-lang-chinese", 2);
> > +
> >  		check_missing_file(["/usr/share/fonts/truetype/dejavu/DejaVuSans.ttf"],
> >  				   "fonts-dejavu", 2);
> >    


Thanks,
Mauro