Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp4241982pxb; Tue, 25 Jan 2022 06:31:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJwP6pd80Bdfxo1dQ93RT1XDu0ZPIWLpS4/mMThr9weJqnYqUljpWw7/kbJCqneGz+zWf/ou X-Received: by 2002:a17:902:c412:b0:14b:275d:d2ea with SMTP id k18-20020a170902c41200b0014b275dd2eamr16125233plk.68.1643121093538; Tue, 25 Jan 2022 06:31:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643121093; cv=none; d=google.com; s=arc-20160816; b=Uq6GusSjORvDDneH5WS6aGiVmishwitwdggZe0JKOc9+k9JNu7mbLqZIIe++fdx763 Ps9rjLnSJsxU03V5tz0EMSXT0/+8FTT2sjqDlqM6dor8Y+YI9tNcNAAybZFSQJGeqos7 x5D4UJWczYcGdgNxoripK7SvVJHag0GyAbzZz4F5vFp3JPDyEeti8ubGr8ULREKA6y9i Lazu3ONUeeiorpMBIVgo6y5zX+qFKrVyCipQa32UIwh976TC3eQAld49PHVjA7sAABag mlxY+QspNC6gbFtGRdL6VafYcsSpztZhSIS6kYDq/pmNXb0RSFGVDXHbFXvCbLjQdSNE 8EVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=GoIG+75u1/C8Q0IQMWQkza+f14Geqz2ci3clcv5LbbA=; b=a4urFsRo3cCJ+Ht3/gVYHTegImSftRw1zlRNE1ouJ3JbF0VsxE6w/YkceN+NSGhu+a PQC9aOl6T+/mI60SvXYSFXTNyZm1/labaHD+9/X8q3xAbTwlCt11uTX4eeRNdYlKMMCM RYiV1BG4ycW+OFHOKIphNww9MLpiw5W9wb2xdi7myggbsdaEu4mHo4oT4byboOzfqy48 8MtKxfpgEBFj3S9f8nd/VYUzGtByc+A3QGMyo3Tn/eKc10MSA2PVAnCDvPWeDieF7AFc WD0gma8f9LGTcEf68M5xiA1NeKaeOZNlefrpNqBPcTpYtWMfl6POuxeOr83TYGtT04Eu uZ1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@datenfreihafen.org header.s=2021 header.b=sGVaqmb8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c17si2347887pfv.315.2022.01.25.06.31.19; Tue, 25 Jan 2022 06:31:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@datenfreihafen.org header.s=2021 header.b=sGVaqmb8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235579AbiAYJtA (ORCPT + 99 others); Tue, 25 Jan 2022 04:49:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236980AbiAYJo4 (ORCPT ); Tue, 25 Jan 2022 04:44:56 -0500 Received: from proxima.lasnet.de (proxima.lasnet.de [IPv6:2a01:4f8:121:31eb:3::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF579C06173D; Tue, 25 Jan 2022 01:44:38 -0800 (PST) Received: from [IPV6:2003:e9:d71e:a9f7:7a7b:6f31:a637:f96b] (p200300e9d71ea9f77a7b6f31a637f96b.dip0.t-ipconnect.de [IPv6:2003:e9:d71e:a9f7:7a7b:6f31:a637:f96b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: stefan@datenfreihafen.org) by proxima.lasnet.de (Postfix) with ESMTPSA id F07DEC038E; Tue, 25 Jan 2022 10:44:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=datenfreihafen.org; s=2021; t=1643103874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GoIG+75u1/C8Q0IQMWQkza+f14Geqz2ci3clcv5LbbA=; b=sGVaqmb8ajP7SMAimYbwmLeoz3qwgAKJtXKJhVBI6LVnprU3zcENtw8CSuIVtlDP12Ftcg omtJC4WBLS9wYTTYBNtwuVwIpt9p+QXLrBu2J5mSbkoUdwkk6Q2U+dEAkWJcH84zrQEyei x733CU2siv1QufCl/+nKqBu3Gb9hr+Y2jwgbd/nGY+h+cGoJ1aMrkQ/Xr04xLClVQrb7Zb TfJLM6l+udOvFgWOaiKtuRju9kT+LL2mscfBK+X4SZcr+cFkeecEEkxb8wgAwr3nuwM406 TQmICGSC57YvMB7lqOtVDQPqzsvnI2bxJ1XBFEpgEaxjDEmWG5ZeH7Hj87MfNg== Message-ID: Date: Tue, 25 Jan 2022 10:44:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 5/5] spi: make remove callback a void function Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Mark Brown Cc: =?UTF-8?Q?Marek_Beh=c3=ban?= , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Markuss Broks , Emma Anholt , David Lechner , Kamlesh Gurudasani , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Jean Delvare , Guenter Roeck , Dan Robertson , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , Marcus Folkesson , Kent Gustavsson , Rui Miguel Silva , Dmitry Torokhov , Pavel Machek , Yasunari Takiguchi , Mauro Carvalho Chehab , Charles-Antoine Couret , Antti Palosaari , Lee Jones , Support Opensource , Charles Keepax , Richard Fitzgerald , Maxime Coquelin , Alexandre Torgue , Arnd Bergmann , Greg Kroah-Hartman , Eric Piel , Ulf Hansson , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Manivannan Sadhasivam , Thomas Kopp , Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Woojung Huh , UNGLinuxDriver@microchip.com, =?UTF-8?Q?=c5=81ukasz_Stelmach?= , Alexander Aring , Harry Morris , Varka Bhadram , Xue Liu , Alan Ott , Heiner Kallweit , Russell King , Christian Lamparter , Kalle Valo , Ajay Singh , Claudiu Beznea , Solomon Peachy , Krzysztof Kozlowski , Mark Greer , Benson Leung , Hans de Goede , Mark Gross , Alessandro Zummo , Alexandre Belloni , =?UTF-8?B?SsOpcsO0bWUgUG91aWxsZXI=?= , Jiri Slaby , Felipe Balbi , Daniel Thompson , Jingoo Han , Helge Deller , James Schulman , David Rhodes , Lucas Tanure , Jaroslav Kysela , Takashi Iwai , =?UTF-8?Q?Nuno_S=c3=a1?= , Liam Girdwood , Daniel Mack , Thomas Zimmermann , Maxime Ripard , Andy Shevchenko , Stephan Gerhold , Alexandru Ardelean , Mike Looijmans , Gwendal Grignou , Cai Huoqing , Minghao Chi , Antoniu Miclaus , Julia Lawall , =?UTF-8?Q?Ronald_Tschal=c3=a4r?= , Marco Felsch , =?UTF-8?Q?Jonathan_Neusch=c3=a4fer?= , Emmanuel Gil Peyrot , Jon Hunter , Andrew Morton , Heiko Schocher , Fabio Estevam , Colin Ian King , Dan Carpenter , Tudor Ambarus , Matt Kline , Torin Cooper-Bennun , Vincent Mailhol , =?UTF-8?Q?Stefan_M=c3=a4tje?= , Frieder Schrempf , Wei Yongjun , Randy Dunlap , Nanyong Sun , Yang Shen , dingsenjie , Aditya Srivastava , Stefan Wahren , Peter Zijlstra , Michael Walle , Yang Li , Geert Uytterhoeven , wengjianfeng , Sidong Yang , Paulo Miguel Almeida , Zhang Qilong , Will Deacon , Mark Tomlinson , Davidlohr Bueso , Claudius Heine , Jiri Prchal , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-wpan@vger.kernel.org, linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, kernel@pengutronix.de References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> From: Stefan Schmidt In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 23.01.22 18:52, Uwe Kleine-König wrote: > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. > > Signed-off-by: Uwe Kleine-König > --- [...] > drivers/net/ieee802154/adf7242.c | 4 +--- > drivers/net/ieee802154/at86rf230.c | 4 +--- > drivers/net/ieee802154/ca8210.c | 6 ++---- > drivers/net/ieee802154/cc2520.c | 4 +--- > drivers/net/ieee802154/mcr20a.c | 4 +--- > drivers/net/ieee802154/mrf24j40.c | 4 +--- [...] For the ieee802154 drivers: Acked-by: Stefan Schmidt regards Stefan Schmidt