Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp4257139pxb; Tue, 25 Jan 2022 06:50:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJzCPbQH3gG+buwE/LJkLW7+zH6Ff/il942+xMh06Kba3bmJ25Z7XMGYdaj2gf3NJ+n/w7GM X-Received: by 2002:a63:6886:: with SMTP id d128mr15493235pgc.418.1643122214208; Tue, 25 Jan 2022 06:50:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643122214; cv=none; d=google.com; s=arc-20160816; b=abKe8IRshN4niH4jND25vU2fSIXGrASZ2lLegRb/sRlWUKM+Ozism0uU1WZGSbM7Fq dW2OIPmifKCt8Y4zJC6i/4YEsNbDCApN7FMIi0tjfvoN9VNusL/V00oTUL8UqAKy1vMp 1J2inWJ7EiV9Q/ZLuKuu1gRSRuMgGFGKCbHggH6TfiSwkhyup1f0duJuABFv30+pEb7V pGbEGMh6/kp//r50x3yYf+53xXAxKTxr0vmzR3henpTed+el3deOWCBqhNYbvKQO+Z06 lXscMut6LjdlU2oPhYqhllqlcZdLVs1Dr+8bXfIQ18n/N41FwfsOuKY3hYu2Jq0161ny hclQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=7EEJUDIp+Rh1/VDdmay6ivSRToFmeuh6nDW5V8o3mY0=; b=xuYk+XN0eYlSdMLP+oJKujxCEPI1dbCujx+IzEFbbwhpOCsh9zctL8+cUX7aKIEdH1 No8e5nAJL4q/GoonY9XGKEG4e4LDtBIKsjFMcki34lLqDImPQ6JNpP5pRZsfuIKkX6ZH pX89sjDNPpFP5900eRxkA8jMKF9kkOrK2OgJHmRBh1E0vVeiulXhgAXDu2vpii1LjBKq 0Fy8BzJPL3vZUxRi6Dc0s0F+TvccvgwdfFeWFHnC020jjXwfNSqgm4Vw3JG1tTQr1V+p Xm0giB2J4Bp7HxKkRBZrkBPlqhnovwwukQ4y+3Ulk6AxH8MwCh6+Y+3i+jdIpc93j4y8 dwTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XbBlcFol; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v17si17165255pga.590.2022.01.25.06.50.00; Tue, 25 Jan 2022 06:50:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XbBlcFol; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349357AbiAYKXw (ORCPT + 99 others); Tue, 25 Jan 2022 05:23:52 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:60440 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243150AbiAYKUU (ORCPT ); Tue, 25 Jan 2022 05:20:20 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B6A3361637 for ; Tue, 25 Jan 2022 10:20:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A70AC340E0; Tue, 25 Jan 2022 10:20:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643106019; bh=ExbJRYNtfVD1s5WkJJibRPzKPc9HJ2TEz1/Xye0GnXE=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=XbBlcFolcJ6CjYh6lffKWnbPXVNuKPmolwII2mPN6HFOtV+DbYrhaOxuxUHzCwQBK QVsKwUNhkAVuBSHAJsACTa5GGTBWURu+7HHedxIe4nYy2KyD4ThndS1Ssd+DzfGT18 oHN3VHIyY9u5+HnKdh8ngPTPDHky+2SsurRy3YRAQaw18DNQ6qp05ikAx9qWHxYslS x9SFRb/9fpYATYGMxkvIEOMoJYQZ5tGpYKJXY7wcSDnb5dG9WK7JuncBzMCY133C9r ES23EZdRWJ4MXm3YZQfCKvUJJiZIPR87gD1mvsXOAhK6wLybyck9eTzPVPpbxcS39Q PHK9zlqoS1fcA== From: Mark Brown To: Jiasheng Jiang Cc: cezary.rojewski@intel.com, tiwai@suse.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, srinivas.kandagatla@linaro.org, perex@perex.cz, alsa-devel@alsa-project.org, bgoswami@codeaurora.org In-Reply-To: <20220114065713.1246619-1-jiasheng@iscas.ac.cn> References: <20220114065713.1246619-1-jiasheng@iscas.ac.cn> Subject: Re: [PATCH v2] ASoC: codecs: Check for error pointer after calling devm_regmap_init_mmio Message-Id: <164310601716.74844.9223636725378282440.b4-ty@kernel.org> Date: Tue, 25 Jan 2022 10:20:17 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 14 Jan 2022 14:57:13 +0800, Jiasheng Jiang wrote: > Since the possible failure of the devm_regmap_init_mmio(), it will > return error pointer and be assigned to the regmap. > Then the error pointer will be dereferenced. > For example rx->regmap will be used in rx_macro_mclk_enable(). > Therefore, it should be better to check it. > > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: codecs: Check for error pointer after calling devm_regmap_init_mmio commit: aa505ecccf2ae7546e0e262d574e18a9241f3005 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark