Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp4258021pxb; Tue, 25 Jan 2022 06:51:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1cq5hYzCA2+Xd+ZwG4RAtaPou27k5I0bRr5wO3mqHOt3o0Je13WR4sA0uE9iqWYwFZ3H4 X-Received: by 2002:a17:906:c441:: with SMTP id ck1mr16227019ejb.257.1643122285321; Tue, 25 Jan 2022 06:51:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643122285; cv=none; d=google.com; s=arc-20160816; b=ZuVIXM+gSEeYvZ8VSyX9lOxZAJ+8KCCR70hno70xYgljuHqmssiu48GuIL3h2sDjSO 7mP6xlaVYbvge66KV8WiKHa35BcrIgtJPpSK76PEIXbUFJDbtHhfmwqmtv7Fq171tjBV N+69R5moPs3X0kLCorHYTR9j42XGImxwa0yx5xah4mDkjAGg0lZ7qkdjS5gs6swEOTmu 3CaZu4ntqd2QBAh41j9HJOc/zGH44WG+IhOLtqr+2dNxUtqf1nSLht46j59TE4rnJnsS etASCdCqTI1l3QALRU9Dwnr7s6ISIyrnNJjsLF+FjlmFa0F3vjJP04K+lz/5mdH3vnrP HNsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=OPChGoZAsDS2oihunT841AQz9h9FzFRkSwlpq7dXTOY=; b=bA8abaYxXyCmStHJRnqpDnPpTHj34JM5IaIm7rMsRVDSre3YSwHVJ8KGd8r1u6UMjN z8qJW0FW70UjUJ9aKgKhqvVv2xt2gS2lRLsyEp+IOklyPNSksscESM8mtAQh31mT3Pw3 AsTaH8UTBiIeoi6um8xpZKVmuRftDdJbZhYHpQwvcohco9wzuLCpVO3bY6PG+YXFEGx7 kzcOUQiaa3kawtO6ao0jeuJ5a/l0srnBy6RByUGPF+9eJOjC39A03Rma+FDmpDEa//y6 wl6aQaG2hXfIIHt7zqs5xFsZuHGhez1KSXBNUWP4cGMlVQUX2OCIX41URaONJl2uKq4Y DLRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="dx/CfScU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y11si12440756edj.138.2022.01.25.06.50.58; Tue, 25 Jan 2022 06:51:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="dx/CfScU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352440AbiAYKZS (ORCPT + 99 others); Tue, 25 Jan 2022 05:25:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243610AbiAYKUo (ORCPT ); Tue, 25 Jan 2022 05:20:44 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB5B1C06175B for ; Tue, 25 Jan 2022 02:20:41 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7AE2E61614 for ; Tue, 25 Jan 2022 10:20:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B62BC340E8; Tue, 25 Jan 2022 10:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643106040; bh=PPeOvJVjKQk1sgWBgXTRE3M3X/ghG6GwBr17kd9EHAs=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=dx/CfScUZ2xfA9Ast+sVlMjDabJlKwxJVNGShS4Hgc0IGSpT5qNBm6ZqUhnQpAZJi NH2erSXALoBz7bbfLbkg+qEWYIUHQX9RRCES3p8LkA6B4aMDTvm0nz4SVY2dDKI6jq iTCNsb+6BbxmzEoLzFfzv/9Ad9ggJGLzIkpya2QNTT48/9508YL9LrppFc/Sc8iMOT f6OewycNyKOE50sDAcMHATWyLYlC3UT1UuAiFDdY6CLMtLtasVBlSWEK0K/6cbLmnT 2VUGbhU9IG32KLJ/mreOtm/s55njGS16GBCwKEUcsj1A9N+aJCGnuwOEtj1mruyQ+x BNS4Z69RrKCUw== From: Mark Brown To: Jiasheng Jiang Cc: cezary.rojewski@intel.com, tiwai@suse.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, srinivas.kandagatla@linaro.org, perex@perex.cz, alsa-devel@alsa-project.org, bgoswami@codeaurora.org In-Reply-To: <20220121171031.2826198-1-jiasheng@iscas.ac.cn> References: <20220121171031.2826198-1-jiasheng@iscas.ac.cn> Subject: Re: [PATCH v3] ASoC: codecs: Check for error pointer after calling devm_regmap_init_mmio Message-Id: <164310603890.74844.13333058824598578375.b4-ty@kernel.org> Date: Tue, 25 Jan 2022 10:20:38 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 22 Jan 2022 01:10:31 +0800, Jiasheng Jiang wrote: > Since the potential failure of the devm_regmap_init_mmio(), it will > return error pointer and be assigned to the regmap. > Then the error pointer will be dereferenced. > For example rx->regmap will be used in rx_macro_mclk_enable(). > Therefore, it should be better to check it. > > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: codecs: Check for error pointer after calling devm_regmap_init_mmio commit: aa505ecccf2ae7546e0e262d574e18a9241f3005 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark