Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp4260156pxb; Tue, 25 Jan 2022 06:54:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJyR0Tb8y2Qz6fpgIoebMWEjJjAifhYPQsgdUnxnkSVrPyObEP1dgL2KaTJXVHt0HPRbHcHH X-Received: by 2002:a17:907:7210:: with SMTP id dr16mr5383335ejc.470.1643122453819; Tue, 25 Jan 2022 06:54:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643122453; cv=none; d=google.com; s=arc-20160816; b=IRj+1ENqCU3FDqa8tGWl6gOoqcEgmxWIUYS1xM6nbq1XzoSTPdU7N6Ky3P+q36BLIw OOfzOVFtzy+Eq4NvOjX3/b0Eqzzc7m9r+aANS7vHDDiF0q8YRGZ36rsB/lZCrKbolWlj rLEfoShDNz4sH9DqHWlLjFO0Wv4Xlx9UbyjS2jgJRqeecjp2Rs5hbSYAVVv7wMir844T AGy7HzFuwCybOxV0yEoOWl0cY79gY1ADwGNle89wbbmteb3QP0rPJsRh4bdAh79AOGKf Qj3XUiSMprhY/9lz7Z1F//RHxh8UGp5KFFJxl8zgIdsmVL3qGAd9lL4+4jNeDr0K5vUn 9F4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=hH+/AAKH17u4YnKZ2stbs12r8fD4ioosKO9z88KKsxQ=; b=l0vSIX2j214GkgPg4NhsilgtsqZ8tjlIpJW+unN3XwSMOVklLaG1pOw/f643XnIzjP 5vG8dLfm7YEaW06qbL0b/icDAMh/uVDjbDedob+xOvqQMUvYSVRK40AZ7iUxr0bG2IMb CCc6xzh//B9GgGeQe9F0FRcqXeMFKBt25SBNmDpDs4gNYaukcmuAGQswHVTdu6HtRw7k c6DZRGFXnoBHo0mO937xVYPRqlhv4oi+IW9PBulS8YMgFMlpGPKremsO/MBg8xEpMb5k QiM22O0/DLtVURaZP0bEXCQkWKpCQfe8u6NZkjFMkKwHjyX8GSnPnAqg8SHcdn1fqCHG KqNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dr19si6031832ejc.359.2022.01.25.06.53.47; Tue, 25 Jan 2022 06:54:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355690AbiAYKg4 (ORCPT + 99 others); Tue, 25 Jan 2022 05:36:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245357AbiAYKeY (ORCPT ); Tue, 25 Jan 2022 05:34:24 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95094C06175D for ; Tue, 25 Jan 2022 02:34:22 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nCJ5B-0002PJ-4T; Tue, 25 Jan 2022 11:29:49 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nCJ4S-00CKAP-U5; Tue, 25 Jan 2022 11:29:04 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nCJ4R-001HhT-Dx; Tue, 25 Jan 2022 11:29:03 +0100 Date: Tue, 25 Jan 2022 11:29:03 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jonathan Cameron , Mark Brown , Greg Kroah-Hartman , Jarkko Sakkinen , Peter Huewe , Jason Gunthorpe , Benson Leung , Guenter Roeck Cc: Andrew Lunn , Gwendal Grignou , Yasunari Takiguchi , Claudius Heine , Geert Uytterhoeven , Nanyong Sun , Linus Walleij , dri-devel@lists.freedesktop.org, Jaroslav Kysela , Frieder Schrempf , Pavel Machek , Miquel Raynal , Christian Lamparter , Ajay Singh , linux-clk@vger.kernel.org, Stefan Schmidt , Sidong Yang , libertas-dev@lists.infradead.org, linux-omap@vger.kernel.org, Antti Palosaari , Jean Delvare , linux-serial@vger.kernel.org, =?utf-8?Q?=C5=81ukasz?= Stelmach , Mark Tomlinson , James Schulman , Kamlesh Gurudasani , Jingoo Han , Zhang Qilong , Randy Dunlap , linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Michael Walle , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , kernel@pengutronix.de, linux-mtd@lists.infradead.org, Andrew Morton , Vladimir Oltean , linux-wpan@vger.kernel.org, Claudiu Beznea , Alexandre Belloni , Dan Robertson , Markuss Broks , Lucas Tanure , David Airlie , linux-wireless@vger.kernel.org, David Rhodes , Thierry Reding , Solomon Peachy , Marek =?utf-8?B?QmVow7pu?= , Lars-Peter Clausen , Krzysztof Kozlowski , Emmanuel Gil Peyrot , Jiri Slaby , Bartosz Golaszewski , Tudor Ambarus , Minghao Chi , Jon Hunter , dingsenjie , Heiko Schocher , Wolfgang Grandegger , Matt Kline , Woojung Huh , Charles Keepax , Michael Hennerich , Mike Looijmans , Ronald =?utf-8?B?VHNjaGFsw6Ry?= , Daniel Thompson , Maxime Ripard , linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Hans de Goede , Stephen Boyd , Davidlohr Bueso , UNGLinuxDriver@microchip.com, linux-usb@vger.kernel.org, Maxime Coquelin , linux-integrity@vger.kernel.org, Jonathan Cameron , Heiner Kallweit , Ulf Hansson , linux-staging@lists.linux.dev, linux-iio@vger.kernel.org, Michael Turquette , alsa-devel@alsa-project.org, Nuno =?utf-8?B?U8Oh?= , netdev@vger.kernel.org, Wei Yongjun , Sam Ravnborg , =?utf-8?B?SsOpcsO0bWU=?= Pouiller , linux-rtc@vger.kernel.org, Marcus Folkesson , Florian Fainelli , Aditya Srivastava , Varka Bhadram , wengjianfeng , linux-input@vger.kernel.org, linux-media@vger.kernel.org, Arnd Bergmann , Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , Mark Greer , Mark Gross , Richard Fitzgerald , linux-fbdev@vger.kernel.org, Mauro Carvalho Chehab , Stefan =?utf-8?B?TcOkdGpl?= , linux-hwmon@vger.kernel.org, Felipe Balbi , Paulo Miguel Almeida , Support Opensource , Dmitry Torokhov , linux-mmc@vger.kernel.org, Liam Girdwood , Julia Lawall , Yang Li , Dan Carpenter , patches@opensource.cirrus.com, Kent Gustavsson , "David S. Miller" , Alexander Aring , Jiri Prchal , Vignesh Raghavendra , Emma Anholt , Peter Zijlstra , Alexandre Torgue , Alexandru Ardelean , Antoniu Miclaus , Torin Cooper-Bennun , Lee Jones , linux-leds@vger.kernel.org, Eric Piel , Stephan Gerhold , Richard Weinberger , Russell King , Thomas Kopp , Jakub Kicinski , Vivien Didelot , platform-driver-x86@vger.kernel.org, Stefan Wahren , Xue Liu , David Lechner , Will Deacon , Manivannan Sadhasivam , Kalle Valo , Rui Miguel Silva , Marc Kleine-Budde , Fabio Estevam , Andy Shevchenko , Vincent Mailhol , Alessandro Zummo , Yang Shen , Thomas Zimmermann , Takashi Iwai , Cai Huoqing , Daniel Mack , Daniel Vetter , Colin Ian King , Helge Deller , Alan Ott Subject: Re: [PATCH 5/5] spi: make remove callback a void function Message-ID: <20220125102903.werurj56umtglcue@pengutronix.de> References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> <20220125094759.000019c5@Huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="f3kckhw255f5ljnt" Content-Disposition: inline In-Reply-To: <20220125094759.000019c5@Huawei.com> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --f3kckhw255f5ljnt Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable [Dropped a few people from Cc that are not reachable (Harry Morris, Charles-Antoine Couret, Marco Felsch)] On Tue, Jan 25, 2022 at 09:47:59AM +0000, Jonathan Cameron wrote: > On Sun, 23 Jan 2022 18:52:01 +0100 > Uwe Kleine-K=F6nig wrote: >=20 > > The value returned by an spi driver's remove function is mostly ignored. > > (Only an error message is printed if the value is non-zero that the > > error is ignored.) > >=20 > > So change the prototype of the remove function to return no value. This > > way driver authors are not tempted to assume that passing an error to > > the upper layer is a good idea. All drivers are adapted accordingly. > > There is no intended change of behaviour, all callbacks were prepared to > > return 0 before. > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig >=20 > For iio drivers. >=20 > Acked-by: Jonathan Cameron >=20 > As you mention in the cover letter we'll be wanting an immutable > branch somewhere to pull into subsystem trees. >=20 > Soon is good if possible as otherwise we'll end up with a bunch of merge > conflicts getting resolved in next. Yes, I considered creating a tag to pull already when sending out this series, but I guessed delaying that a little bit to give people the opportunity to ack would be a good idea. @broonie: Do you think this change is a good idea? Would you require some more acks for the preparatory patches? I had hoped to get Acks from the corresponding maintainers, maybe they are busy and missed this series as I put them on Cc: only. I promoted them to To: in this mail. Or is it too ambitious to get this in during the next merge window? Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --f3kckhw255f5ljnt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmHv0OwACgkQwfwUeK3K 7AkwFgf/cvC/vOA1oS3kc72Sd8C1LyQHcuopONW8p32pISnzT5iekmQ30JqAKXUo gYYFlK5nfLHIm1fYZ1WRJHtupkslUM3aSSSaJ5aYxSpyV9BrfcYs6HZWs2hYlBDW YCYJmCIIr6DSDGEzoXxgZLaxgT1Tey1Dd4ibvvp/NatXvyNaV7ct0xAI9nCjbMY0 1EiaOvq8p6Kl9AnXjcIeXL6NpYehHRyZQ4A7V5CsKSUssgKRBtQz8AJrbMTC2nwB m+l2NEaLkGNdMQ+bhmqNk7lOZPDrfXvqUuU6KwGKdK5ZSMfpGdSzzoHt4yw7X44w 2CoQ9riN0BgZI5Ri36N0pdZxlEB8kA== =Ckzr -----END PGP SIGNATURE----- --f3kckhw255f5ljnt--