Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp4371064pxb; Tue, 25 Jan 2022 09:00:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJxZ1UTnZkTv3dixyy8s7lkE6wPOND0zY+evdsBj/e4KDTekwXWxm5oi9QJJarN+fasHjjrM X-Received: by 2002:a05:6402:1498:: with SMTP id e24mr15751589edv.16.1643130018033; Tue, 25 Jan 2022 09:00:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643130018; cv=none; d=google.com; s=arc-20160816; b=IZ5B/1+Y4Cnku87QX0cwqBMWPPsyqypHBJdvdw7u9l92K25LdGF372va0Z70dobTQ6 CbKCj66JMEEwv6M7zN2002yxZscZj+ODmxeQsitbRwooJWShSBefABJdk5bAvXwnhd3Z 71Ulw25JqRzu4asDRxKNY/Ufje/nh2spgJ59R+rSPmaridT9bUgc6ILdhFOMv5NbE/uM XbJ1/k8FbB4CznVJ9C3CCC9DTmT4wl/tjcRF8PRUn1joLcapif+t4nEo96s5DTK7llld 5Eo1y9/3ppTX92f0c9T2JbNCg8RFgIprefaD0W/KGv0zFWyMIhbUu+PXFYRnLIhHsf3v EIKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=UsswP4gQyv3j8hkVTue9LTC+kRnIxjaplYiqF5SxPV8=; b=YJxgFGDBJa7KKL99ZcnWrE2q6+GqdbWVOYyrJVbLRKNz0kpuAi6d7F+wSG1greQLqJ /TM3L9Z6OVzNWqLI4cTMhS0yPFB00MsQzuZR9ehqpxMAV9dMDNZdQBlX2H39FoQe+d7n iWvCG0TkQMKoA1sQUTqjM2udzlOotwQlPlv+fJaEfHQ669Nqnu7oER9vRcsqncVdw4bM AubRhbEgcesSKgye9aMJd8GGm18LG6sA91tTYZcWWYolplCHrEPV9wOj77eONoiEu5jX zdTh8EPngQJk0aN6xI5vAojfUbWWiFO32Lu8iDy9X0kyATCpmUxC7rALv0bfCranKaDJ 162A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x18si4789664edd.179.2022.01.25.08.59.52; Tue, 25 Jan 2022 09:00:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1452215AbiAYMlR (ORCPT + 99 others); Tue, 25 Jan 2022 07:41:17 -0500 Received: from foss.arm.com ([217.140.110.172]:40508 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383607AbiAYMhr (ORCPT ); Tue, 25 Jan 2022 07:37:47 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 968681FB; Tue, 25 Jan 2022 04:37:39 -0800 (PST) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7719C3F7D8; Tue, 25 Jan 2022 04:37:39 -0800 (PST) Received: by e110455-lin.cambridge.arm.com (Postfix, from userid 1000) id 3856D684477; Tue, 25 Jan 2022 12:37:38 +0000 (GMT) Date: Tue, 25 Jan 2022 12:37:38 +0000 From: Liviu Dudau To: carsten.haitzler@foss.arm.com Cc: dri-devel@lists.freedesktop.org, brian.starkey@arm.com, airlied@linux.ie, daniel@ffwll.ch, steven.price@arm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER Message-ID: References: <20220124162437.2470344-1-carsten.haitzler@foss.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220124162437.2470344-1-carsten.haitzler@foss.arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 24, 2022 at 04:24:37PM +0000, carsten.haitzler@foss.arm.com wrote: > From: Carsten Haitzler > > Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too. > > Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option") > > Signed-off-by: Carsten Haitzler Acked-by: Liviu Dudau I will add Steven's reviewed-by as well when pushing it. Best regards, Liviu > --- > drivers/gpu/drm/arm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig > index 58a242871b28..6e3f1d600541 100644 > --- a/drivers/gpu/drm/arm/Kconfig > +++ b/drivers/gpu/drm/arm/Kconfig > @@ -6,6 +6,7 @@ config DRM_HDLCD > depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST) > depends on COMMON_CLK > select DRM_KMS_HELPER > + select DRM_GEM_CMA_HELPER > help > Choose this option if you have an ARM High Definition Colour LCD > controller. > -- > 2.30.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯