Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 Jan 2022 09:41:49 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To:     John Garry <john.garry@huawei.com>, Jiri Olsa <jolsa@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
CC:     lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Michael Petlan <mpetlan@redhat.com>,
        Joe Mario <jmario@redhat.com>, Andi Kleen <ak@linux.intel.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        "liuqi (BA)" <liuqi115@huawei.com>,
        Guangbin Huang <huangguangbin2@huawei.com>,
        Zhangshaokun <zhangshaokun@hisilicon.com>,
        "irogers@google.com" <irogers@google.com>
Subject: Re: [PATCHv3 0/4] perf tools: Add support for user defined metric
User-Agent: K-9 Mail for Android
In-Reply-To: <2e2da73a-7085-b488-4764-705adbff70cc@huawei.com>
References: <20200511205307.3107775-1-jolsa@kernel.org> <2e2da73a-7085-b488-4764-705adbff70cc@huawei.com>
Message-ID: <0DF6E63D-C359-4D81-8F87-A64D30D75BCA@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On January 25, 2022 9:34:19 AM GMT-03:00, John Garry <john=2Egarry@huawei=
=2Ecom> wrote:
>On 11/05/2020 21:53, Jiri Olsa wrote:
>
>+
>
>Hi jirka,
>
>Did you a plan to continue to work? I don't think that this support was=
=20
>ever merged=2E
>
>We have a requirement to be able to tune parameters of metrics, and=20
>support here seems suitable=2E

John,=20


Have you tried to apply that series to see if it still applies?

- Arnaldo

>
>Thanks,
>John
>
>> hi,
>> Joe asked for possibility to add user defined metrics=2E Given that
>> we already have metrics support, I added --metrics-file option that
>> allows to specify custom metrics=2E
>>=20
>>    $ cat metrics
>>    # IPC
>>    mine1 =3D instructions / cycles;
>>    /* DECODED_ICACHE_UOPS% */
>>    mine2 =3D 100 * (idq=2Edsb_uops / \ (idq=2Ems_uops + idq=2Emite_uops=
 + idq=2Edsb_uops + lsd=2Euops));
>>=20
>>    $ sudo perf stat --metrics-file =2E/metrics -M mine1,mine2 --metric-=
only -a -I 1000
>>    #           time       insn per cycle                mine1          =
      mine2
>>         1=2E000536263                0=2E71                   0=2E7    =
             41=2E4
>>         2=2E002069025                0=2E31                   0=2E3    =
             14=2E1
>>         3=2E003427684                0=2E27                   0=2E3    =
             14=2E8
>>         4=2E004807132                0=2E25                   0=2E2    =
             12=2E1
>>    =2E=2E=2E
>>=20
>> v3 changes:
>>    - added doc for metrics file in perf stat man page
>>    - reporting error line number now
>>    - changed '#' style comment to C way with '//'
>>=20
>> v2 changes:
>>    - add new --metrics-file option
>>    - rebased on current perf/core expression bison/flex enhancements
>>=20
>> Also available in:
>>    git://git=2Ekernel=2Eorg/pub/scm/linux/kernel/git/jolsa/perf=2Egit
>>    perf/metric
>>=20
>> thanks,
>> jirka
>>=20
>>=20
>> ---
>> Jiri Olsa (4):
>>        perf expr: Add parsing support for multiple expressions
>>        perf expr: Allow comments in custom metric file
>>        perf stat: Add --metrics-file option
>>        perf expr: Report line number with error
>>=20
>>   tools/perf/Documentation/perf-stat=2Etxt | 77 +++++++++++++++++++++++=
++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>   tools/perf/builtin-stat=2Ec              |  7 +++++--
>>   tools/perf/tests/expr=2Ec                | 18 ++++++++++++++++++
>>   tools/perf/util/expr=2Ec                 |  6 ++++++
>>   tools/perf/util/expr=2Eh                 | 21 +++++++++++++++++++--
>>   tools/perf/util/expr=2El                 | 34 +++++++++++++++++++++++=
+++++++++++
>>   tools/perf/util/expr=2Ey                 | 21 +++++++++++++++++----
>>   tools/perf/util/metricgroup=2Ec          | 70 +++++++++++++++++++++++=
++++++++++++++++++++++++++++++++++++++++-------
>>   tools/perf/util/metricgroup=2Eh          |  3 ++-
>>   tools/perf/util/stat=2Eh                 |  1 +
>>   10 files changed, 242 insertions(+), 16 deletions(-)
>>=20
>> =2E
>>=20
>