Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org
Subject: Re: [PATCH 5/5] spi: make remove callback a void function
Date:   Tue, 25 Jan 2022 13:43:31 +0100
In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> ("Uwe
 =?utf-8?Q?Kleine-K=C3=B6nig=22's?= message of "Sun, 23 Jan 2022 18:52:01
        +0100")
Message-ID: <dleftjtuds2dfw.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de>
        <CGME20220125124340eucas1p2504c36206c5c17f63663a814fc8f7feb@eucas1p2.samsung.com>
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2022-01-23 nie 18:52>, when Uwe Kleine-K=C3=B6nig wrote:
> The value returned by an spi driver's remove function is mostly ignored.
> (Only an error message is printed if the value is non-zero that the
> error is ignored.)
>
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour, all callbacks were prepared to
> return 0 before.
>
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> ---

[...]


>  drivers/net/ethernet/asix/ax88796c_main.c             |  4 +---

[...]

>  191 files changed, 197 insertions(+), 545 deletions(-)
>

Acked-by: =C5=81ukasz Stelmach <l.stelmach@samsung.com>


[...]

> diff --git a/drivers/net/ethernet/asix/ax88796c_main.c b/drivers/net/ethe=
rnet/asix/ax88796c_main.c
> index e7a9f9863258..bf70481bb1ca 100644
> --- a/drivers/net/ethernet/asix/ax88796c_main.c
> +++ b/drivers/net/ethernet/asix/ax88796c_main.c
> @@ -1102,7 +1102,7 @@ static int ax88796c_probe(struct spi_device *spi)
>  	return ret;
>  }
>=20=20
> -static int ax88796c_remove(struct spi_device *spi)
> +static void ax88796c_remove(struct spi_device *spi)
>  {
>  	struct ax88796c_device *ax_local =3D dev_get_drvdata(&spi->dev);
>  	struct net_device *ndev =3D ax_local->ndev;
> @@ -1112,8 +1112,6 @@ static int ax88796c_remove(struct spi_device *spi)
>  	netif_info(ax_local, probe, ndev, "removing network device %s %s\n",
>  		   dev_driver_string(&spi->dev),
>  		   dev_name(&spi->dev));
> -
> -	return 0;
>  }
>=20=20
>  #ifdef CONFIG_OF

[...]


=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAmHv8HMACgkQsK4enJil
gBDZLwgAiQJmNfQTvlC3zqDkdVoOLECSq3mkDbjbEVXF6lQqJgFV1Ttj18n0lPRf
iagQVxD3rOILZy3/bK4mDM175TaaWmFvwCKS5PVt/fB6oY85XBtl/SG/qsoNJe0U
9fs0KFPAfHj/uO1aA7pUUwJuaIvQrSyLGVtxJ0MPW3yT00EK7efTZH0jvBbg9RfO
zdubRqyhLIKOOeuhhcERk6/+cWLAex3tmudHqG3+n0MrmD6m5/Yt42JPo+TcAz80
6/63/ZJAE+DHQEvX5nog5flnTGN+17sLFk7kVXRyeYNubYBfPC2uGQ0gjY0gl3a2
bapr4wAW1WYQ/DQSX1isrfZVKDto6Q==
=qN9z
-----END PGP SIGNATURE-----
--=-=-=--