Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 Jan 2022 16:07:20 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     Phillip Potter <phil@philpotter.co.uk>, gregkh@linuxfoundation.org,
        Larry.Finger@lwfinger.net, straube.linux@gmail.com,
        martin@kaiser.cx, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/10] staging: r8188eu: remove smaller sets of DBG_88E
 calls from os_dep dir
Message-ID: <20220125130720.GT1978@kadam>
References: <20220124224415.831-1-phil@philpotter.co.uk>
 <20220124224415.831-6-phil@philpotter.co.uk>
 <67ddc4d7-e19f-7c9d-a4b7-4eb555830ea1@gmail.com>
 <20220125125942.GS1978@kadam>
 <fa0a2717-aca7-a323-2e57-93a9f7b8c371@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fa0a2717-aca7-a323-2e57-93a9f7b8c371@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?r0GXBkcBjY6sl/Kk2I+/QAuUH4J+kaQ+X2ahFa2axwcXXiQqiK3HHLdazDzy?=
 =?us-ascii?Q?86fUeS8w/1FfwW0CgMKREx+sEfwCiOqMXKIvJ44k+d4XZvwNolZr6hDuC3yf?=
 =?us-ascii?Q?q70sB/glDZy7gfOmido/zfebWLYjK/qeaziRXyphKO/sns9wS4lz0ifypxnD?=
 =?us-ascii?Q?7hxWFsDDy9szPD7UaOn/xODjxFi5+mVIyPMEBt3mu+OHNJ9KYieLdX8ABJAH?=
 =?us-ascii?Q?onjBZsJH2EXraxRW/excQUp5CmqTGVSkrMHNiJi0Fuywog3U/+4g9oQ6HAay?=
 =?us-ascii?Q?eWyT8zZws8Sy7HdQgVLyz3CKfDhEQ96Bs6ZJL0b7euf3s4ljV+r3Jl18+6S2?=
 =?us-ascii?Q?QYD7QOBgK7Nn24O+xPg+wLB2eH4yATksGhQNTR9XP2dVcWKwWFL9ZbA9mEFI?=
 =?us-ascii?Q?8JagGk3ptmtHjipM8lxBAc2JY9/gLS+19W1Ku823dFTrxTi7wUYRXJF/R7Lo?=
 =?us-ascii?Q?Sp+VcdnsBxAtSoW4nV7q/McpVFvClrGBtvGO7qhkmVXQvYGLTMq6UioUQtaH?=
 =?us-ascii?Q?kILZr1MR/HMDDT6v0tAvyEbLw/6WPmmjgC+dnGL6wEZI6gs8C5LKvmEmVhU4?=
 =?us-ascii?Q?IhNDErpdehuKGq0mlPZAaBXnejr2HCklMIs90ClT2Cr40W34LulKAgVa0y7c?=
 =?us-ascii?Q?92lUg+G4O0Gc/CieJOTOiwxXR9b9qS2999icgwt0ehWpNqx6oWFh4rolAwLY?=
 =?us-ascii?Q?6c37frObRCtTc7RWma0mSfOUPMsOSpZD7wNha1SrcEYkXUbwMRzgDGCpnH3T?=
 =?us-ascii?Q?ELvxSMrt5oTRCyo1rjrYvQl55nP3H2piBUCFdvsPzEtlSYJAdmXicVoA2NsG?=
 =?us-ascii?Q?pJ8wKweoSh30v0/f37xiutgcqw8/1rAmvyKCu+XA/SdUtxkpsKnfJhcDeqt3?=
 =?us-ascii?Q?16DP47L86QzPOU8M/prQUMdmSxf3qMwZR5HARP2AfUdg9X/JskUWWaukeiYq?=
 =?us-ascii?Q?i3Psgna+GI95B4LmDRUs+iUb0HTUET5mP+lwanM4N+irXOxQFQG9Io0pnRv8?=
 =?us-ascii?Q?3oy4VtJwV2o9YgkjDD6PpgxG6zykfL+3pxZAEyOxOypEbGnzYF4QZ5kCgZtI?=
 =?us-ascii?Q?DczijIWEWu2ewMkYZrdQytUmIky5NV1UBe/IrPOXav01OYXxc925Ys5I4wRI?=
 =?us-ascii?Q?21TlETFdSxZYlmMZZ4NwSCL4AnSIy+wxRUokwDNF8ikVHCd7taESmlhCF7/N?=
 =?us-ascii?Q?9EDeaa0Lym8VgNsGz66gQ8Yc8zkqPh8ebORGflTiKSz1c0VwrP0/rNmdvc4c?=
 =?us-ascii?Q?naDSz9RfyFJ/ckw3gt295qhWFIcOEb1WkxyG0xZkOAXgdw1H4RE3AvjyvhBO?=
 =?us-ascii?Q?AbZOiFHowN+BHtLy1DpAzwqoLlYWAXKjexyl1qDlYy4JR8Da3zgJkavu5blP?=
 =?us-ascii?Q?LYfYxNIVm/+DKxBnnQFonuBRPIkd92Jc49o4vq4nL83Pfe1gR/W6yvwZj6Rn?=
 =?us-ascii?Q?lvhiCo+760mhSpBAqL8bk7Cdci8a2idUzAs7VvjpRb4DGCDfBnPl1kn04s/T?=
 =?us-ascii?Q?Bjwb2v/8IubSzwb0CM2uIfQQ+92Rk7jVwHBQnB1XI6cFP6GyImoSxLxzb0Xd?=
 =?us-ascii?Q?Utl04+QIdizFqhls5FklPmWOLGPqfideNVKcBvPjQIvaDZGMHV+FetgNi86h?=
 =?us-ascii?Q?OKKUac95bDEiNmW3pHUu1CkflM97G9HARWulgl9MA4dt3m+cWgjxnd15jAiS?=
 =?us-ascii?Q?ixv4AfsnqhvNLkZn5sIngp7OXDk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a6fddcf9-2066-4fc0-13ca-08d9e003aa31
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2022 13:07:39.9345
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6cKt2OSL8HsAEU0eyTrYyUimmCJ1TSgg/Vji49eRQF9PRryeG1kzCEgcEifFTAT8GWQ/lGVrmenB1E5uy7Si4hLNLi6Tyf1mWDhAIOEOxXk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5482
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10237 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 malwarescore=0
 spamscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=945
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2201250085
X-Proofpoint-GUID: nTItlMDXJsIjHE5aR8l0SE-9i0Wfu-0T
X-Proofpoint-ORIG-GUID: nTItlMDXJsIjHE5aR8l0SE-9i0Wfu-0T
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 25, 2022 at 04:04:48PM +0300, Pavel Skripkin wrote:
> Hi Dan,
> 
> On 1/25/22 15:59, Dan Carpenter wrote:
> > On Tue, Jan 25, 2022 at 03:48:32PM +0300, Pavel Skripkin wrote:
> > > Hi Phillip,
> > > 
> > > On 1/25/22 01:44, Phillip Potter wrote:
> > > > Remove all DBG_88E calls from the os_dep directory, other than those in
> > > > os_dep/ioctl_linux.c, as this contains almost 200 on its own so will be
> > > > done in a separate patch for ease of review. These calls do not conform
> > > > to kernel coding standards and are superfluous. Also restructure where
> > > > appropriate to remove no longer needed code left behind by removal of
> > > > these calls. This will allow the eventual removal of the DBG_88E macro
> > > > itself.
> > > > > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> > > > ---
> > > 
> > > [code snip]
> > > 
> > > > -	/* 2012-07-11 Move here to prevent the 8723AS-VAU BT auto
> > > > -	 * suspend influence */
> > > > -	if (usb_autopm_get_interface(pusb_intf) < 0)
> > > > -			DBG_88E("can't get autopm:\n");
> > > > -
> > > 
> > > Didn't you make a function change here? I didn't test and also didn't find
> > > any mentions of tests in cover letter.
> > 
> > It is obviously a bug.  Please avoid ask rhetorical questions or someone
> > will answer them.
> > 
> 
> It isn't so obvious for me. Might be Phillip knows something about
> 8723AS-VAU BT (whatever it is) issue.
> 
> I prefer not to say "it's an error", when I am not 100% sure :)

Oh, in that case, well done.  Good job on the review.  :)

regards,
dan carpenter