Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220125085206.8508-1-ceggers@arri.de> <20220125085206.8508-2-ceggers@arri.de>
In-Reply-To: <20220125085206.8508-2-ceggers@arri.de>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Tue, 25 Jan 2022 10:11:17 -0300
Message-ID: <CAOMZO5A2c1seLDHzb3HL58_cThM5LGB7n0Atywu_BhTCXAThyg@mail.gmail.com>
Subject: Re: [PATCH 1/6] clk: imx6ul: disable gpmi_io clock before changing
 parent clock
To:     Christian Eggers <ceggers@arri.de>
Cc:     Abel Vesa <abel.vesa@nxp.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-clk <linux-clk@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Stefan Riedmueller <s.riedmueller@phytec.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Christian,

On Tue, Jan 25, 2022 at 5:53 AM Christian Eggers <ceggers@arri.de> wrote:
>
> gpmi_io clock may have been enabled by the boot loader. All children of
> enfc_clk_root must be gated in order to prevent glitches during parent
> change.
>
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> ---
> drivers/clk/imx/clk-imx6ul.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c
> index 520b100bff4b..f599ae50dd9f 100644
> --- a/drivers/clk/imx/clk-imx6ul.c
> +++ b/drivers/clk/imx/clk-imx6ul.c
> @@ -514,6 +514,15 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node)
> else if (clk_on_imx6ull())
> clk_set_parent(hws[IMX6ULL_CLK_EPDC_PRE_SEL]->clk, hws[IMX6UL_CLK_PLL3_PFD2]->clk);
>
> + /*
> + * gpmi_io clock may have been enabled by the boot loader. All children of
> + * enfc_clk_root must be gated in order to prevent glitches during parent
> + * change. The task of re-enabling is left to the gpmi-nand driver.
> + */
> + if (clk_hw_is_enabled(hws[IMX6UL_CLK_GPMI_IO])) {
> + clk_prepare_enable(hws[IMX6UL_CLK_GPMI_IO]->clk);
> + clk_disable_unprepare(hws[IMX6UL_CLK_GPMI_IO]->clk);
> + }

It seems your patch series was corrupted.

Could you please try sending it via git send-mail?