Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp4527869pxb; Tue, 25 Jan 2022 12:19:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJym+p7SDpIJm1wlQSQm5QvaYZUSWTV99RvBjvNA6QgtHimU2M6UGNp116QNkEDr/AFzxJH8 X-Received: by 2002:a63:1a53:: with SMTP id a19mr7512622pgm.156.1643141982869; Tue, 25 Jan 2022 12:19:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643141982; cv=none; d=google.com; s=arc-20160816; b=PDn2zBHR4+bEh2hhexZ/hIqHFzQ/vxxwNuEkUIOKOwsNiU5ynHJesCkyxRT/WN0nfp GBHRk2CY4WEyzKvIQ0ZINi8IhO7aAfJNME+dAQywSUq9LWFMjfeG/j850dHFf9WCn9w1 OkNdvW/TmZ8eCvr3FZmhJ39mxMZvR7B67XfPrjyhR/2v4YISfSffopkfXR33e9hmKtv7 076krVKPz7ZwMrrJ5QSgcAo9c/C7AB57CaJZHQc+4hMlg+8TERHO8VOes4b5rkwLKCwK VrW+mcQy+wbry+6kskrd4TN1JHtSEs439pwU0or/VOQAnaOS1TkNZXuotcZ/JsAqXAbu 4wkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=wl6G1I8d7amrdxFUYe5VdZlTB2njtWsoXMFyPet+gSM=; b=PyupUzWR5HKR1opSR6UjmhQKMgk4PdTAZMN6rZOCrfuMkcXIAeUYwqwHGrmrP1A2BM TVgq38NGZe6/terwqOxdyYggsW+LP91+fCdN22pTSmYIhoCSWnZ75bpY17LvjbHx6WrM gaxqkdzhy8uatfKoVgJqgVCmRY4rrrrvCkS7H2h/ZLk75qqOq575h53IJbuo8k6NwcYt COuwB8dHdRLCdVJJF+7FNI2P0FlE/1H3HWSBKn3cRPE2k7fBwuZuf+wH0DZnH92HpGON uX4oj/c6BLtDvOhCNP9R29zec5UDge6Pdm7A4UeBqzn1DDe/FxdBuajctSwlATVWKUss VrHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=AGW72ryF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ob18si1390424pjb.131.2022.01.25.12.19.23; Tue, 25 Jan 2022 12:19:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=AGW72ryF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237647AbiAYOeY (ORCPT + 99 others); Tue, 25 Jan 2022 09:34:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238463AbiAYObJ (ORCPT ); Tue, 25 Jan 2022 09:31:09 -0500 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26209C061773 for ; Tue, 25 Jan 2022 06:26:44 -0800 (PST) Received: by mail-yb1-xb29.google.com with SMTP id g14so62104148ybs.8 for ; Tue, 25 Jan 2022 06:26:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wl6G1I8d7amrdxFUYe5VdZlTB2njtWsoXMFyPet+gSM=; b=AGW72ryFUV7dVhvx7fItSQe6ZZHiMtTV5Da/c6LbG0unTjI5NleXJ6OdX+dcMAo3XP Egpc2Ui/iAx/cdbFGKKIggUeC7r+FbsAeu6d9h+vTDvb25dE8nqSP7ccD+/WTQdWj0+s 9aMo3rC131UNWFHlxKUd5aZ62wkqORyZpgNvACVVaLR4Mumpf7Qm438DHuTrBqP9jpCm /Ft8pdlHTjs9Qq/e2gNrC2s7q43TXwOr/RCgSdSyWjsqC6Ezc2J/L1jjSNPDh7F1RRgB kCh2H1qKG+GhLqK22qGSxvtGlAjTFmh+zZb8yyte+M1KeTy4OO71L38j3uGr51G9usH7 sqPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wl6G1I8d7amrdxFUYe5VdZlTB2njtWsoXMFyPet+gSM=; b=wlYIwAn7U8VXPflFGqsJs538RN6yLOtUeOXZHN1VVeYl5pfa3og/z9j7PYMi+xUay2 VZ3tbaHNogbxIBUwh2t9rpw0O+NzaPw8BnPw+CEgdc+dPi4Xm6705v3/h3D0iOHKKGwo FdDD1lLQvBOcl36SHBb1yDpe9hablBcbhud6g+mQKhNhLUxV7unCTeA5qkLHxKTPBRXf GM3XVF5pc2166eteP6KIhWJHO+c8/7SgW4nlHrex0neCP/qY3YZVA4WLg0Mv/5iNyx8F sfwtTNo6Sazr/13skD8tP7vlVcztZOq97jLIO+renzqzqT4gKg7SwTc+kv6Q6+aYFc2D yHIQ== X-Gm-Message-State: AOAM531bduWYYvAVZHANIQPj7OGlJXbi1ul0JQtsBHZ5WTH2OTqa9KuW WHXoFmk/JXGKSYV5FvkfSA9yNxmXYhVjetWZK7NUOaAwAiXS1w== X-Received: by 2002:a25:af4b:: with SMTP id c11mr29461798ybj.49.1643120803495; Tue, 25 Jan 2022 06:26:43 -0800 (PST) MIME-Version: 1.0 References: <20220125132221.2220-1-linmiaohe@huawei.com> In-Reply-To: <20220125132221.2220-1-linmiaohe@huawei.com> From: Muchun Song Date: Tue, 25 Jan 2022 22:26:07 +0800 Message-ID: Subject: Re: [PATCH] mm/balloon_compaction: make balloon page compaction callbacks static To: Miaohe Lin Cc: Andrew Morton , "Michael S. Tsirkin" , David Hildenbrand , virtualization@lists.linux-foundation.org, Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 25, 2022 at 9:29 PM Miaohe Lin wrote: > > Since commit b1123ea6d3b3 ("mm: balloon: use general non-lru movable page > feature"), these functions are called via balloon_aops callbacks. They're > not called directly outside this file. So make them static and clean up > the relevant code. > > Signed-off-by: Miaohe Lin Reviewed-by: Muchun Song