Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 Jan 2022 15:48:31 +0100
From:   Helge Deller <deller@gmx.de>
To:     Naresh Kamboju <naresh.kamboju@linaro.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        John David Anglin <dave.anglin@bell.net>,
        Helge Deller <deller@gmx.de>,
        Andrii Nakryiko <andrii@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
        akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org,
        patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de,
        jonathanh@nvidia.com, f.fainelli@gmail.com,
        sudipm.mukherjee@gmail.com, stable@vger.kernel.org,
        Daniel =?iso-8859-15?Q?D=EDaz?= <daniel.diaz@linaro.org>,
        Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH 5.4 000/320] 5.4.174-rc1 review
Message-ID: <YfANvxrigpCy5spk@p100>
References: <20220124183953.750177707@linuxfoundation.org>
 <e2c9b01d-0500-645f-b4cc-f8dcb769996e@linaro.org>
 <CA+G9fYsvgQyUNBnySuiOrAXRrh4_ZAnqygZ0A5y7pGO5vrXAYA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+G9fYsvgQyUNBnySuiOrAXRrh4_ZAnqygZ0A5y7pGO5vrXAYA@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

* Naresh Kamboju <naresh.kamboju@linaro.org>:
> > On 1/24/22 12:39, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 5.4.174 release=
.
> > > There are 320 patches in this series, all will be posted as a respon=
se
> > > to this one.  If anyone has any issues with these being applied, ple=
ase
> > > let me know.
> > >
> > > Responses should be made by Wed, 26 Jan 2022 18:39:11 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > >       https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/pat=
ch-5.4.174-rc1.gz
> > > or in the git tree and branch at:
> > >       git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-sta=
ble-rc.git linux-5.4.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
>
> [...]
>
> This is from PA-RISC with gcc-8, gcc-9, gcc-10, gcc-11:
>
> >    /builds/linux/drivers/parisc/sba_iommu.c: In function 'sba_io_pdir_=
entry':
> >    /builds/linux/arch/parisc/include/asm/special_insns.h:11:3: error: =
expected ':' or ')' before 'ASM_EXCEPTIONTABLE_ENTRY'
> >       ASM_EXCEPTIONTABLE_ENTRY(8b, 9b) \
> >       ^~~~~~~~~~~~~~~~~~~~~~~~
>
> Bisection of the latter points to "parisc: Fix lpa and lpa_user defines"=
.
>
> commit 73c8c7ecdc141c20c9dbc8f3ec176e233942b0d9
> parisc: Fix lpa and lpa_user defines
>     [ commit db19c6f1a2a353cc8dec35b4789733a3cf6e2838 upstream ]

Naresh, thanks for noticing and bisecting!

The problem is, that in v5.4.x we are missing to include a header file
which is probably already indirectly included in the other Linux versions.

Greg, can you either drop this commit:

   commit 73c8c7ecdc141c20c9dbc8f3ec176e233942b0d9
   parisc: Fix lpa and lpa_user defines

or simply add the patch below to the commit?

Either solution which is easier for you is ok.

Thanks,
Helge


diff --git a/drivers/parisc/sba_iommu.c b/drivers/parisc/sba_iommu.c
index e410033b6df0..e72990c92add 100644
=2D-- a/drivers/parisc/sba_iommu.c
+++ b/drivers/parisc/sba_iommu.c
@@ -31,6 +31,7 @@
 #include <asm/byteorder.h>
 #include <asm/io.h>
 #include <asm/dma.h>		/* for DMA_CHUNK_SIZE */
+#include <asm/uaccess.h>

 #include <asm/hardware.h>	/* for register_parisc_driver() stuff */