Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 Jan 2022 16:53:05 +0200
From:   Mika Westerberg <mika.westerberg@linux.intel.com>
To:     Paul Menzel <pmenzel@molgen.mpg.de>
Cc:     Zha Qipeng <qipeng.zha@intel.com>, linux-kernel@vger.kernel.org,
        Andy Pont <andy.pont@sdcsystems.com>
Subject: Re: mfd/intel_pmc_bxt: `intel_pmc_get_resources()` results in page
 fault
Message-ID: <YfAO0SPAK7r4zvUE@lahna>
References: <92c233bc-d1e0-b180-efaa-27e05fbd732b@molgen.mpg.de>
 <YfAIrkJaahKpCta6@lahna>
 <2ebf7968-a324-6f98-e178-45d4d19cfb48@molgen.mpg.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2ebf7968-a324-6f98-e178-45d4d19cfb48@molgen.mpg.de>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Jan 25, 2022 at 03:40:54PM +0100, Paul Menzel wrote:
> [Cc: +Andy]
> 
> Dear Mika,
> 
> 
> Am 25.01.22 um 15:26 schrieb Mika Westerberg:
> 
> > On Tue, Jan 25, 2022 at 02:08:53PM +0100, Paul Menzel wrote:
> 
> > > `intel_pmc_get_resources()` does not set the name member in the `resource`
> > > struct `gcr_res` resulting in a page fault.
> > 
> > On which system you reproduce this,
> 
> The dump contains the name:
> 
>     Hardware name: Star Labs Lite/Lite, BIOS 8 01/24/2022
> 
> > and how? Can you also share ACPI dump from that system.
> 
> Note, I only forwarded this from a report in #coreboot. The reporter Andy is
> now in Cc.
> 
> Unrelated from that information, the Linux kernel should never run into a
> page fault and not trust system data.

Right but this looks like an issue with the system ACPI tables so at
least we should report this to the vendor too so they can fix it in
future revisions.