Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 Jan 2022 18:29:19 +0200
From:   Mika Westerberg <mika.westerberg@linux.intel.com>
To:     Andy Pont <andy.pont@sdcsystems.com>
Cc:     Paul Menzel <pmenzel@molgen.mpg.de>,
        Zha Qipeng <qipeng.zha@intel.com>, linux-kernel@vger.kernel.org
Subject: Re: mfd/intel_pmc_bxt: `intel_pmc_get_resources()` results in page
 fault
Message-ID: <YfAlXzNKPTWMl/YS@lahna>
References: <92c233bc-d1e0-b180-efaa-27e05fbd732b@molgen.mpg.de>
 <YfAIrkJaahKpCta6@lahna>
 <2ebf7968-a324-6f98-e178-45d4d19cfb48@molgen.mpg.de>
 <em755e7a07-2a6b-4b3a-9bc8-5f28857392dc@andys-imac.local>
 <YfAbBIxDvfIYrgPV@lahna>
 <em1f48e0b2-2380-45ef-a0c1-2c38a477aa5f@andys-imac.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <em1f48e0b2-2380-45ef-a0c1-2c38a477aa5f@andys-imac.local>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Jan 25, 2022 at 04:27:02PM +0000, Andy Pont wrote:
> Hello Mika,
> 
> > Thanks! The dump looks OK to me wrt. the PMC device. However, I think I
> > found the bug.
> > 
> > Can you try if the below hack fixes the issue?
> I’ll give the patch a test and let you know how I get on.
> 
> Which fields within the ACPI dump are you looking at?  When we boot the same
> hardware platform / Ubuntu image with the stock AMI BIOS then we don’t see
> the kernel oops.

Probably the driver is disabled there.

This one:

 Device (IPC1)
 {
  Name (_HID, "INT34D2")
  Name (_CID, "INT34D2")
  Name (_DDN, "Intel(R) IPC1 Controller")
  Name (RBUF, ResourceTemplate ()
  {
   Memory32Fixed (ReadWrite, 0x0, 0x2000, IBAR)
   Memory32Fixed (ReadWrite, 0x0, 0x4, MDAT)
   Memory32Fixed (ReadWrite, 0x0, 0x4, MINF)
   IO (Decode16, 0x400, 0x480,
         0x04, 0x80)
   Memory32Fixed (ReadWrite, 0x0, 0x2000, SBAR)
   Interrupt (ResourceConsumer, Level, ActiveLow, Exclusive, , , )
   {
         40
   }
  })