Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <04698792-95b8-f5b6-5b2c-375806626de6@amd.com>
Date:   Tue, 25 Jan 2022 23:19:00 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        kvm list <kvm@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Bharata B Rao <bharata@amd.com>
Subject: Re: [RFC PATCH 3/6] KVM: SVM: Implement demand page pinning
Content-Language: en-US
To:     Peter Gonda <pgonda@google.com>
References: <20220118110621.62462-1-nikunj@amd.com>
 <20220118110621.62462-4-nikunj@amd.com>
 <CAMkAt6rxeGZ3SpF9UoSW0U5XWmTNe-iSMc5jgCmOLP587J03Aw@mail.gmail.com>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <CAMkAt6rxeGZ3SpF9UoSW0U5XWmTNe-iSMc5jgCmOLP587J03Aw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2NOVmU2Y2EvUWs3NkQwVEVKVndBclArNkVRYkZrbXNZbTk3cGx6cngvUGJh?=
 =?utf-8?B?VEN2c0hnczIxNUFLa3R6ZWdLbkx2SW1Rb1hDdE5hSlFKTkw3VkgveVBSbWlv?=
 =?utf-8?B?MU5MNEhwbURpUGpFYWNOTDRHSlVhK01pVFlmSlEvOU9yYWxJTFBwSjJlbFcv?=
 =?utf-8?B?UmNiZjB2R21ObXI5SFBQOS92VldqQTdFeTZIc3NUU2E0U2VCa3JJV3R5S3Yv?=
 =?utf-8?B?WnV1cjRjZm9LenczbSs5VExyWGpMTE5yQ2ZHQVo4bGptM2QzU2o0NUFocEVs?=
 =?utf-8?B?UUpXMDgwbUxRb2VjcjlnbkhnMUI5SGlKZGg3QllLOGZjWEtnS1l0bzJZRjFZ?=
 =?utf-8?B?MnA2RXNob09jMk9nbjVRczhPYnZqdTRZOWxLQkxxamZwZTJGQm1MeWt2aXFl?=
 =?utf-8?B?OHVSZVhjdlRzSFVBdVNSZVJZaG5uVzQ0bENLQitnYjJpZmJKVUpXakQ5SGt4?=
 =?utf-8?B?L21COWM2RU5EZEMzR25hcDdBM1Riam9IRVhjWFYyTXV6d2NtZ3BmMjc4Rnh0?=
 =?utf-8?B?Kzl3ZFpaeEZieWdOcXYzL3dyNHZyaGUvME1BZ3M0ZkdTTlN6SG5DYWJZMHhC?=
 =?utf-8?B?eFNDcThoT01CWjYyZnN0L0Y3OHEwK2hVcXIzR3hJZmhGWTlkVjR5YUhlaENZ?=
 =?utf-8?B?T2o3bklKazQxTHh0em1DTkhWRlp0dmkyNWdJWkVxNnFkZUxLamE4SzdIc3Yx?=
 =?utf-8?B?c25vL2ZkM1l2bzdOcFpKYll0UzYxRE1OSnBnK0UzM09Vam1RejBsejZkYXZI?=
 =?utf-8?B?YldsSG1TMnZlUkFwbEJoSUZRcjVqam1Ha3N4Q2QxeEVHUjVSNjRkeU1oMFhM?=
 =?utf-8?B?MHREbjRGNlBGNTYxY3FoclhROUhLd0ZhZ3dGOG4rUE1FeFN0QTdXcjhkVWVI?=
 =?utf-8?B?N1lsOTdNV3Vxd3AzenJzaTA3WVBCZUxZVnhYTi9aQ0dOVG5pOGorRmp2S0c2?=
 =?utf-8?B?YndjMFVlcGJmMEVNdUx3UlMzUFVLalYraE1zcDdPR2tOU3ljNHN4NDlPZlBm?=
 =?utf-8?B?aUVpUVpMYmRLWS9kcjZDZGlLRmNHUkxYbWRyaXEvR3Zla3BqcURxVTBBT0hU?=
 =?utf-8?B?NS92QWcwQUdxeXU2eU1aYUZGSU8yaGN0TWZvR0d6YkhZcmM1TkF1V0N5RDJD?=
 =?utf-8?B?OFZUdXg0LzU5d01yZDBrRy9JMWNxRzVlaWFMQWJ2OTFYSGNVSmdhcVBuckE5?=
 =?utf-8?B?UFhPbWFwbVN6bHNkSWl5RlowYkV5R2UwUTI0UmdqY0tuTkJabXZkZDhQQjNy?=
 =?utf-8?B?dzJrK1RLNkQwNnRNSHVQTDR6R21tR1lQeFpIQTJoVEhFOHZSOVJRR2FsL2RP?=
 =?utf-8?B?VFNYZ2IydmJoKzZhbzBwcndkeFRkOEVYTW5XMXprVUpPMzRXbHZSVUJXU0ZS?=
 =?utf-8?B?ZDRMNEo1Zm1KOEhIWVU0WW1PZTFQZ3BqMTlYRVF2QzFqejUyMWkvb2dwbzE5?=
 =?utf-8?B?WE9iSU9oRzJweURlZ3FxNUQwVTZvbzBiRjVUakhSZnI3d3laNmdXNWxBVG9S?=
 =?utf-8?B?cEhEdFc4bkRWVDJxWi9tdzlWQ1U1Lzg1TlhCWnZpc0tDa3dXcnZFNkp1bHNk?=
 =?utf-8?B?U2dQdDRaN2F2Nm1ISDlQcUdpdHVrVk4zV3puTWRDYzJwN1praWFTdVdQNlg0?=
 =?utf-8?B?MEdNeUYyVE5IWE85V0lYWmRROVBvRUZiV0hVdFh1eUN1ZFNpTFZ0OEVZT0tY?=
 =?utf-8?B?NVkzb1B1Vjc4T0IwRVNWZW9IL2pYSnlOanRDdFFNTWlJWDFONlJwSG1BK09U?=
 =?utf-8?B?NlYzN3N6RnBEa1VPeXNiRzFKc3lDRVdsbTZQNXA5L2ZLbW1sbmFzSmhGeisw?=
 =?utf-8?B?UGRvQWgyMDU5M0VZekRqajM2SW9VTnZ0ZDRyOWErRzEwSkgyM09iVFJxallw?=
 =?utf-8?B?b3F1eWtBN21RL2FPZTIwai8yeEZrWVA3S0EwKy9NTG5leTdSN3gwMmVTN1F0?=
 =?utf-8?B?WUZvYkcxYjNsOVhGMXVyV2tVZ0pvWk0vcmRadHpuU0lZZDZ1QmRuQXI4cTc5?=
 =?utf-8?B?QXBzWXpadFJEc0VpczdyQ3VHSXdHZFM5ZDdjUXkvUjZkQUczQS9ONTJBRGg1?=
 =?utf-8?B?MUdEVXBaOUR1RWpsQXpqUUNScjJJdzBzOWQwUTQyL1daR2tTY2x6TnpNRGxh?=
 =?utf-8?B?MXJNNTNRSmQ0TWZMTCtMSWdtbi9uR1pBSStBOEk1eEJYNUdRU1ZUZmtobHk3?=
 =?utf-8?Q?FhE9ZF/69VvjgyWL36TiEqg=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f8dbca14-5093-44dd-b2df-08d9e02b02f8
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2470.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2022 17:49:19.1141
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PCHbL4zqKfxDL81nFSbTd7h15VWge1lPlWPctS0UByffqAm2cZTBqCGt/yLxQ2DHQfzPmvZLdGWjyL991EkPiA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB2556
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter

On 1/25/2022 10:17 PM, Peter Gonda wrote:
>> @@ -1637,8 +1627,6 @@ static void sev_migrate_from(struct kvm_sev_info *dst,
>>         src->handle = 0;
>>         src->pages_locked = 0;
>>         src->enc_context_owner = NULL;
>> -
>> -       list_cut_before(&dst->regions_list, &src->regions_list, &src->regions_list);
> I think we need to move the pinned SPTE entries into the target, and
> repin the pages in the target here. Otherwise the pages will be
> unpinned when the source is cleaned up. Have you thought about how
> this could be done?
> 
I am testing migration with pinned_list, I see that all the guest pages are 
transferred/pinned on the other side during migration. I think that there is 
assumption that all private pages needs to be moved.

QEMU: target/i386/sev.c:bool sev_is_gfn_in_unshared_region(unsigned long gfn)

Will dig more on this.

Regards
Nikunj