Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp4773284pxb; Tue, 25 Jan 2022 19:11:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJxFi+LkClaiENiocZtahokAVKmBpDwHjS4ZDPZYFOxupfHRVbpsIunwag3+rJUbv/dpYGae X-Received: by 2002:a17:902:f545:b0:14b:4d5e:f64d with SMTP id h5-20020a170902f54500b0014b4d5ef64dmr11820656plf.91.1643166714217; Tue, 25 Jan 2022 19:11:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643166714; cv=none; d=google.com; s=arc-20160816; b=jFbyhpHzI26vpi4a6NQg+4QAaf9DZmBAfh72F1Md5f7gd284Cm6iAlgVK0uiQ9zccl D5Ii0ezRamuFYAV3aZM6blRpztZyTUt8qwtiOzFrQRHmnwXCVjZQb/CKCncdHw/ffCWk g42o25qRZCW4PjHVeVcZOkVSCYEBl91BkqsVv7nRYXGHKK/snUApqRRxyQp5bQ5rrfcG 1SIHE65D0ilbv46ULcyZX6QtCehAYGeFgO1YAwmAM/WpoAlC1WyyZNvqDNiIE4VUgRG7 krHu+/4t0o8Uml0d92u/6NluhYM4QmLYGNc3lOfXXwnJwB7eTOxcpUQVe+P0l0yd+hMz HuRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=eMpQwQ2pi1pPQfZ+JCyLZgs0hA58iYXa+L/AS9xfqIE=; b=I8wIQwORdhV3b7L/v3WW0cx5UQGj3sLQWZmQxRbF7SOrT9L2zd1sRa2AWMCWSq6425 QFZ97vx/fGaWuoXr5AJ5N9d13NxYj6z/ArAky2lEBP7tSkBJbzAo5pM6D6kTsZJLIVIr FsuqDOmyZTaWHUOLb0KhF2yUYSQEK2Q2RyTxrcQc1RYldCF/RpeYiQtIgmPplFP2DoLZ hKkliF1LYnXLU2W5MP9/YPS3NpFn6znBKDfrmf1fgCdQsU18NT15fTGBb0D4VXDBTYOf Gn/BnicE0Er9nzP3Eh+G3HV+7ay2Wo6OlMdAhf6M0ZNCyuBH1ZxSgfKCcqzvstkl13HO dm8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OjUVEEPp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w2si17301308plz.170.2022.01.25.19.11.42; Tue, 25 Jan 2022 19:11:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OjUVEEPp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245337AbiAYSBt (ORCPT + 99 others); Tue, 25 Jan 2022 13:01:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357892AbiAYR7g (ORCPT ); Tue, 25 Jan 2022 12:59:36 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEF19C061751; Tue, 25 Jan 2022 09:59:35 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 679FF614F1; Tue, 25 Jan 2022 17:59:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 634A3C340E0; Tue, 25 Jan 2022 17:59:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643133574; bh=k21UjJLZbebZ1k0oSRvA1Q+UR3HKMKDNhfsWhlor4lc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OjUVEEPp1xSLAGSKZxsmxPapYBkRTBVU+1ocosZ4VvVMQ7XrHKwkcTdDqkZmyCO7r h5wXBoj8iEhWsHZGDt8H5oN7/fTbuiaAltCr8l4qYTfKoYwkMZu/jVqUOsyXcDPnk4 JUEC0Wrt/GGRizfpoQQBXaa/3kLCYpj5w4xVM/Xg30bphX9vpfnrrfM1O2irroNTvD xUuTETbr3OGfYla94YYk397f6jTYjfXS2Kh33g9w0IdwKeCuqDGf8zcj3I/YZgu91k Utl4SXvy33Wguo84gW1pWT3eFzhOFJrR3G5X63FVAy2+uuBcDAwJ9nFur56gSUsctv gyMAQA3wo0rGg== Date: Tue, 25 Jan 2022 09:59:33 -0800 From: Jakub Kicinski To: Dexuan Cui Cc: "Gustavo A. R. Silva" , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Wei Liu , "David S. Miller" , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hardening@vger.kernel.org" Subject: Re: [PATCH][next] net: mana: Use struct_size() helper in mana_gd_create_dma_region() Message-ID: <20220125095933.79ba895c@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: References: <20220124214347.GA24709@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 Jan 2022 21:47:38 +0000 Dexuan Cui wrote: > > From: Gustavo A. R. Silva > > Sent: Monday, January 24, 2022 1:44 PM > > ... > > Make use of the struct_size() helper instead of an open-coded version, > > in order to avoid any potential type mistakes or integer overflows that, > > in the worst scenario, could lead to heap overflows. > > > > Also, address the following sparse warnings: > > drivers/net/ethernet/microsoft/mana/gdma_main.c:677:24: warning: using > > sizeof on a flexible structure > > ... > > Signed-off-by: Gustavo A. R. Silva > > Reviewed-by: Dexuan Cui Thanks! Applied to net-next, 10cdc794dae8 ("net: mana: Use struct_size() helper in mana_gd_create_dma_region()")