Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 Jan 2022 19:19:46 +0100
From:   Jean Delvare <jdelvare@suse.de>
To:     Terry Bowman <Terry.Bowman@amd.com>
Cc:     linux@roeck-us.net, linux-watchdog@vger.kernel.org,
        linux-i2c@vger.kernel.org, wsa@kernel.org,
        andy.shevchenko@gmail.com, rafael.j.wysocki@intel.com,
        linux-kernel@vger.kernel.org, wim@linux-watchdog.org,
        rrichter@amd.com, thomas.lendacky@amd.com,
        Nehal-bakulchandra.Shah@amd.com, Basavaraj.Natikar@amd.com,
        Shyam-sundar.S-k@amd.com, Mario.Limonciello@amd.com
Subject: Re: [PATCH v3 2/4] Watchdog: sp5100_tco: Refactor MMIO base address
 initialization
Message-ID: <20220125191946.4213cbee@endymion>
In-Reply-To: <717b02cc-ba0c-ddd4-d15d-cc0828fbb3fd@amd.com>
References: <20220118202234.410555-1-terry.bowman@amd.com>
        <20220118202234.410555-3-terry.bowman@amd.com>
        <20220125144520.17a220bc@endymion>
        <a55ca093-d8d1-6821-1cb9-18343c6f1fd0@amd.com>
        <20220125173857.1c85fddc@endymion>
        <717b02cc-ba0c-ddd4-d15d-cc0828fbb3fd@amd.com>
Organization: SUSE Linux
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 25 Jan 2022 12:02:45 -0600, Terry Bowman wrote:
> On 1/25/22 10:38 AM, Jean Delvare wrote:
> > On Tue, 25 Jan 2022 09:18:59 -0600, Terry Bowman wrote:  
> >> On 1/25/22 7:45 AM, Jean Delvare wrote:  
> >>> On Tue, 18 Jan 2022 14:22:32 -0600, Terry Bowman wrote:    
> >>>> (...)
> >>>> +	if (ret)
> >>>> +		dev_err(dev, "Failed to reserve-map MMIO (%X) and alternate MMIO (%X) regions. ret=%X",
> >>>> +			mmio_addr, alt_mmio_addr, ret);    
> > 
> > ... I think that should be a "or" rather than "and", and singular
> > "region", in this error message? I mean, the plan was never to
> > reserve-map both of them, if I understand correctly.
> >   
> 
> This dev_err() is executed when both mmio_addr and alt_mmio_addr addresses failed either 
> devm_request_mem_region() or failed devm_ioremap(). I think the following would be most accurate:
> 
> dev_err(dev, 
>         "Failed to reserve or map the MMIO (0x%X) and alternate MMIO (0x%X) regions, ret=%d",
>         mmio_addr, alt_mmio_addr, ret);  
> 
> Above is my preference but I don't have a strong opinion. Providing the address and error code 
> information in the message is most important. I will make the change as you requested. 

I agree, fine with me, no worry.

-- 
Jean Delvare
SUSE L3 Support