Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220126094035.631da5e3@canb.auug.org.au> <999b1940-3e72-be82-8acd-0634ae50cda9@amd.com>
In-Reply-To: <999b1940-3e72-be82-8acd-0634ae50cda9@amd.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Tue, 25 Jan 2022 18:01:33 -0500
Message-ID: <CADnq5_N+CiA2wja+2ArtCTSiBdmMEA6Q2VvTqz=8Evf6XFPN7g@mail.gmail.com>
Subject: Re: linux-next: Fixes tag needs some work in the amdgpu tree
To:     Luben Tuikov <luben.tuikov@amd.com>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jan 25, 2022 at 5:59 PM Luben Tuikov <luben.tuikov@amd.com> wrote:
>
> Not sure what to do with this, because in our tree, I see this:
>
> commit 824c2051039dfc
> Author: shaoyunl <shaoyun.liu@amd.com>
> Date:   Thu Jan 20 10:39:41 2022 -0500
>
>     drm/amdgpu: Disable FRU EEPROM access for SRIOV
>
>
> And this is what I used.

I typo-ed it when I fixed it up.  Properly fixed up now.

Alex

>
> Regards,
> Luben
>
>
> On 2022-01-25 17:40, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> >   69bba523d97a ("drm/amdgpu: Fix kernel compilation; style")
> >
> > Fixes tag
> >
> >   Fixes: 1b08dfb889b2c5 ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")
> >
> > has these problem(s):
> >
> >   - Subject does not match target commit subject
> >     Just use
> >       git log -1 --format='Fixes: %h ("%s")'
> >
> > Thus:
> >
> > Fixes: 1b08dfb889b2 ("drm/amdgpu: remove gart.ready flag")
> >
> > or
> >
> > Fixes: eadabcc2bc6c ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")
> >
>
> Regards,
> --
> Luben
>