Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Jonathan Corbet <corbet@lwn.net>
To:     GUO Zihua <guozihua@huawei.com>, zohar@linux.ibm.com
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        roberto.sassu@huawei.com, wangweiyang2@huawei.com,
        xiujianfeng@huawei.com, linux-integrity@vger.kernel.org,
        guozihua@huawei.com
Subject: Re: [RESEND][PATCH] Documentation: added order requirement for
 ima_hash=
In-Reply-To: <20220125090237.120357-1-guozihua@huawei.com>
References: <20220125090237.120357-1-guozihua@huawei.com>
Date:   Tue, 25 Jan 2022 17:14:45 -0700
Message-ID: <87o83zwdxm.fsf@meer.lwn.net>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

GUO Zihua <guozihua@huawei.com> writes:

> From: Guo Zihua <guozihua@huawei.com>
>
> Commandline parameter ima_hash= and ima_template= has order requirement
> for them to work correctly together. Namely ima_hash= must be
> specified after ima_template=, otherwise ima_template= will be ignored.
>
> The reason is that when handling ima_hash=, ima template would be set to
> the default value if it has not been initialized already, and that value
> cannot be changed afterwards by ima_template=.
>
> This patch adds this limitation to the documentation.
>
> Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com>
> Signed-off-by: Guo Zihua <guozihua@huawei.com>

I've applied this, but I'm wondering: where did this review take place?
I can't find it on the lists...

Thanks,

jon