Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 26 Jan 2022 01:02:16 +0000
From:   Phillip Potter <phil@philpotter.co.uk>
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     gregkh@linuxfoundation.org, dan.carpenter@oracle.com,
        Larry.Finger@lwfinger.net, straube.linux@gmail.com,
        martin@kaiser.cx, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/10] staging: r8188eu: remove DBG_88E calls from
 core/rtw_mlme_ext.c
Message-ID: <YfCdmPervlyjf0aU@equinox>
References: <20220124224415.831-1-phil@philpotter.co.uk>
 <20220124224415.831-4-phil@philpotter.co.uk>
 <f766f910-4f7c-d3b5-d7a8-4d0d9de33a66@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f766f910-4f7c-d3b5-d7a8-4d0d9de33a66@gmail.com>
Precedence: bulk

On Tue, Jan 25, 2022 at 09:31:27PM +0300, Pavel Skripkin wrote:
> Hi Phillip,
> 
> On 1/25/22 01:44, Phillip Potter wrote:
> > Remove all DBG_88E calls from core/rtw_mlme_ext.c, including the commented
> > one, as they do not conform to kernel coding standards and are
> > superfluous. Also restructure where appropriate to remove no longer needed
> > code left behind by removal of these calls. This will allow the eventual
> > removal of the DBG_88E macro itself.
> > 
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> > ---
> 
> [code snip]
> 
> >   static u8 chk_ap_is_alive(struct adapter *padapter, struct sta_info *psta)
> > @@ -7141,18 +6905,11 @@ static u8 chk_ap_is_alive(struct adapter *padapter, struct sta_info *psta)
> >   static void rtl8188e_sreset_linked_status_check(struct adapter *padapter)
> >   {
> >   	u32 rx_dma_status =  rtw_read32(padapter, REG_RXDMA_STATUS);
> > -	u8 fw_status;
> > -	if (rx_dma_status != 0x00) {
> > -		DBG_88E("%s REG_RXDMA_STATUS:0x%08x\n", __func__, rx_dma_status);
> > +	if (rx_dma_status != 0x00)
> >   		rtw_write32(padapter, REG_RXDMA_STATUS, rx_dma_status);
> > -	}
> > -	fw_status = rtw_read8(padapter, REG_FMETHR);
> > -	if (fw_status == 1)
> > -		DBG_88E("%s REG_FW_STATUS (0x%02x), Read_Efuse_Fail !!\n", __func__, fw_status);
> > -	else if (fw_status == 2)
> > -		DBG_88E("%s REG_FW_STATUS (0x%02x), Condition_No_Match !!\n", __func__, fw_status);
> > +	rtw_read8(padapter, REG_FMETHR);
> >   }
> 
> Unused read. Can be dropped
> 
> 
> 
> With regards,
> Pavel Skripkin

Thanks - good point, will remove in v2.

Regards,
Phil