Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Eric Snowberg <eric.snowberg@oracle.com>
To:     dhowells@redhat.com, dwmw2@infradead.org, ardb@kernel.org,
        jarkko@kernel.org
Cc:     jmorris@namei.org, serge@hallyn.com, eric.snowberg@oracle.com,
        nayna@linux.ibm.com, zohar@linux.ibm.com, keescook@chromium.org,
        torvalds@linux-foundation.org, weiyongjun1@huawei.com,
        keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org,
        James.Bottomley@HansenPartnership.com, pjones@redhat.com,
        konrad.wilk@oracle.com
Subject: [PATCH v10 1/8] integrity: Fix warning about missing prototypes
Date:   Tue, 25 Jan 2022 21:58:27 -0500
Message-Id: <20220126025834.255493-2-eric.snowberg@oracle.com>
In-Reply-To: <20220126025834.255493-1-eric.snowberg@oracle.com>
References: <20220126025834.255493-1-eric.snowberg@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IU1WcfUI26qjaHjShCOIlKTbks1uUHQZwLyCRp/daHQyDKIkGOhgeEWy7//h?=
 =?us-ascii?Q?aPT7cuSSreB/ACHoFuYoQVuFsphpoEuQt2MeRMBoe1psWgxaSm0neVhZ9FIN?=
 =?us-ascii?Q?XOahRGNzCBqgaQQVLQSW20sJm5boVQ2OncPM26+UrUQeIK5daGmD3ilfngm1?=
 =?us-ascii?Q?XaBlDCDqhz3E6dom1EaUuEwZSoGqavHaYZXtXNJI5Dy7NxkgT6eezSmMKY/A?=
 =?us-ascii?Q?16UHn//b3wrY3B1W34EVG1XjllPZkKQTUNqfoXGUvThRS7sOIDv/8mDY9NVK?=
 =?us-ascii?Q?LaZQ+5iEukVh3QZJ9WXI8gNVa64VJJYwxPopO7rwaQbDqyPP0m/5YpgI6PqY?=
 =?us-ascii?Q?LWbhiuBB1Nu/DE6+vbR8RYxfgZe2xWPYQZZyNAHNOZ3zQFyqDM1q6pt3Xy4V?=
 =?us-ascii?Q?XINJ1r2eFz3+Cff4HaSfs4b7kdrt2GViLx49Ln/VAlef4NlOW4+0IPyxXOMb?=
 =?us-ascii?Q?SqYe0WPoQs3zIxoxTv2u4IeZb3vW+G6M2LSIp7lr+azAHykV52MKS6YtmhF6?=
 =?us-ascii?Q?buYDU7tPP2Gqh0NjqYDeGaRVvdH+Pp76OqVKd7DzJgCJABhFmWAnxIhZhQIr?=
 =?us-ascii?Q?EgcBegZvtM2KFaLJHA/gyVX1Lu7F/FbbtsDvOVNggxaKZ4SxKV/3N/WGT8w2?=
 =?us-ascii?Q?EXUME/ToUkdVM+ol5Ny2DmlU7Wtw9NiA1berg3voRT4B45m0ebilnkfpXCG4?=
 =?us-ascii?Q?QUwesB/31ISj3n8JTxS8yYldtqClwN893AH78gbvliYkBb2ueLNHsRz7Je+p?=
 =?us-ascii?Q?NkYMPWYk552bL8sSLvYVUpSxW4R3YJadx351Yd50uOEZlU70l7ctpzO8HRDz?=
 =?us-ascii?Q?UB5iWxsk5sJQ3YEUL/E4YXerCj4ag7m913GtboSwGF1aW34WXqeMDJsZIv4K?=
 =?us-ascii?Q?Le8HkStpD72JYPlgrOhbOEpS8UcUib+1tugsRMJjOGsXGp1rtoFI+b9ck8gy?=
 =?us-ascii?Q?umfX/aocxmT9ZnqMgNk88B2g3V4T3GsYNp5ojpahlx8F+9Vbo2dUtB5SBi1V?=
 =?us-ascii?Q?i3W0xSKB5TAJl+WUsJgp5IPrWnOv1VuM/vmpv8nvUkMCJD7zlARkKpusVUzU?=
 =?us-ascii?Q?v3RLlHiHpDnx2RRDmA6T2tYb+X6L9Dj1NASpPaVYICrYNEJNIcgf/9mQvm6m?=
 =?us-ascii?Q?7OglzS5FwMbdm5lzaA46sh7lSfeE5LNVFyMjlw7ynmKRMbwFXAEs9EmmJqb1?=
 =?us-ascii?Q?lk/19Ds0mSEVaV4mVveU11nfLnz4iX8jzQvUfiIbp31WW621SBWBtf9y54+4?=
 =?us-ascii?Q?xhIjh+9+LrDD1EiTVzDts3ym50FNFO2J36700iB/BSXYfRcWNdczVwAo+Pe7?=
 =?us-ascii?Q?m4uUUGi0J7wxTtWyWi3CiruegnEu+O2UNtts5SIXx/JKkHchJcbZYlkD3/CB?=
 =?us-ascii?Q?ZQnjt34tIzZflCrLXLwGl9yQfgH2ANej8bQfA6ixFulNMeFmqXxpUhIq53Nw?=
 =?us-ascii?Q?0tEY+2sdhB8RgJ7m6ZS4dU4M4XJ+Qt0p7kgtcwlXvU+aYz5T//TfwPKE7Lfz?=
 =?us-ascii?Q?nxrtCQVi6wUBBlp1EH69un7B+P4gch+w78Em6pKE452Jdfr3WxuXoOEx/Ix7?=
 =?us-ascii?Q?pyOAckSgoNjErmb5HdCJJu8Pe98VcG0H2aZGWu9oSh+tLs6QSubWL2Ch223f?=
 =?us-ascii?Q?aYDl2h5gPWmFM5tkzNfc0qBL4MjczM3u1fUvWsV7Js3Yg8jBXJ7qtz84Mvuw?=
 =?us-ascii?Q?rivylRjJBswaUerUyMPcn/FLJks=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 08cd10c9-d6aa-4a58-13bb-08d9e077dfa9
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4150.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2022 02:59:30.9327
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mXNqFCYYy0+y7xgRuhp019KeHM2MlsaGN/z6HpX2hNxtcCwvMC1HFCnmOnR0gxiRtrehVZLczdpglEYhc58z9P4FdXZjkBb3THAlO8J9eck=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4654
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10238 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 malwarescore=0
 spamscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2201260011
X-Proofpoint-GUID: 9-1jgdk0ZwmpPJlMv9N7xxvqOWdiKQrs
X-Proofpoint-ORIG-GUID: 9-1jgdk0ZwmpPJlMv9N7xxvqOWdiKQrs
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

make W=1 generates the following warning in keyring_handler.c

security/integrity/platform_certs/keyring_handler.c:71:30: warning: no previous prototype for get_handler_for_db [-Wmissing-prototypes]
 __init efi_element_handler_t get_handler_for_db(const efi_guid_t *sig_type)
                              ^~~~~~~~~~~~~~~~~~
security/integrity/platform_certs/keyring_handler.c:82:30: warning: no previous prototype for get_handler_for_dbx [-Wmissing-prototypes]
 __init efi_element_handler_t get_handler_for_dbx(const efi_guid_t *sig_type)
                              ^~~~~~~~~~~~~~~~~~~
Add the missing prototypes by including keyring_handler.h.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Eric Snowberg <eric.snowberg@oracle.com>
Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Tested-by: Mimi Zohar <zohar@linux.ibm.com>
---
v7: Initial version
v8: Code unmodified from v7 added Mimi's Reviewed-by
v9: Unmodified from v8
v10: Added Jarkko's Reviewed-by and Mimi's Tested-by
---
 security/integrity/platform_certs/keyring_handler.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/security/integrity/platform_certs/keyring_handler.c b/security/integrity/platform_certs/keyring_handler.c
index 5604bd57c990..e9791be98fd9 100644
--- a/security/integrity/platform_certs/keyring_handler.c
+++ b/security/integrity/platform_certs/keyring_handler.c
@@ -9,6 +9,7 @@
 #include <keys/asymmetric-type.h>
 #include <keys/system_keyring.h>
 #include "../integrity.h"
+#include "keyring_handler.h"
 
 static efi_guid_t efi_cert_x509_guid __initdata = EFI_CERT_X509_GUID;
 static efi_guid_t efi_cert_x509_sha256_guid __initdata =
-- 
2.18.4