Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp5338431pxb; Wed, 26 Jan 2022 09:43:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJz5Wqld/IKkzORK5qd9yiEMp5PdSIdSS2tCNl+tZ6aCqWP+CdbpDJg5BYEbKCmgLwL8xRNO X-Received: by 2002:a63:8049:: with SMTP id j70mr13382pgd.242.1643218980952; Wed, 26 Jan 2022 09:43:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643218980; cv=none; d=google.com; s=arc-20160816; b=MYqYEVzi+VHK9Y0FcQUIKaL9v+eVjqmiiR+0aYueNp97xdki/VEzV0L864YKw+ZjOg 9MV2R3fDWzFCwGcIv9icbDBRPEGrgo84nQG5aZJ7WyM9qaYbLieB2Zk7XrQodPZzYBmR aSVQmhGvQMDxSpmvtIglr1RumsWGYmeE7BaorWKMyAFtV/rvEsqHfR47zbdM+RIoY3nM rQY7cZ7A1GhxvSsvDEpgL4lbXlhc9E+23vMRZFVn8mnUqb8ZjdVYHwkGMWFSsy6ghrqv rbgn7bZ/STdeha4f9WBHq5AlmtSebfp35nOmVm82gS6S7qrqeiN2FxqT/7EBD79/WjpM 7FHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=z9pO9JeYxx8dUty0hG4HIRTB12lX88WUzS3sPis9EZ0=; b=kO70eS/odKMYXQsTPeri4bMlbN81Y9bZ5ok6fK/aTMN12t4S0MmkTPXgyXQF2iWAWJ 6NdAqeDAGcVEda5Ro6/1Jld6BhXkKy1LnRrqDFIef0Gx96c5udoGoUSe4vZspApxOG2w pnyvxbp9rG5PDhuwxgRrHUxCe1BxSSjEeCmb1ayjE1/k6WFad75JA/X5StkHFbhPRNX8 p/6HXmkEiE2cDYdz9b8kWxyzNfJR/uSpzn/ODgH4CKXvyTaLocVu4YlB88wGimubL/Lv mo1p+jAYYL9bzadUcJa1L+rQYelqMz45Z4RJXRloJ6LgZAFBOPIfHrGG7tdenzOB0f9o x2Jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uT40UsbO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u10si6907889plg.209.2022.01.26.09.42.42; Wed, 26 Jan 2022 09:43:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uT40UsbO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237320AbiAZDum (ORCPT + 99 others); Tue, 25 Jan 2022 22:50:42 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:47740 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233406AbiAZDul (ORCPT ); Tue, 25 Jan 2022 22:50:41 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2016861551; Wed, 26 Jan 2022 03:50:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2750EC340E3; Wed, 26 Jan 2022 03:50:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643169040; bh=bUEyqTE3wW9PTA5v+s//0JwnrjvPDueySOlPKcGveMU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uT40UsbOUxWQBJx7pcrLRGQ6cEUB8SvUbMXmBhQAlJ3YVxWJG/3euMGOzWzugyqPk HFUtZcLlHcVixKhBOpuevndO1cnYsBUJ8sKvValnDMV3Z2B8A6v+K6UKfKyIvaih5o 7WF6U1Gwqy/Eqji+nwc9pZExP5dE3kj91QF0u612GKAf613oh1PXU9CwPLAnW5Z0Bp y2hTWTbmHpjaZdSJUX/53LiYFBHMJYKWdsUJrQNrMY8X3u4n+ddPvDDspGOU3qNh9i mqRCUv7jUnQCdD7ZjpoVvMtrxoI5ZfRVY/qiAqr6AfPdMbmD/4B/aNqS4VM2Hvh+/3 4INpy9hMQQvVQ== Date: Tue, 25 Jan 2022 19:50:38 -0800 From: Jakub Kicinski To: Guangbin Huang Cc: , , , , , Subject: Re: [RESEND PATCH net-next 1/2] net: hns3: add support for TX push mode Message-ID: <20220125195038.6a07b3c4@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20220125072149.56604-2-huangguangbin2@huawei.com> References: <20220125072149.56604-1-huangguangbin2@huawei.com> <20220125072149.56604-2-huangguangbin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Jan 2022 15:21:48 +0800 Guangbin Huang wrote: > + __iowrite64_copy(ring->tqp->mem_base, desc, > + (sizeof(struct hns3_desc) * HNS3_MAX_PUSH_BD_NUM) / > + HNS3_BYTES_PER_64BIT); Doesn't build, missing closing bracket?