Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 25 Jan 2022 19:55:08 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Guangbin Huang <huangguangbin2@huawei.com>
Cc:     <davem@davemloft.net>, <wangjie125@huawei.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <lipeng321@huawei.com>, <chenhao288@hisilicon.com>
Subject: Re: [RESEND PATCH net-next 2/2] net: hns3: add ethtool priv-flag
 for TX push
Message-ID: <20220125195508.585b0c40@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <20220125072149.56604-3-huangguangbin2@huawei.com>
References: <20220125072149.56604-1-huangguangbin2@huawei.com>
        <20220125072149.56604-3-huangguangbin2@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 25 Jan 2022 15:21:49 +0800 Guangbin Huang wrote:
> From: Yufeng Mo <moyufeng@huawei.com>
> 
> Add a control private flag in ethtool for enable/disable
> TX push feature.

I think it's a pretty standard feature for NICs which also support RDMA.
Mellanox/nVidia has it (or at least it the previous gen HW did),
Broadcom's bnxt driver does it as well.

Can we make this a standard knob via ethtool? Not entirely sure under
which switch, maybe it's okay to add it under -g? Perhaps we need a new
command similar to -k but for features contained entirely to the driver?