Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20220123111644.25540-1-krzysztof.kozlowski@canonical.com> <20220123111644.25540-2-krzysztof.kozlowski@canonical.com>
In-Reply-To: <20220123111644.25540-2-krzysztof.kozlowski@canonical.com>
From:   Alim Akhtar <alim.akhtar@gmail.com>
Date:   Wed, 26 Jan 2022 12:28:58 +0530
Message-ID: <CAGOxZ51zavNVpvUv0C17Cit+pdkERC70m5Ez3ELGpFh8tGDozQ@mail.gmail.com>
Subject: Re: [PATCH 01/12] arm64: dts: exynos: add USB DWC3 supplies to
 Espresso board
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        linux-usb <linux-usb@vger.kernel.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Krzysztof

On Mon, Jan 24, 2022 at 1:34 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> Add required voltage regulators for USB DWC3 block on Exynos7 Espresso
> board.  Due to lack of schematics of Espresso board, the choice of
> regulators is approximate.  What bindings call VDD10, for Exynos7 should
> be actually called VDD09 (0.9 V).  Use regulators with a matching
> voltage range based on vendor sources for Meizu Pro 5 M576 handset (also
> with Exynos7420).
>

I checked Espresso board schematic, it is 0.9V for the USB and supplied by LDO4

> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 5 +++++
>  arch/arm64/boot/dts/exynos/exynos7.dtsi         | 2 +-
>  2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> index 125c03f351d9..4c45e689d34a 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> @@ -412,6 +412,11 @@ &ufs {
>         status = "okay";
>  };
>
> +&usbdrd {
> +       vdd10-supply = <&ldo4_reg>;
> +       vdd33-supply = <&ldo6_reg>;
> +};
> +
>  &usbdrd_phy {
>         vbus-supply = <&usb30_vbus_reg>;
>         vbus-boost-supply = <&usb3drd_boost_5v>;
> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> index c3efbc8add38..01b4210d8b62 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> @@ -672,7 +672,7 @@ usbdrd_phy: phy@15500000 {
>                         #phy-cells = <1>;
>                 };
>
> -               usbdrd3 {
> +               usbdrd: usb {
>                         compatible = "samsung,exynos7-dwusb3";
>                         clocks = <&clock_fsys0 ACLK_USBDRD300>,
>                                <&clock_fsys0 SCLK_USBDRD300_SUSPENDCLK>,
> --
> 2.32.0
>


-- 
Regards,
Alim