Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 26 Jan 2022 08:08:48 +0100
From:   Richard Leitner <richard.leitner@linux.dev>
To:     Tommaso Merciai <tomm.merciai@gmail.com>
Cc:     Richard Leitner - SKIDATA <Richard.Leitner@skidata.com>,
        "linuxfancy@googlegroups.com" <linuxfancy@googlegroups.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: usb251xb: add boost-up property support
Message-ID: <YfDzgPwhkIpFv+yR@ltleri2>
References: <20220121232612.7283-1-tomm.merciai@gmail.com>
 <Ye5PUpp9eMX9jSRe@ltleri2>
 <20220125214245.GA4196@tom-ThinkPad-T470p>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220125214245.GA4196@tom-ThinkPad-T470p>
Precedence: bulk

On Tue, Jan 25, 2022 at 10:42:45PM +0100, Tommaso Merciai wrote:
> On Mon, Jan 24, 2022 at 07:03:57AM +0000, Richard Leitner - SKIDATA wrote:
> > On Sat, Jan 22, 2022 at 12:26:12AM +0100, Tommaso Merciai wrote:
> > >  
> > > +	if (!of_property_read_u8(np, "boost-up", &property_u8)){
> > > +		hub->boost_up = property_u8;
> > 
> > IMHO we don't need the property_u8 var here as you could pass
> > &hub->boost_up directly to of_property_read_u8() ?
> 
> Hi Richard,
> Thanks for your reply. You mean like:
> 
> if (!of_property_read_u8(np, "boost-up", &hub->boost_up))

exactly.

> 
> Let me know. I'll fix that in v2.
> 

great!

thanks & regards;rl