Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp5452446pxb; Wed, 26 Jan 2022 12:18:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJxCdYta6qHjs+wDsWtsyxDT6/sO01k27OQoI0EEDqAanhirS3CGBrr/lZAvqpNwy3bYiwMt X-Received: by 2002:a17:90b:4a0a:: with SMTP id kk10mr601070pjb.208.1643228280325; Wed, 26 Jan 2022 12:18:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643228280; cv=none; d=google.com; s=arc-20160816; b=l7dFhVz09TSm31U8htMMLLeGhWAu4fCUQSVGg+yf/1ZSzeZHFTTByEyteBdqvoUVIN nAsKG4qjoEgtJVW3eZZ1cP6o9t1q2kYQ0y6o1wRbSc93ug5kmZaYb2i6LXeGZXWzlUcc 0FjrdMyIEgOiFMg4AP8I3GZRACSFCWQL8OZNlb/F8Zh15ozvUfL4gJ9OS2osxuYPGWip ZPtXhkbbCgUhGoEUCEPk/Z9e4hlyzS85WSR+FxQJMCVyE6FswVKJT9VI66sJiPoIAGlz 43uqyKZtIDZ7BFjkEANxYiqiDd+xlBGCFxC7PMKUHo9pKVEeFFj+MBASqKlnBaJo3Cfc KHJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1YiAgXr+T+5PoTxk9FObhMmaDmPyu89BDQODNplz5ss=; b=0o/f+mRksAlwshfFal0z6hpWy10cSxCNMbPfLn6/Pg8kFjJM+S+fGMxBPibH+sjhMa JS1CtEgFiad/268endNUg8uFU/kx1htZA1SEXpoXD1tNykkl12MKEd4w13E8ti9l8RA9 szGUN1tB/hbnVK1ksVXHjgrtkxKqaN8p3ZhgOsmk/rKegJkSd5Sg+8hH7tzMHYWutn6s Q8VA48vnllG6WwNARmbzp72gWZM/XK/6KJqm820Yu2uDvZoj3x0E03vdgXV6EJf6VkF9 VGYVGU3SjkZkeaJyOrl6GUd1pSDMYrhbR3zg4iuuG7Y8HSZPI5H20RWGfWl4aOUke2Dc m48g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=tR1PVeVh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m7si188953pfd.342.2022.01.26.12.17.47; Wed, 26 Jan 2022 12:18:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=tR1PVeVh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237679AbiAZHQn (ORCPT + 99 others); Wed, 26 Jan 2022 02:16:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237647AbiAZHQm (ORCPT ); Wed, 26 Jan 2022 02:16:42 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66B02C06161C for ; Tue, 25 Jan 2022 23:16:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1YiAgXr+T+5PoTxk9FObhMmaDmPyu89BDQODNplz5ss=; b=tR1PVeVh0kUvMiGgRtLM2fOQ8K a2KuIVjewWnSb8v44m2iDOO4jcZ36NweKW2xo/+IVLcoIhsnwEcwtI2eswSVYIGlV9JzePM5fNiQb u2ZuFweoqGoljY/MUDiHc7UNTX+VHt+SB2j5U/ZMAd0UK8BYLe9g5l5t1c5Md24DEB//oX0QKnHwH +fQcsHq4euN5yXeFa7mHf4DEDk7k4mkQqhyEWaOXf53iKvwYp7He+KSNG+vUBAyRpQekvDhORzD90 ADb0uW8dydlFFMuwv4GhnU+CjKnprYYDHiFuNEhfsDZNN2MvSVYLn/0Nm2L2m+Hn4IeOcuUDoaWnu 0Oim0frQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCcXo-00ASlK-KM; Wed, 26 Jan 2022 07:16:40 +0000 Date: Tue, 25 Jan 2022 23:16:40 -0800 From: Christoph Hellwig To: Anshuman Khandual Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, hch@infradead.org, akpm@linux-foundation.org Subject: Re: [RFC V1 02/31] mm/mmap: Clarify protection_map[] indices Message-ID: References: <1643029028-12710-1-git-send-email-anshuman.khandual@arm.com> <1643029028-12710-3-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1643029028-12710-3-git-send-email-anshuman.khandual@arm.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + [VM_NONE] = __P000, > + [VM_READ] = __P001, > + [VM_WRITE] = __P010, > + [VM_READ|VM_WRITE] = __P011, > + [VM_EXEC] = __P100, > + [VM_EXEC|VM_READ] = __P101, > + [VM_EXEC|VM_WRITE] = __P110, > + [VM_EXEC|VM_READ|VM_WRITE] = __P111, > + [VM_SHARED] = __S000, > + [VM_SHARED|VM_READ] = __S001, > + [VM_SHARED|VM_WRITE] = __S010, > + [VM_SHARED|VM_READ|VM_WRITE] = __S011, > + [VM_SHARED|VM_EXEC] = __S100, > + [VM_SHARED|VM_READ|VM_EXEC] = __S101, > + [VM_SHARED|VM_WRITE|VM_EXEC] = __S110, > + [VM_SHARED|VM_READ|VM_WRITE|VM_EXEC] = __S111 Please add whitespaces around the | operators. Otherwise looks good: Reviewed-by: Christoph Hellwig