Received: by 2002:a05:6a10:af89:0:0:0:0 with SMTP id iu9csp5462408pxb; Wed, 26 Jan 2022 12:33:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJxj3BQRAll+sZ1O9NJMwV2+D6KzzQBQb9P4NB3t4rFNJ/F2EiYMKizh0xIqJ1d3cuv8F16x X-Received: by 2002:a63:358c:: with SMTP id c134mr495914pga.116.1643229213319; Wed, 26 Jan 2022 12:33:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1643229213; cv=none; d=google.com; s=arc-20160816; b=m7qGj5bpo9ocN1ir3vMNXhGEbBQCfbph8bnt8oM7lw6CXm9z2LYxLGunfhBysF2LU7 LVo9uf3F65ZPZlTL/EpPViuCpb3EhdO0YUGVLV9EfhKTXk9qtIh/vnIalyEv8HynAa0x XTiehETfveiUknZ5GpqTJeiQlZ4hv0PMEzo1iaeDL0TG4yJNL98tgMI8SvsX1um0YHWR xP4hOWBhjzL2VIKHNoSr0c5DuMiP7ghWSGtN3dieMNGAlkykOqS22/nTZ4GjbYZpzZzl 9cqp5eKUAK1cydosDl6clI4IbjtwHVwZ9SWZTCeynARJSWWcXwPNoIKCwL/LIg8zC7ys qF/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=BGWljlTr9Q5xPRGp4H5G0kng/4W1lTPQPYHkwyGS2kE=; b=gdT90VJRccCwQHw+R7dTf8e3lCb6GYfZIm3xF/iSOFpeufhlxnkemgWTJxjpaCwx/4 nA56dKAgQ8zPCKZZw921239Q98F7nngDklswJw5yoVRe3T0tiBefgMawn1Mp0d3jJXX7 I3d4ceJD25dETfRh924VAjGu0qOgOl50YQiOvxzNSjE4Ia/N8wP/gXGpMwmuiQeUVRJr N2Jxoo/DmAYf463vixTAQi1aqFYsmyNG61/C9mDhIZRlLjltVX86cp88m4hG6EGEa/C+ GPqc+TIGy3sdUCr6woRkS3BJWPSh32Urg0VB6Z92aXPsrXdDahvnqzAMaK2Vl4EdxRlm BfZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=gkOgIOP1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e21si227005pgj.698.2022.01.26.12.33.21; Wed, 26 Jan 2022 12:33:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=gkOgIOP1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238338AbiAZIUX (ORCPT + 99 others); Wed, 26 Jan 2022 03:20:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238339AbiAZIUR (ORCPT ); Wed, 26 Jan 2022 03:20:17 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F37EC06161C; Wed, 26 Jan 2022 00:20:17 -0800 (PST) Received: from zn.tnic (dslb-088-067-221-104.088.067.pools.vodafone-ip.de [88.67.221.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8A4731EC052A; Wed, 26 Jan 2022 09:20:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1643185210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=BGWljlTr9Q5xPRGp4H5G0kng/4W1lTPQPYHkwyGS2kE=; b=gkOgIOP1drCqOCGgupEyHCHNgEIxSylkjZQRCAfAv5qhBPrNO8A5NmKzyE4qWBCxs0UgTJ EZ0T+iozkEO9VNHPbJat42XG/9daPWe2bmd9WMJMwuX+rIg51AMC+3VEi8e5FlDl6dbu6+ lMlGW/vKw9InDnkm/afN1h87SGxDCiU= Date: Wed, 26 Jan 2022 09:20:07 +0100 From: Borislav Petkov To: Shuai Xue Cc: rric@kernel.org, mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com, ardb@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, zhangliguang@linux.alibaba.com, zhuo.song@linux.alibaba.com Subject: Re: [PATCH v5 0/2] EDAC/ghes: refactor memory error reporting to avoid code duplication Message-ID: References: <20211210134019.28536-1-xueshuai@linux.alibaba.com> <20220126081702.55167-1-xueshuai@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220126081702.55167-1-xueshuai@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 26, 2022 at 04:17:00PM +0800, Shuai Xue wrote: > ghes_edac_report_mem_error() in ghes_edac.c is a Long Method and have > Duplicated Code with cper_mem_err_location(), cper_dimm_err_location(), and > cper_mem_err_type_str() in drivers/firmware/efi/cper.c. In addition, the > cper_print_mem() in drivers/firmware/efi/cper.c only reports the error > status and misses its description. Dude, what about wait for a week or until the patchset has been fully reviewed don't you understand?! Please let me know what about the review process is not clear to you so that we can document it better. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette