Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 26 Jan 2022 17:24:26 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Andrej Picej <andrej.picej@norik.com>
Cc:     robh+dt@kernel.org, s.hauer@pengutronix.de,
        devicetree@vger.kernel.org, festevam@gmail.com,
        kernel@pengutronix.de, linux-kernel@vger.kernel.org,
        y.bas@phytec.com
Subject: Re: [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd
 subdevices
Message-ID: <20220126092426.GJ4686@dragon>
References: <20211216115529.2331475-1-andrej.picej@norik.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211216115529.2331475-1-andrej.picej@norik.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Thu, Dec 16, 2021 at 12:55:28PM +0100, Andrej Picej wrote:
> phyFLEX PMIC DA9063 has also RTC and watchdog support. Add both
> mfd subdevices so they can be used.
> 
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
> ---
>  arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> index f3236204cb5a..2ec154756bbc 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -205,6 +205,14 @@ vdd_mx6_high_reg: ldo11 {
>  				regulator-always-on;
>  			};
>  		};
> +
> +		pmic_rtc: rtc {

Maybe a more specific label like the following?

		da9063_rtc: rtc

And it's more aligned with da9063_wdog below.

> +			compatible = "dlg,da9063-rtc";
> +		};
> +
> +		da9063_wdog: wdt {

watchdog for the node name.

Shawn

> +			compatible = "dlg,da9063-watchdog";
> +		};
>  	};
>  };
>  
> -- 
> 2.25.1
>