Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <4b1bf433-067b-ebfb-4603-2e31e1990f77@redhat.com>
Date:   Wed, 26 Jan 2022 11:21:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] mm/highmem: remove unnecessary done label
Content-Language: en-US
To:     Miaohe Lin <linmiaohe@huawei.com>, akpm@linux-foundation.org
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20220126092542.64659-1-linmiaohe@huawei.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20220126092542.64659-1-linmiaohe@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 26.01.22 10:25, Miaohe Lin wrote:
> Remove unnecessary done label to simplify the code.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>  mm/highmem.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/mm/highmem.c b/mm/highmem.c
> index 762679050c9a..0cc0c4da7ed9 100644
> --- a/mm/highmem.c
> +++ b/mm/highmem.c
> @@ -736,11 +736,11 @@ void *page_address(const struct page *page)
>  		list_for_each_entry(pam, &pas->lh, list) {
>  			if (pam->page == page) {
>  				ret = pam->virtual;
> -				goto done;
> +				break;
>  			}
>  		}
>  	}
> -done:
> +
>  	spin_unlock_irqrestore(&pas->lock, flags);
>  	return ret;
>  }
> @@ -773,13 +773,12 @@ void set_page_address(struct page *page, void *virtual)
>  		list_for_each_entry(pam, &pas->lh, list) {
>  			if (pam->page == page) {
>  				list_del(&pam->list);
> -				spin_unlock_irqrestore(&pas->lock, flags);
> -				goto done;
> +				break;
>  			}
>  		}
>  		spin_unlock_irqrestore(&pas->lock, flags);
>  	}
> -done:
> +
>  	return;
>  }
>  

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb