Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 26 Jan 2022 11:10:14 +0000
Message-ID: <87ee4u7nxl.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc:     linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        kernel-team@android.com, Jay Chen <jkchen@linux.alibaba.com>
Subject: Re: [PATCH v3] irqchip/gic-v3-its: Reset each ITS's BASERn register before probe
In-Reply-To: <20220126095726.GA23794@lpieralisi>
References: <20220124133809.1291195-1-maz@kernel.org>
        <20220126095726.GA23794@lpieralisi>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 26 Jan 2022 09:57:26 +0000,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote:
> 
> >  static void __init its_acpi_probe(void)
> >  {
> >  	acpi_table_parse_srat_its();
> > -	acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR,
> > -			      gic_acpi_parse_madt_its, 0);
> > +	if (acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR,
> > +				  its_acpi_reset, 0) > 0)
> > +		acpi_table_parse_madt(ACPI_MADT_TYPE_GENERIC_TRANSLATOR,
> > +				      gic_acpi_parse_madt_its, 0);
> 
> Maybe it is worth adding a comment here as you did for DT if you
> can before merging it - to clarify the first acpi_table_parse_madt()
> call logic.

Sure, I'll add that.

> 
> Other than that:
> 
> Reviewed-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.